Don Turner
47bc4a7b88
Merge pull request #504 from android/dt/fix-build-warnings
...
Fix build warnings
2 years ago
Don Turner
4484743830
Merge pull request #453 from LinX64/no_bookmarks_state_test
...
[Saved screen] Added the test for empty state and refactor
2 years ago
Don Turner
1acee42167
Merge pull request #493 from andhiratobing/main
...
Set visibility modifier of composable preview to private
2 years ago
Don Turner
cf053ade5a
Fix build warnings
2 years ago
Muhammad Anas Shamsi
2534bdc5f8
CI error due to invalid file format resolved
2 years ago
Don Turner
5638e253ae
Fix unit and UI tests. Apply spotless.
...
Change-Id: Iab75852a27a44309d349f84e65226911ab59fcd5
2 years ago
magicalmeghan
ec4bceead3
Renamed SaveableNewsResource to UserNewsResource
2 years ago
magicalmeghan
6941e2082b
Renamed SaveableNewsResource to UserNewsResource
2 years ago
Muhammad Anas Shamsi
a9a8a18d16
remove the redundant "interests" prefix
2 years ago
Muhammad Anas Shamsi
cfe6e65311
Typo fix for search
2 years ago
ratobing
1e493c0bbc
Set visibility modifier of composable preview to private
2 years ago
Alex Vanyo
154f05e23f
Remove tab state from InterestsViewModel
...
Change-Id: I5c15015f27fa0aa7709d0c3959d761355c8d9722
2 years ago
Nick Rout
8a051eaa5c
Fix spotless issues
2 years ago
Nick Rout
c12fe1fbe5
Update :core-designsystem module based on Figma file
2 years ago
mlykotom
0018144827
LoadingWheel testTag for every loading wheel
...
Change-Id: I7728e1717925abdfb607e93f3d48226910d42c0d
2 years ago
mlykotom
ec6e902c0f
Waiting for topic selection
...
Change-Id: I44226a7c5e693ee92eed27070c09cd4e0751e674
2 years ago
Jolanda Verhoef
4ba63c0de8
Remove author concept from app
...
Change-Id: Icd03c0288ba5f3f23dbcbdbefbbe802db2815793
2 years ago
Márton Braun
9c22a7a4e7
Remove `Stream` suffixes
...
Change-Id: I45decae965d7e35289d3fa31fc58b8c463fbead1
2 years ago
mlykotom
9c22af19eb
Rename variables
...
Change-Id: Iccfc7cdd76c8ad1c866eeff8d621952c3e9c4db6
2 years ago
mlykotom
8f52fcdfe5
Add TODO with ReportDrawnWhen
2 years ago
mlykotom
2242b8a1dc
Fix waiting for content
2 years ago
Milosz Moczkowski
9ddf45e12c
Merge pull request #358 from YuraLaguta/main
...
Fixes #341 Defines enter & exit animations for OverlayLoadingWheel on…
2 years ago
Mohsen Rzna
4ded548ba7
Spotless apply - new version
2 years ago
Mohsen Rzna
d865c6421e
Reverted the changes back for import
2 years ago
Mohsen Rzna
40838f8138
Spotless apply
2 years ago
Mohsen Rzna
932f80a281
Added the test for empty state and refactor
2 years ago
Yura Laguta
9dc969fe63
Fixes #341 Defines enter & exit animations for OverlayLoadingWheel on ForYouScreen
2 years ago
Mohsen Rzna
c19b8b9319
New empty bookmarks handling ( #443 )
...
* Added the png file for error state
This should be removed later - couldn't convert the design to vector from svg - there is a problem with the `<mask` tag.
* Added two new strings based on the Figma file
* Redesign and reimplementation for the empty BookmarksScreen along with two clarifying comments.
* Removed the png file and replaced it with vector
* Code refactor after code reviewing
Made contentDescription null, removed extra spaces and renaming for the Composable function as suggested.
* Moved the modifier after Text
* Added a space after the curly bracket to pass the Spotless check
* Spotless apply
* Simplify logic in Bookmarks screen
* Change order of composables in BookmarksScreen and add previews
* Refactor after code review
Removed the space before `if`, and changed the padding from 5 to 8dp.
Co-authored-by: Jolanda Verhoef <JolandaVerhoef@users.noreply.github.com>
2 years ago
Milosz Moczkowski
aa4d930c20
Merge pull request #386 from android/jv/topic-colors
...
Tint topic icons to theme's primary color
2 years ago
Milosz Moczkowski
c62673d035
Merge pull request #179 from Abhimanyu14/niaicons
...
Icons alignment to use NiaIcons
2 years ago
Milosz Moczkowski
bbc5460b62
Merge pull request #427 from LinX64/bookmarks_empty_data
...
Handling empty bookmarks on Saved view
2 years ago
Milosz Moczkowski
26a9dfe5d7
Merge pull request #434 from hoc081098/refactor_ForYouViewModel
...
ForYouViewModel: replace snapshotFlow with flowOf
2 years ago
hoc081098
51c7ea2fe4
ForYouViewModel: replace snapshotFlow with flowOf
2 years ago
Mohsen Rzna
e61d9156db
Added the check for empty list on Success
...
So basically here I am checking if the feed count is not empty, then show the data, otherwise, show a simple `Text()` to notify that the user hasn't bookmarked a feed yet!
2 years ago
Mohsen Rzna
45c229fe47
Added the string for the Text
...
It is just showing "No bookmarks yet!" to the user
2 years ago
Abhimanyu14
d69a37af7c
Icons alignment to use NiaIcons
2 years ago
Simon Marquis
671a048e7c
Fix spotless issues
2 years ago
Simon Marquis
90dc300783
Migrate from JUnit assertions to Kotlin's test framework
...
Fixes #419
2 years ago
Don Turner
5b8c284c74
Rename hasDismissedOnboarding to shouldHideOnboarding
...
Change-Id: I8a6b35f7216f9944652d8da346e7458614311e08
2 years ago
Don Turner
6654403498
Refactor onboarding to save interests to user data
...
Change-Id: I97772a8b65e1e94a95187ebb7c514104af2d3a08
2 years ago
Jolanda Verhoef
10447f2dfa
Merge pull request #390 from android/jv/author-item-improvements
...
[UX] Improve AuthorItem
2 years ago
Don Turner
8a816e2149
Add feedback link
2 years ago
Jolanda Verhoef
58ffd8781a
Make author images fill their circle in onboarding
2 years ago
Jolanda Verhoef
7e04447cff
Improve AuthorItem behavior
2 years ago
Jolanda Verhoef
b49086fc4f
Tint topic icons to theme's primary color
2 years ago
Ben Trengrove
3a501f4530
Allow InterestsItem to be skipped on recomposition
...
Add a benchmark for topics state change
2 years ago
Don Turner
9a06a7a93b
Add link to brand guidelines, remove redundant R
2 years ago
Don Turner
f3ea2853fd
Update licenses URL
2 years ago
Don Turner
b9156f6812
Fix UI tests
2 years ago
Don Turner
756e45eb82
Add note about b/221643630
2 years ago
Don Turner
501d29be59
Add back spacer for navigation bar
2 years ago
Don Turner
dbff140b64
Fix minor issues
2 years ago
Don Turner
e5183e21e0
Resolve conflict with navigation changes from main
2 years ago
Don Turner
76daa393b1
Address review feedback from Manu
2 years ago
Don Turner
828242dbad
Remove Scaffold from top level screens
2 years ago
Don Turner
3a106534e7
Remove Scaffold from BookmarksScreen
2 years ago
Don Turner
c3f7870412
Fix spotless issues
2 years ago
Don Turner
56c0645816
Add tests
2 years ago
Don Turner
d42881e5d4
Add UI architecture for Settings dialog
2 years ago
Don Turner
8c30ab9f80
Add settings module, refactor top bar
2 years ago
Jolanda Verhoef
b6cae161c2
Add basic UI for theme switcher
2 years ago
Manuel Vivo
a0b22d8ed2
Updates Navigation approach with new guidance ( #347 )
2 years ago
Automerger
9435c1cd79
Merge branch 'github/main'
2 years ago
Ben Weiss
7e6cb46436
Merge pull request #328 from android/bw/moreJankstats
...
Add more jank tracking
2 years ago
Ben Weiss
ee2e3db928
Add more jank tracking
2 years ago
Don Turner
f3debd0af1
Merge "Add domain layer. See go/nia-domain-layer for details." into main
2 years ago
Don Turner
4a4de7d6a4
Add domain layer. See go/nia-domain-layer for details.
...
Change-Id: I3f4684005e81fb9c4163bf59c7026dcff6e88dc4
2 years ago
Wojtek Kaliciński
dcc23829d4
Migrate packages to namespaces in build files
...
Change-Id: I21e021caa0ea72a7097dfd9af04a3c07a0cc9aa5
2 years ago
Don Turner
6351a89545
Merge pull request #310 from android/documentation/dep_graphs
...
Add dependency graphs to every module
2 years ago
Adetunji Dahunsi
c4debb74e7
Give feedback when syncing on ForYouScreen
...
Change-Id: I10a646e8a17f81d96351e69d36f0cb6ccf28e05c
2 years ago
Milosz Moczkowski
06e60063b5
Add dependency graphs to every module
...
Change-Id: I629fef818f7521c13bb3069a3ff9ed9bc42e57f3
2 years ago
Alex Vanyo
14ae167b69
Merge pull request #242 from android/av/built-in-insets
...
Update material3 with built-in insets support
2 years ago
Alex Vanyo
9be6e846d9
Apply spotless
...
Change-Id: I49eeb1984cb3e978a9cee5c1e4d53e856a10bb4e
2 years ago
Alex Vanyo
738210166a
Refine backgrounds and navigation colors
...
Change-Id: I9fd863cc608f21078ab78c39c2c3d227aedbac7c
2 years ago
Caren
4a1fb58c34
Merge pull request #301 from android/caren/topics_bookmarks
...
Enable bookmarks on topics page
2 years ago
Alex Vanyo
8c11769622
Update to material3 1.0.0-beta03 wih built-in insets support
...
Change-Id: I4d07f89d4faa6e3417468ad78acf3fbb161f0797
2 years ago
Milosz Moczkowski
f914d6a412
Merge pull request #299 from android/refactor/remove_episodes
...
Remove episodes related code
2 years ago
Caren
cf9cf1d781
Fix test
2 years ago
Caren
33e77ce6bc
Fix tests
2 years ago
Caren Chang
4e11b7342b
Run spotless
2 years ago
Caren Chang
e0e664846d
Rename topicState -> topicUiState
2 years ago
Caren Chang
ccf60dca6c
Fix indents
2 years ago
Caren Chang
6b2d93d42c
Fix tests
2 years ago
Caren Chang
31189f3328
Enable bookmarks on topics page
2 years ago
Automerger
3083c5e2ce
Merge branch 'github/main'
2 years ago
Caren
d89812ee90
Merge pull request #288 from android/caren/remove_search
...
Remove Search from top app bar
2 years ago
Milosz Moczkowski
cbdf6a2d3c
Remove episodes related code
2 years ago
Automerger
233b416ee5
Merge branch 'github/main'
2 years ago
Don Turner
5fedbe95d8
Merge pull request #293 from Kashif-E/main
...
changed newUiState to newsUiState in AuthorViewModel.kt and AuthorVie…
2 years ago
Automerger
6765d79065
Merge branch 'github/main'
2 years ago
Takeshi Hagikura
9ae03c3590
Fix the lint warnings
2 years ago
Takeshi Hagikura
74737cad49
Introduce Multipreview annotation to simplify the preview configurations
...
- Bump the AGP version to 7.3.0
- Introduce Multipreview annotation class that represents device
previews and theme previews
Fixes #282
2 years ago
kashif mehmood
e2db3c1a28
changed newUiState to newsUiState in AuthorViewModel.kt and AuthorViewModelTest.kt
2 years ago
Caren Chang
b74767921c
Remove Search from top app bar
2 years ago
Wojtek Kaliciński
4683918cc7
Move spotless to init script
...
Also adds automatic git hooks installation
Change-Id: I18debbee43af27db7b95a4202f824fa87e186713
2 years ago
Wojtek Kaliciński
d0cff2b11c
Build cleanup
...
* Move Hilt setup to convention plugin
* Disable Hilt on modules where it's not needed
* Enable non-transitive R classes
* Fix `configuration` blocks called in wrong scope
* Move imperative Flavors code from build.gradle
* Disable unnecessary build features globally
* Disable configure-on-demand as it's not encouraged
* Don't use internal AGP packages in plugins
Change-Id: I1bee3e3fd0103054637b979a350f9fd2312ae8ba
2 years ago
madroid
c35699280e
Move 'feature-' module to feature subfolder
2 years ago