318 Commits (1fd341d2088fe296e61244d24cbf72b663eff032)

Author	SHA1	Message	Date
Jaehwa Noh	1fd341d208	Change name to searchTextWithThreeSpaces_isEmptyQuery() ... Co-authored-by: Don Turner <dturner@users.noreply.github.com>	2 years ago
Jaehwa Noh	bc59112b65	Update feature/search/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModelTest.kt ... Change name to emptySearchText_isNotAddedTorecentSearches() Co-authored-by: Don Turner <dturner@users.noreply.github.com>	2 years ago
Jaehwa Noh	8528ab178c	Merge branch 'android:main' into main	2 years ago
Don Turner	db5e2b649e	Remove unnecessary Boxes ... Change-Id: Ia404cde7f6b555234bef4b27058fabd4471ea3c6	2 years ago
dturner	27fd4e544a	🤖 Updates screenshots	2 years ago
Jaehwa Noh	f1a55cced3	Create test stateIsEmptyQuery_withThreeWhiteSpacesAndOneLetterSearchQuery ... Change-Id: Iee59f6085e4045b2e3c532f78804926290b6c6c5	2 years ago
Jaehwa Noh	324b693289	Apply trim at query to remove whitespace. ... Change-Id: Id349af4bb1af3d0f1c3973e6fb9e6f3e7b924d9b	2 years ago
dturner	02d4fea615	🤖 Updates screenshots	2 years ago
Jaehwa Noh	983c6fec14	Add UI logic to prevent blank text search in SearchScreen. ... - Early return to do not call onSearchExplicitlyTriggered() Change-Id: I28db284eac9059fb6f48dd718721a1fc5fdb8f7a	2 years ago
Jaehwa Noh	b0e121263e	Create stateIsEmptyQuery_withThreeWhiteSpacesSearchQuery test. ... Change-Id: I6d6e8f9fe988ca83fae484e4f2338ad6fe58b676	2 years ago
Jaehwa Noh	1976c4cf3c	Add 'or' to prevent search when query is blank. ... Change-Id: If498de05889d6d5946b1bbb1d1c10cb311bb9b52	2 years ago
Jaehwa Noh	ad2c782317	Change org.junit.Assert.assertNull to kotlin.test.assertNull. ... Change-Id: I60083b0b9a1dcaed84d957b49c91e5163d5659d6	2 years ago
Jaehwa Noh	9fb4c6a64b	Import org.junit.Assert.assertNull	2 years ago
Jaehwa Noh	cd6224c3c3	assertEquals to assertNull. ... Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	2 years ago
Jaehwa Noh	d1582a0114	Apply early return.	2 years ago
Jaehwa Noh	aa42b488a2	Create test emptySearchText_NotAddToRecentSearches ... - For empty query not add in recent query list.	2 years ago
Jaehwa Noh	97686cbd8f	Add if state to prevent blank query.	2 years ago
dturner	81a5c0a3a7	🤖 Updates screenshots	2 years ago
Don Turner	76d59b3da8	Merge branch 'main' into update-compose-bom	2 years ago
Don Turner	1d2029aa2c	Merge pull request #1040 from SimonMarquis/fix-unit-test ... Fix `emptyResultIsReturned_withNotMatchingQuery` unit test	2 years ago
dturner	9e645356f6	🤖 Updates screenshots	2 years ago
Don Turner	2271d01da5	Fix spotless ... Change-Id: I8d19c437fc6e2e2198af5ac871c3f7813d280923	2 years ago
Don Turner	b1d867f827	Replace BoxWithConstraints with Box (fixes linter error) ... Change-Id: Iea0401e28ae0e884511800652fde0f1896642aa0	2 years ago
dturner	6b2b01ed82	🤖 Updates screenshots	2 years ago
Don Turner	522efac8c0	Update Compose BOM to 2024.02.00. Fixes #1218 ... Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b	2 years ago
Don Turner	69f4287ab5	Merge branch 'main' into lifecycle2.7.0 ... * main: Bump protobuf from 3.24.4 to 3.25.2 (#1214) Remove legacy benchmark build type (#1207) Use androidx.tracing everywhere Revert fast initialization of Coil Add comment for Retrofit async OkHttp Optimize OkHttp initialization for Retrofit Add braces Inline initialization Don't use runBlocking if async init completed Launch loader directly without additional coroutine scope Fix comment Improve lazy loading for Coil + OkHttp Restores screenshot tests in foryou (#1199) Fix name and message of dependency guard actions (#1196) Change-Id: Ifcbfcfba4b7d8c24599e207b4a05dfea6125fde7	2 years ago
Don Turner	2ad48843f6	Fix formatting ... Change-Id: I674d32bc0f1921c431717dbf0f41a74f632322b3	2 years ago
Ben Weiss	f64f1c0aa2	Remove legacy benchmark build type (#1207) ... * Remove legacy benchmark build type Now that we have the baseline profile gradle plugin, there is no need for a benchmark build type. The plugin does the setup and configuration and runs against the correct app flavor. * Remove explicit benchmark build type from benchmark module * Remove stale build task exclusions * Fix tracing import location FYI @mlykotom	2 years ago
Don Turner	254b464259	Update Lifecycle to 2.7.0. Use new LifecycleEventEffect. ... Change-Id: I71e7aa521f22499fd3f3e9f3ac7c81658f3abc3a	2 years ago
Tomáš Mlynarič	d9aaec0699	Use androidx.tracing everywhere ... Change-Id: I847827efc08f5cbc00f0c809ad992c267f826e50	2 years ago
Jose Alcérreca	3ff5d48f37	Restores screenshot tests in foryou (#1199)	2 years ago
Simon Marquis	5a1258232f	Fix `emptyResultIsReturned_withNotMatchingQuery` unit test ... `searchResultUiState` transitively relied on `getSearchContentsCount` updates and on `userDataRepository` to emit something.	2 years ago
Don Turner	707117a4f2	Merge branch 'main' into kotlinify	2 years ago
Don Turner	0f0511748e	Merge pull request #1088 from SimonMarquis/cleanup-dependencies ... Reduce overall build complexity	2 years ago
Simon Marquis	b043d8db86	Replace workaround on SettingsViewModel now that a fix has been deployed ... The issue has been addressed in `androidx.compose.ui:ui:1.5.0`.	2 years ago
Don Turner	89d39a7242	Merge pull request #767 from SimonMarquis/resource-prefix ... Enforce `resourcePrefix` on Android library modules	2 years ago
Simon Marquis	cd62fd5e01	Update feature/search/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/search/navigation/SearchNavigation.kt	2 years ago
Simon Marquis	b7a628ece5	Update feature/interests/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/interests/navigation/InterestsNavigation.kt	2 years ago
Simon Marquis	6cd5958665	Update feature/bookmarks/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/bookmarks/navigation/BookmarksNavigation.kt	2 years ago
Simon Marquis	65f0d5b2d9	Update feature/foryou/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/foryou/navigation/ForYouNavigation.kt	2 years ago
Don Turner	9d41ffa318	Merge branch 'main' into kotlinify	2 years ago
Simon Marquis	b6d82e24df	Merge branch 'main' into kotlinify	2 years ago
lihenggui	2a2d8ed88d	Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE	2 years ago
lihenggui	32e1ec0447	Remove violations: property-naming	2 years ago
lihenggui	f8f932705a	Remove violations: discouraged-comment-location	2 years ago
lihenggui	fb5bd225be	Spotless	2 years ago
Simon Marquis	f27a2e176e	Reduce overall build complexity ... - Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces - Correctly configure the visibility of dependencies: - `api` when it's part of it's public `api` - `implementation` when it's part of it's internal `implementation` - Remove unnecessary dependencies in build.gradle.kts files - Remove unnecessary dependencies provided by plugins - Remove unnecessary applied plugins (i.e. roborazzi) - Sort dependencies in `build.gradle.kts` - Delete unused entries in `libs.versions.toml`	2 years ago
Simon Marquis	caa482bc71	Kotlinify codebase ... - Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)	2 years ago
Simon Marquis	988002e692	Update Robolectric 4.11.1 ... - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11 - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1 > Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below. Removing explicit API 33 Robolectric configuration.	2 years ago
Miłosz Moczkowski	9c89e98e5b	Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold" ... This reverts commit 335a7ec68c, reversing changes made to aa8ce0e1f6.	2 years ago