60 Commits (173ac6711a0a7ae62f73bcb639b9c1df067a7276)

Author	SHA1	Message	Date
Jaehwa Noh	ee4320723f	Fix typo. ... Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f	9 months ago
Jaehwa Noh	ed91723e2f	Fix #1270 ... Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c	9 months ago
Alex Vanyo	e3c7018124	Extract ScreenshotHelper to separate testing module ... Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af	9 months ago
Tomáš Mlynarič	f31fdb3ec2	Merge branch 'main' into mlykotom/tz-perf-improvement ... Change-Id: Id49a580012629163ec4a3663d95ab71b98910220 # Conflicts: # app/dependencies/prodReleaseRuntimeClasspath.txt # app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt # gradle/libs.versions.toml	9 months ago
Tomáš Mlynarič	ea1573fcc1	Use kotlinx.datetime.Timezone instead of java ZoneId ... Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628	10 months ago
Simon Marquis	b687328567	Replace comments with proper `@TestOnly` annotations	10 months ago
Simon Marquis	a83f6691c4	Fix addNewsResources issue	10 months ago
Simon Marquis	5a1258232f	Fix `emptyResultIsReturned_withNotMatchingQuery` unit test ... `searchResultUiState` transitively relied on `getSearchContentsCount` updates and on `userDataRepository` to emit something.	10 months ago
Tomáš Mlynarič	0b3ece1bb9	Fix spotless ... Change-Id: I6583fa9ed7c1563f6164653be9bbaf7904ec0215	10 months ago
Tomáš Mlynarič	cb00d2c8cb	Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers ... This way, we can save ~1ms per composed item on screen. Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d	10 months ago
Don Turner	707117a4f2	Merge branch 'main' into kotlinify	11 months ago
Don Turner	0f0511748e	Merge pull request #1088 from SimonMarquis/cleanup-dependencies ... Reduce overall build complexity	11 months ago
Simon Marquis	be9dc533e3	Replace `Enum.values()` with `Enum.entries` ... 'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9	11 months ago
Don Turner	9d41ffa318	Merge branch 'main' into kotlinify	12 months ago
lihenggui	f8f932705a	Remove violations: discouraged-comment-location	12 months ago
lihenggui	fb5bd225be	Spotless	12 months ago
Simon Marquis	f27a2e176e	Reduce overall build complexity ... - Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces - Correctly configure the visibility of dependencies: - `api` when it's part of it's public `api` - `implementation` when it's part of it's internal `implementation` - Remove unnecessary dependencies in build.gradle.kts files - Remove unnecessary dependencies provided by plugins - Remove unnecessary applied plugins (i.e. roborazzi) - Sort dependencies in `build.gradle.kts` - Delete unused entries in `libs.versions.toml`	12 months ago
Simon Marquis	caa482bc71	Kotlinify codebase ... - Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)	1 year ago
Mario Manhique	b2c1c11218	Update MainDispatcherRule.kt ... Updated MainDispatcherRule parameter accessibility to private because its only needs to be accessible inside that class.	1 year ago
Simon Marquis	a33dafccad	Migrate from `java` to `kotlin` sourceSet directory	1 year ago
Jose Alcérreca	151f877bbe	Adds screenshot tests to :core:designsystem (#931) ... * WIP: Adds screenshot tests to :core:designsystem Change-Id: I0672845feba4064652dd8d60f07047b87864e121 * 🤖 Updates screenshots * Creates tests for more components and cleans up Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22 * WIP: More cleanup and more combinations of themes Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523 * Added the rest of the screenshot tests for designsystem Change-Id: Ic427db5491910781c038882055524e3f3dbed194 * Some more cleanup Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180 * Spotless Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6 * 🤖 Updates screenshots * ScreenshotHelper cleanup Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0	1 year ago
Roy Matero	298f3ce4db	Merge branch 'android:main' into main	1 year ago
Jose Alcérreca	5b79869324	Adds dark screenshot tests and fixes background colors in ForYou (#918) ... * Adds dark screenshot tests and fixes background colors in ForYou * 🤖 Updates screenshots	1 year ago
Roy Matero	4e6cda1965	Renamed toggle function signature with boolean parameters ... Change-Id: I0d6c0ed4d4c0ee4bd387e5645fc558970f5f202b	1 year ago
Jose Alcérreca	886158d3cb	Adds Screenshot testing with Roborazzi (#876) ... * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	1 year ago
Simon Marquis	f1bc6f1226	Restore `Unknown` type as empty `String`	1 year ago
Simon Marquis	daa2228132	Restore original `type` labels	1 year ago
Simon Marquis	0377fd8712	Replace `NewsResourceType` enum with simpler String type ... See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901	1 year ago
Don Turner	492697ce6b	Merge pull request #873 from SimonMarquis/misc-warnings ... Fix miscellaneous warnings	1 year ago
Simon Marquis	e8449112b4	Replace StringDecoder injection with simpler API ... The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String. For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`). Unit tests would fail because Uri is not mocked (since we are not using Robolectric). Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc. FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded". The solution to this problem was to simply use regular Java APIs: - `URLDecoder.decode(urlEncodedTopicId, "UTF-8")` - `URLEncoder.encode(topicId, "UTF-8")`	1 year ago
Simon Marquis	4bdc9705af	Fix miscellaneous warnings ... - Remove unused namespace declaration - Collapse empty manifest tags - Remove redundant qualifier name - Remove redundant suppression	1 year ago
prosixe	c779b4e8ca	Typo fix for topics ... tocpis -> topics	1 year ago
TJ Dahunsi	c4686cfa54	Track when deep link notifications are opened ... Change-Id: I223b1c8fbca36f9b7f2a35d9cb2fa901d6f5be91	1 year ago
James Rose	7826b4f5f2	Merge pull request #748 from SimonMarquis/fix/permissions ... Grant `POST_NOTIFICATIONS` permission in more instrumented tests	2 years ago
Miłosz Moczkowski	5bf66739bd	Remove redundant statements ... Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89	2 years ago
Don Turner	d319264ef0	Provide Default dispatcher for instrumented tests ... Change-Id: I488a9b9d9d3864ce9496614ab35332ec19d06bcc	2 years ago
Simon Marquis	823c4db201	Grant `POST_NOTIFICATIONS` permission in more instrumented tests ... Continues the work initiated in #738. Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.	2 years ago
TJ Dahunsi	ef97cb941c	Route notification deep link through for you screen	2 years ago
Takeshi Hagikura	b3cdc172cd	Implement search feature (#685) ... Implement search feature - Add a feature module named "search" - Add a SearchScreen that is navigated by tapping the search icon at the top left corner - Add a data layer that takes care of populating the *Fts tables and querying them by a search query - Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen The SearchScreen has following features: - The user is able to type the search query in the TextField - The search result is displayed as the user types - When the search result is clicked, it navigates to: - The InterestsScreen when a topic is clicked - Chrome custom tab with the URL of the clicked news resource - When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches - Latest recent searches are displayed in the SearchScreen	2 years ago
James Rose	050db2cb72	Merge branch 'main' into jr/track-viewed	2 years ago
Adetunji Dahunsi	08956492c8	Backend triggered sync ... Change-Id: I53c43b136ebb755f6258b1e815301dddb3b536a3	2 years ago
James Rose	57c13d84bd	Incorporate code review changes: Move UserNewsResourceRepository to data ... module; move UserNewsResource to model module. Implement unread dot for bookmarked articles. Keep the flows cold in UserNewsResourceRepository.	2 years ago
James Rose	9ee2acf327	Add viewed status for news resources to data layer	2 years ago
Adetunji Dahunsi	09f5c3bc61	Add NewsResourceQuery to better query encapsulation ... Change-Id: I93f8c8ae2d1144975f6f9ff1ba93be9a4600768a	2 years ago
Miłosz Moczkowski	bcb4d7d592	Replace global variables with PreviewParameterProvider	2 years ago
Márton Braun	819dd494ad	Run Spotless to add trailing commas (and apply other rule updates) ... Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209	2 years ago
Angie Sasmita	6046f6e943	Add dynamic color option in settings for API >=32 ... Change-Id: Ib42c1cbd0208e98ef7610a1c8aca5d721aa464e6	2 years ago
Don Turner	24df51349d	Move mapping logic into secondary constructor ... Change-Id: I032326f502d27f2d3bd9fb8273ae44df878d172c	2 years ago
Don Turner	355b0540aa	Move construction of UserNewsResource into separate function ... Change-Id: I7c1f6427cd7d95c2016349fec301b88455b33cf2	2 years ago
Jolanda Verhoef	4ba63c0de8	Remove author concept from app ... Change-Id: Icd03c0288ba5f3f23dbcbdbefbbe802db2815793	2 years ago