89 Commits (1552664857969c6bbaba1dcd073cfc75e3df4019)

Author	SHA1	Message	Date
Jonathan Koren	19f6f9e09a	2 pane support in Interests screen (#1234) ... * Add dependency on material3 adaptive Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6 * Add InterestsListDetailScreen composable Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971 * Store selectedTopicId in InterestsViewModel Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce * Pass detail pane composable down Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293 * Navigate to initial topic if provided Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b * Lift LDPS up to app module Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85 * Fix some navigation behavior Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b * Navigate to initial topic if provided Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed * Remove dependency in interests feature module Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f * Hide back arrow when the topics list is visible Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8 * Update interests tests Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd * Highlight selected topic when displaying 2 panes Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415 * update dependency baselines Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00 * run spotless apply Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8 * Convert isListPaneHidden to isListPaneVisible Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657 * Set semantics for selected state Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca * Use scaffold roles when determining visibility Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648 * Update multipleBackStackInterests test Change-Id: I1e372f7989817151a6765205291b13b561187fa8	9 months ago
Don Turner	747c9275bc	Merge pull request #1249 from android/dt/fix-1231 ... Remove unused release variable. Fixes #1231	9 months ago
Don Turner	77cbdb62a4	Remove unused release variable. Fixes #1231 ... Change-Id: I8c03d3d2e1aee85a22d1a03b97e3bec4069e0fcb	9 months ago
Alex Vanyo	e3c7018124	Extract ScreenshotHelper to separate testing module ... Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af	9 months ago
Tomáš Mlynarič	75a3295381	Merge branch 'main' into mlykotom/tz-perf-improvement ... Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c # Conflicts: # app/dependencies/prodReleaseRuntimeClasspath.txt # build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt	9 months ago
Ben Weiss	f64f1c0aa2	Remove legacy benchmark build type (#1207) ... * Remove legacy benchmark build type Now that we have the baseline profile gradle plugin, there is no need for a benchmark build type. The plugin does the setup and configuration and runs against the correct app flavor. * Remove explicit benchmark build type from benchmark module * Remove stale build task exclusions * Fix tracing import location FYI @mlykotom	10 months ago
Tomáš Mlynarič	395b9853df	Add Composition Tracing ... Change-Id: I3ad60930de2fab71a700a0c2df3f0a1f566cafd8	10 months ago
Simon Marquis	f27a2e176e	Reduce overall build complexity ... - Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces - Correctly configure the visibility of dependencies: - `api` when it's part of it's public `api` - `implementation` when it's part of it's internal `implementation` - Remove unnecessary dependencies in build.gradle.kts files - Remove unnecessary dependencies provided by plugins - Remove unnecessary applied plugins (i.e. roborazzi) - Sort dependencies in `build.gradle.kts` - Delete unused entries in `libs.versions.toml`	12 months ago
Jonathan Koren	392eaa3e61	Add dependencyGuard to AndroidApplicationConventionPlugin ... Change-Id: Ib695ca18512d0ccde4c67e101f09ebbff8897912	1 year ago
Jonathan Koren	d15a203c59	Only record prodReleaseRuntimeClasspath configuration ... Change-Id: I129fc4839ac2b4d5624c91cd25b47efba8847f44	1 year ago
Jonathan Koren	d5d5e3561f	Add dependency guard plugin	1 year ago
Miłosz Moczkowski	9c89e98e5b	Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold" ... This reverts commit 335a7ec68c, reversing changes made to aa8ce0e1f6.	1 year ago
Miłosz Moczkowski	816a7b60c1	Replace manual navigation component switching with new NavigationSuiteScaffold ... Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723	1 year ago
Ben Weiss	aa8ce0e1f6	Add automated baseline profile generation (#880) ... Baseline profile generation is disabled for the PR level Build task. Release tasks require a fresh baseline profile. A new profile is generated using the baseline profile Gradle plugin. * Prepare for usage of dex layout optimizations which can be actively used once NiA switches to AGP 8.2+. * Add GMD config to release build * Switch to macos-latest * Update names for StartupBenchmark tests to better reflect states * Stable release and recent GMD device * Reduce flakiness by adding wait to benchmark * More convenient waiting for objects * Rename junit dependency to androidx-junit * Only run baseline profile benchmarks during GH workflow * Enable automatic BP generation for only release builds * Disable BP generation from Build workflow * Specify modules and skip benchmarking Build workflow Bug: b/299334172	1 year ago
Daniel Santiago	c908f989c8	Update to Hilt 2.48.1 and use the KSP version ... * Moved protobuf to separate module to avoid having to wire KSP's Plugin with the Protobuf Plugin. * `@Binds` function cannot be an extension function. * Commented `kotlin.compiler.execution.strategy=in-process` in CI to circumvent OOMs due to increased metaspace usage.	1 year ago
Don Turner	a381d13199	Merge pull request #958 from McGalanes/main ... Use typesafe project accessors	1 year ago
Melwin Magalhaes	6247712064	Add convention plugins to version catalogs	1 year ago
Melwin Magalhaes	b1266dc05a	Use typesafe project accessors for project modules	1 year ago
Simon Marquis	49a2fb5272	Fix wrong configuration name, leaking `work-testing` to runtime classpath ... Typo introduced recently when Roborazzi was added to the project: 886158d3cb (diff-8cff73265af19c059547b76aca8882cbaa3209291406f52df1dafbbc78e80c46)	1 year ago
Jose Alcérreca	886158d3cb	Adds Screenshot testing with Roborazzi (#876) ... * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	1 year ago
Don Turner	e96e54f7de	Merge pull request #806 from SimonMarquis/objenesis ... Remove forced resolution strategy	1 year ago
Alex Vanyo	2b218b97d9	Switch to new Activity.enableEdgeToEdge ... Change-Id: I9bbb7b2d116099524525619714ef18448e707c4f	1 year ago
Don Turner	654944430d	Fix for Retrofit R8 issue, bump version to 0.1.2 ... Change-Id: Ia90d693731c95248211b12b1ce2e9dfab0ecf34c	1 year ago
Don Turner	7f62b725a6	Bump version to code=7, name=0.1.1 ... Change-Id: I2d8fa940dc5e4c14e3c9df650bc1f1432a330f02	1 year ago
Automerger	44c3c6d947	Merge branch 'github/main'	1 year ago
Murat Yener	e96dac39b2	changed from ListenableFuture.get() to ListenableFuture.await()	1 year ago
Simon Marquis	0a3069a0d8	Remove forced junit resolution strategy ... By looking at the Gradle scan's dependency tab, junit 4.12 is already replaced by 4.13.2. There is no need to manually force this at the configuration level.	1 year ago
Simon Marquis	d332f7b70d	Remove forced objenesis resolution strategy ... The linked issue is marked as resolved, and not able to reproduce the mentioned compilation error.	1 year ago
Automerger	0c2e01bf4e	Merge branch 'github/main'	2 years ago
Miłosz Moczkowski	fc3d0ced20	Replace hardcoded license file with OSS licenses plugin ... Change-Id: I4427fd5d7b7abd8a2912a41f61ffedfac4af9d6a	2 years ago
Don Turner	0829cb73f7	Bump version name to 0.1.0 (versionCode 6) ... Change-Id: I880683a37b4324f91499eeb47b418ab5e2d1242b	2 years ago
Simon Marquis	1341f7c2c5	Replace unused variable with simpler method calls	2 years ago
Simon Marquis	1921c6544d	Replace deprecated methods	2 years ago
Takeshi Hagikura	b3cdc172cd	Implement search feature (#685) ... Implement search feature - Add a feature module named "search" - Add a SearchScreen that is navigated by tapping the search icon at the top left corner - Add a data layer that takes care of populating the *Fts tables and querying them by a search query - Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen The SearchScreen has following features: - The user is able to type the search query in the TextField - The search result is displayed as the user types - When the search result is clicked, it navigates to: - The InterestsScreen when a topic is clicked - Chrome custom tab with the URL of the clicked news resource - When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches - Latest recent searches are displayed in the SearchScreen	2 years ago
AlfianHanantio	bcd4a6de59	Remove redundant code block for managed virtual device creation	2 years ago
Caren	6a5feb767e	Merge pull request #582 from yschimke/loaders ... Improve network pooling and avoid startup image fetches.	2 years ago
Yuri Schimke	9e399b69ea	Improve network pooling and avoid startup image fetches. ... Change-Id: If747fb0833d31ce7c9bedffd400160e979bc945e	2 years ago
Don Turner	75f8fc7e08	Bump versionCode to 5 ... Change-Id: I4d6dc6b8d1a903172b7f11ab6166f6c631b1319b	2 years ago
Don Turner	4284e6912e	Merge remote-tracking branch 'github/main' into feb9automerger ... * github/main: Bump version to 4 Remove unused DropdownMenu component Route topic chip tap events up to NiaNavHost Apply suggestions from code review Migrate custom room configuration into a convention plugin Update docs/ArchitectureLearningJourney.md - User action follow topic Update docs/ArchitectureLearningJourney.md - Writing data Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea	2 years ago
Don Turner	d80668407a	Bump version to 4	2 years ago
Don Turner	2a4d0434a5	Add Firebase analytics. See go/nia-firebase-services. ... Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689	2 years ago
Automerger	ebb070c73b	Merge branch 'github/main'	2 years ago
Mohsen Rzna	46c1d510d4	Android-CI workflow -> GMD refactor (#537) ... This PR is about updating the operating system to macOS-12 as the previous one was going to be deprecated, as well as updating the checkout to v3 to avoid the warnings in the panel; adding setup SDK action to accept the license which was missing from the beginning. I also added imports instead of adding them directly with the codes. As a reference, there was another PR with a similar topic, but it wasn't complete: #483	2 years ago
Ben Weiss	f316be1d69	Add Firebase dependencies ... This sets up the project for using Firebase Crashlytics and Performance Monitoring. Change-Id: I8d14cfd2e5c2ba1911f2c3175adc20d6714addb6	2 years ago
Takeshi Hagikura	4633609930	Introduce GMD + ATD (#479) ... Introduce Gradle Managed Device definitions to modules that have instrumented tests. At the moment, defining it as a convention plugin isn't possible due to the bug. That bug is now fixed and will be included in Android Studio Flamingo. Once Flamingo becomes stable, convert the GMD definitions as a convention plugin (#523) Change-Id: I0866369e3d0bbe148ca5ec1f92bad59239a347b8	2 years ago
Jolanda Verhoef	4ba63c0de8	Remove author concept from app ... Change-Id: Icd03c0288ba5f3f23dbcbdbefbbe802db2815793	2 years ago
Alex Vanyo	369cd33b7a	Add accompanist/testharness ... Adds a usage of accompanist/testharnness to force a given DpSize for its content, overriding the density if necessary to ensure that the size is achieved. This allows testing UI at arbitrary sizes on arbitrary emulators, lessening the need for using multiple emulators at different sizes (and filtering tests) when Android-specific window size has been hoisted appropriately. The initial test using it is a test for checking whether or not the navigation bar or navigation rail is being shown, and these tests can run on any emulator. Change-Id: I315384e5eafac23a3cd6d3818d9828f6d3c1acfc	2 years ago
mlykotom	7db33aa041	Refactor naming according to convention ... Change-Id: Id74e2495d5909e4978247e0d7edfb5621b2064ff	2 years ago
mlykotom	eea70382d6	Fix code style	2 years ago
mlykotom	7ebc718ca0	Enable R8	2 years ago