Don Turner
2a4d07b95f
Merge pull request #704 from SimonMarquis/fix/reports-archive
...
Fix incomplete build reports
2 years ago
gururani-abhishek
51379a249d
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
...
1. removed the unused onItemClick parameter
2. removed now redundant variables it used
3. removed its description from the comments.
2 years ago
vishesh211
079f92ea32
feat: added launchSingleTop in navigate
2 years ago
vishesh211
487a288191
fix: removed disableSplitMotionEvents
2 years ago
Simon Marquis
1269b29aee
Fix incomplete build reports
...
- Add all generated lint reports (only app was archived)
- Add all unit tests reports (none were archived)
- Add all APKs (missing app-nia-catalog) and remove unnecessary files (logs, sdkDependencies, proguard's config/mapping/seeds etc. which are also quite large compared to APKs)
2 years ago
Simon Marquis
cd6931d673
Fix instrumented test reports archives
...
- Fixes missing tests reports from `AndroidCIWithGmd.yaml`
```
Warning: No files were found with the provided path: '**/*/build/reports/androidTests/'. No artifacts will be uploaded.
```
- Fixes missing tests reports from `Build.yaml`, where only top-level tests from `:app` were reported.
2 years ago
Simon Marquis
4550743fac
Create and use CI specific group of GMD devices
...
This should reduce the total CI time of `AndroidCIWithGmd` workflow.
Using the matrix strategy at the GitHub Actions level forces us to run the tests sequentially and download/rebuild everything from scratch at each iteration.
2 years ago
Simon Marquis
ef27c050b6
Add missing gradle/gradle-build-action setup in AndroidCIWithGmd.yaml
...
This will prevent downloading and unzipping Gradle distribution but fetch it from the cache instead like other workflows.
2 years ago
Simon Marquis
a68fe38411
Use dedicated build step to package test apps before spawning the emulator
2 years ago
Simon Marquis
69a2634f0c
Merge branch 'main' into ci/androidTest
2 years ago
Adetunji Dahunsi
d905701028
Merge pull request #700 from android/tj/update-sync-notification-sender
...
Update message sender in SyncNotificationsService
2 years ago
Adetunji Dahunsi
c364dfc84e
Update message sender in SyncNotificationsService
2 years ago
Don Turner
fe80b78f7d
Merge pull request #629 from vketteni/bugfix-ArchitechtureLearningJourney-md
...
Correct a table entry of a code reference from ArchitectureLearningJo…
2 years ago
Don Turner
2fd1b716f6
Merge pull request #667 from SimonMarquis/cleanup/warnings
...
Cleanup warnings and replace deprecated methods
2 years ago
Don Turner
70b9c4c347
Merge pull request #666 from SimonMarquis/update/kotlin-1.8.20
...
Update Kotlin 1.8.20 stack
2 years ago
Don Turner
544e7b30e6
Merge pull request #696 from SimonMarquis/patch/androidTests
...
Disable unnecessary Android instrumented tests
2 years ago
Milosz Moczkowski
c746b6afcd
Merge pull request #598 from takagimeow/fix/clean-up-unused-update-topics
...
Clean up unused updateTopics and updateNewsResources methods
2 years ago
Simon Marquis
57d1bed2cc
Disable unnecessary Android instrumented tests
2 years ago
Simon Marquis
246d6c6528
Use dedicated build step to package test apps before spawning the emulator
2 years ago
Simon Marquis
5500edc37b
Update KSP 1.8.20-1.0.11
2 years ago
Simon Marquis
661dd2bc2e
Update Kotlin 1.8.20 stack
...
- KSP 1.8.20-1.0.10
- Compose compiler 1.4.5
2 years ago
Simon Marquis
f19dd06200
Remove deprecated `kotlin.Experimental` opt-in
...
This would produce the following warning messages:
```
w: Opt-in requirement marker kotlin.Experimental is unresolved. Please make sure it's present in the module dependencies
```
2 years ago
Simon Marquis
1341f7c2c5
Replace unused variable with simpler method calls
2 years ago
Simon Marquis
459717f8ba
Remove `DSL_SCOPE_VIOLATION` suppression as it is now fixed in Gradle 8.1
2 years ago
Simon Marquis
1921c6544d
Replace deprecated methods
2 years ago
Alex Vanyo
1998fc1a20
Fix JVM target comment
...
Change-Id: I9e62b796ed096f6cf586b51dc3a8e81f79c62e50
2 years ago
Don Turner
c8b776658a
Merge pull request #689 from android/source_target_compat_to_11
...
Set the source/target compatibility to 11
2 years ago
Takeshi Hagikura
e1bb03b33d
Set the source/target compatibility to 11
...
This is because up to Java 11 features are supported without requiring
minimum API level nor AGP versions at the moment as in
https://developer.android.com/studio/write/java11-minimal-support-table
2 years ago
Don Turner
e1ae12129a
Merge pull request #662 from android/av/agp-8.0
...
Update to AGP 8.0
2 years ago
Don Turner
ad1ec28eb3
Merge pull request #678 from SimonMarquis/patch-2
...
Don't rely on `finalizeDsl` API to configure Crashlytics
2 years ago
Takeshi Hagikura
b3cdc172cd
Implement search feature ( #685 )
...
Implement search feature
- Add a feature module named "search"
- Add a SearchScreen that is navigated by tapping the search icon at the top left corner
- Add a data layer that takes care of populating the *Fts tables and querying them by a search query
- Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen
The SearchScreen has following features:
- The user is able to type the search query in the TextField
- The search result is displayed as the user types
- When the search result is clicked, it navigates to:
- The InterestsScreen when a topic is clicked
- Chrome custom tab with the URL of the clicked news resource
- When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches
- Latest recent searches are displayed in the SearchScreen
2 years ago
Adetunji Dahunsi
73a38720d8
Merge pull request #649 from android/tj/backend-requested-sync
...
Wire up backend requested sync
2 years ago
Adetunji Dahunsi
6b834b6f4c
Applied code review suggestions
...
Change-Id: I12fab8e0d27a8a1805e0063054ec3382bebd78f1
2 years ago
Adetunji Dahunsi
b3f2502ec2
Update core/data/src/test/java/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt
...
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
2 years ago
Adetunji Dahunsi
f86d174c1b
Used more explicit variable names in tests
...
Change-Id: I2e0ebead70441eced05eb786aaa7683bfefa8976
2 years ago
Adetunji Dahunsi
337c940d66
Add comments explaining backend sync and made variable names easier to grok
...
Change-Id: I90cd7444de95efa20bf243a922a772f7849a23ec
2 years ago
Adetunji Dahunsi
022cd92f4c
Update core/data/src/main/java/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepository.kt
...
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
2 years ago
Neelansh Sahai
adc9381bb5
Merge pull request #640 from android/fr-undo-bookmark-removal
...
Add Undo snackbar on Bookmark removal
2 years ago
Simon Marquis
3a810f015b
Remove unused variables
2 years ago
Milosz Moczkowski
6d87dc6888
Merge pull request #680 from SimonMarquis/patch-4
...
Delete no longer used `AUTHORS_ASSET` reference
2 years ago
Simon Marquis
9499e559e7
Delete no longer used `AUTHORS_ASSET` reference
2 years ago
Simon Marquis
091abad348
Simplify String resource loading in NavigationTest.kt
2 years ago
Simon Marquis
80b8ae7a98
Don't rely on `finalizeDsl` API to configure Crashlytics
2 years ago
Neelansh Sahai
bf747434cd
Add Undo snackbar on Bookmark removal
...
Change-Id: I1fefd6e72378e26ae35b66e032529a116cff9a79
2 years ago
Milosz Moczkowski
2c18740d62
Merge pull request #665 from AnirudhPudari/migrate-to-compose_flowlayouts
...
[Bug]: Migrate away from accompanist/flowlayout
2 years ago
Milosz Moczkowski
6bf37adde9
Merge pull request #671 from android/kotlin-version-updates
...
Update Kotlin, Compose compiler, serialization versions
2 years ago
James Rose
3e66e3d7e8
Merge pull request #595 from android/jr/track-viewed
...
Add visual indicator of read/unread news resources
2 years ago
Márton Braun
bea2eecd90
Update Kotlin, Compose compiler, serialization versions
...
Change-Id: I2aa0d07769e79e6f85824a391418566aef6b721e
2 years ago
Adetunji Dahunsi
05be2855d8
Wire up backend requested sync
...
Change-Id: I1d4485b589c7e94527a2a02f371cd3f030231622
2 years ago
James Rose
93953c2206
Add missing method doc
2 years ago