Don Turner
2d34cb0d0d
Merge branch 'main' into dt/nav-safe-args
1 year ago
Don Turner
4b3f5370b9
Clean up deep link handling
...
Change-Id: I9d589cfe5c20a6b55708b99f5d79b10271af8ab4
1 year ago
Don Turner
00efda54e8
Merge branch 'main' into dt/nav-safe-args
...
* main: (58 commits)
Instrumented tests for InterestsListDetailScreen (#1518 )
Remove Firebase AD_SERVICE_CONFIG property
updateProdReleaseBadging
Merge Android & JVM plugins into a single `HiltConventionPlugin`
Update dependency guard
🤖 Updates baselines for Dependency Guard
Update to Lifecycle 2.8.3
Add android.adservices.AD_SERVICES_CONFIG to badges
Apply suggestions from code review
Update app/src/main/AndroidManifest.xml
generateModuleGraphs
dependencyGuardBaseline
updateProdReleaseBadging
Fix spotless.
Change set to `=` operator
Cleanup unused reference in `libs.versions.toml`
Regenerate SVG graphs
Update comment wording
Use stdin to avoid repeating the output file name
Replace bash commands with proper svgo cli
...
Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5
1 year ago
Don Turner
e19c31570b
Tidy up top level destination handling
...
Change-Id: I385b6f49ba37801e40bb90254abe96e2350d48e8
1 year ago
Enrico Mazzucchelli
e611320b9c
Fix minor issues
1 year ago
Alex Vanyo
b2084bdd84
Update material3-adaptive to rc01
...
Change-Id: I17ae06587cad7d7b823eb2c0362919510c3ed533
1 year ago
songgyubin
a8a8647c20
Update to Material Adaptive 1.0.0-rc01
1 year ago
dependabot[bot]
b778571ec1
🤖 Updates baselines for Dependency Guard
1 year ago
Alex Vanyo
1591f263a8
Update DeviceConfigurationOverride.WindowInsets to match upstream impl
...
Change-Id: Ibce5b499fc67305e12bb3862fc6aefc3647adb75
2 years ago
Simon Marquis
45b0c2ab54
Remove `TemporaryFolder` JUnit rule in instrumented test
2 years ago
Simon Marquis
dc09a1428c
Add missing dependency in `:app` module
2 years ago
Simon Marquis
dac9a6a0fa
Remove implicit `TemporaryFolder` binding with InMemoryDataStore test module
2 years ago
Don Turner
50b13ecb21
Merge pull request #1539 from android/dt/remove-ad-property
...
Remove Firebase AD_SERVICE_CONFIG property
2 years ago
Jonathan Koren
9e4532f0eb
Instrumented tests for InterestsListDetailScreen ( #1518 )
...
* Instrumented tests for InterestsListDetailScreen
Change-Id: I0325cea93bf1e1dc0b8d1fc56434d5413caf6fea
* Use BackHandler instead of asserting an Espresso exception
Change-Id: I6246fcdd51d09a609733fd83223f6d7b8c0cb6c1
* Workaround to make adaptive info use size override
currentWindowAdaptiveInfo() is not affected by using the ForcedSize
override, so the list detail scaffold directve will be calculated with
non-overridden values. This work around hoists the WindowAdaptiveInfo
so that we can pass in an appropriate value in tests.
Change-Id: Ieef99f6d710ddb70243ac5105aa7805dd638ccf8
* Spotless fixes
Change-Id: I7d8a0b3e2667ced3d73fc4f028d11823cda15455
* Review fixes
Change-Id: Iffd288c9a927f13069580c66a6ee3150abb63682
* Helper function to get topics
Change-Id: If336c4b9dac82382daf96284533a277cc58984fa
2 years ago
Don Turner
7d04af0217
Merge pull request #1062 from SimonMarquis/firebase-ktx
...
Firebase: Migrate to using the Kotlin extensions (KTX) APIs in the main modules
2 years ago
Don Turner
a34fee2fcb
Remove Firebase AD_SERVICE_CONFIG property
...
Change-Id: I084f98af8f7eb739be1053428593a2b880ae33f9
2 years ago
Simon Marquis
2caf7180a8
updateProdReleaseBadging
2 years ago
Simon Marquis
d56e06e676
Merge Android & JVM plugins into a single `HiltConventionPlugin`
2 years ago
Simon Marquis
65848707f7
Merge remote-tracking branch 'origin/main' into firebase-ktx
2 years ago
Don Turner
373dae2387
Merge pull request #1006 from thatfiredev/rpf-update-firebase-ktx
...
upgrade to Firebase BoM 32.5.0 and remove Firebase KTX
2 years ago
Don Turner
3c6366dffd
Update dependency guard
...
Change-Id: I7be80c44205f7e4afcdd9e52eef42b5e9c6155e7
2 years ago
dturner
6f8dc49e44
🤖 Updates baselines for Dependency Guard
2 years ago
Don Turner
fb991394f6
Add android.adservices.AD_SERVICES_CONFIG to badges
...
Change-Id: I2c63da1aa2ef0bfadb7fa88a2502dbc3551e7527
2 years ago
Don Turner
c072de56d6
Apply suggestions from code review
2 years ago
Don Turner
fe9652aaf1
Update app/src/main/AndroidManifest.xml
2 years ago
Don Turner
837dac809c
Merge branch 'main' into rpf-update-firebase-ktx
2 years ago
Simon Marquis
1c5513283a
Merge remote-tracking branch 'origin/main' into fix/1161-2
2 years ago
Simon Marquis
904e703b51
dependencyGuardBaseline
2 years ago
Simon Marquis
ff3f2f89da
updateProdReleaseBadging
2 years ago
Simon Marquis
2a43c3f725
Merge branch 'main' into firebase-ktx
2 years ago
Don Turner
39e7f06d2b
Merge pull request #1452 from android/dependabot/gradle/protobuf-4.26.1
...
Bump protobuf from 4.26.0 to 4.26.1
2 years ago
Don Turner
709732834a
Merge pull request #1479 from android/dependabot/gradle/androidxLifecycle-2.8.1
...
Bump androidxLifecycle from 2.7.0 to 2.8.1
2 years ago
Don Turner
76fe1dc0d5
Merge pull request #1481 from android/dependabot/gradle/androidx.appcompat-appcompat-1.7.0
...
Bump androidx.appcompat:appcompat from 1.6.1 to 1.7.0
2 years ago
Don Turner
b85ecbfd65
Merge pull request #1498 from android/av/device-configuration-override-window-insets
...
Add DeviceConfigurationOverride for insets to allow screenshot testing insets
2 years ago
Zongle Wang
b905d52efb
Remove extra ProGuard rules after OkHttp udpate
...
https://square.github.io/okhttp/changelogs/changelog_4x/#version-4110
2 years ago
Alex Vanyo
ea4ab1895b
Add DeviceConfigurationOverride for insets to allow screenshot testing insets
...
Change-Id: Idc781bf23021c1dba0d992bda0a3233e38e7c436
2 years ago
dturner
b73ee6da13
🤖 Updates baselines for Dependency Guard
2 years ago
Don Turner
a6397b7d82
Merge branch 'main' into dt/nav-safe-args
...
* main:
Kotlin 2.0.0 (#1036 )
Update app/src/main/kotlin/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
🤖 Updates screenshots
🤖 Updates baselines for Dependency Guard
Update material3-adaptive to beta01
🤖 Updates baselines for Dependency Guard
Bump androidxComposeAlpha from 1.7.0-alpha08 to 1.7.0-beta01
🤖 Updates baselines for Dependency Guard
Bump hilt from 2.51 to 2.51.1
Add NavigationSuiteScaffold
Fix state loss with workaround
Change-Id: I14d7294fe93f68b9aca6df9bf7bf87ff95583581
2 years ago
Don Turner
da8f32a2ea
Rename Destinations to Routes
...
Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7
2 years ago
Don Turner
041e46eacf
Merge branch 'main' into dt/nav-safe-args
...
* main:
Remove the printModulePaths task and read modules direct from settings
Update pull_request_template.md
Made pull request instructions clearer
Update gradle wrapper
Upgrade AGP to 8.4.0, Android Build Tools to 31.4.0, and Gradle to 8.7.
Regenerate SVG graphs and cleanup/reformat files
Update build.gradle.kts
Remove duplicated AndroidX Work testing dependency
Bump gradle/wrapper-validation-action from 2 to 3
🤖 Updates baselines for Dependency Guard
Bump com.dropbox.dependency-guard from 0.4.3 to 0.5.0
Bump protobuf from 3.25.2 to 4.26.0
Bump app.cash.turbine:turbine from 1.0.0 to 1.1.0
Bump androidxMacroBenchmark from 1.2.2 to 1.2.3
🤖 Updates baselines for Dependency Guard
Unnecessary safe call on a non-null receiver
Bump androidx.activity:activity-compose from 1.8.0 to 1.8.2
Apply suggestions from code review
Move Android instrumented test `ThemeTest` to unit test
Change-Id: Id3283279ca5a9d90c2bbc4740d6c583ba8dded41
2 years ago
dependabot[bot]
8d515159eb
🤖 Updates baselines for Dependency Guard
2 years ago
dependabot[bot]
4b04ef688d
🤖 Updates baselines for Dependency Guard
2 years ago
Simon Marquis
85129e4660
Kotlin 2.0.0 ( #1036 )
...
* 🚧 Kotlin 2.0.0-Beta4
* Testing useKSP2 useK2Uast
* KSP 2.0.0-Beta4-1.0.19
* Update lint 8.4.0-alpha13
* 2.0.0-Beta5
* Lint 8.5.0-alpha02
* Update libs.versions.toml
* Update libs.versions.toml
* 🤖 Updates baselines for Dependency Guard
* KSP `2.0.0-Beta5-1.0.20`
* 2.0.0-RC1
* lint 8.5.0-alpha06
* Kotlin 2.0.0-RC2
* Lint 8.5.0-alpha07
* Fix missing imports
* Migrate from deprecated `kotlinOptions` to `composeCompiler`
* Kotlin 2.0.0-RC3 and AGP 8.6.0-alpha01
* Kotlin 2.0.0 & KSP 2.0.0-1.0.21
* Add `.kotlin` directory to `.gitignore`
* Migrate from deprecated kotlinOptions to compilerOptions
* Restore main workflow
* Migrate from deprecated kotlinOptions to compilerOptions
* Restore relative directories for Compose compiler metrics & reports
---------
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
2 years ago
Don Turner
8a15a61a50
Merge pull request #1419 from android/av/fix-state-loss-with-workaround
...
Fix state loss with workaround
2 years ago
Don Turner
488b97a071
Update app/src/main/kotlin/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
2 years ago
Don Turner
dfcf4af55a
Merge branch 'main' into av/material-adaptive-beta-01
2 years ago
Don Turner
d2113521a8
Merge pull request #1447 from android/dependabot/gradle/hilt-2.51.1
...
Bump hilt from 2.51 to 2.51.1
2 years ago
alexvanyo
8f2beaf889
🤖 Updates screenshots
2 years ago
alexvanyo
aa31f65e81
🤖 Updates baselines for Dependency Guard
2 years ago
dependabot[bot]
8987ae7eae
🤖 Updates baselines for Dependency Guard
2 years ago
Alex Vanyo
211654ff16
Merge pull request #1373 from android/av/navigation-suite
...
Add NavigationSuiteScaffold
2 years ago
dependabot[bot]
e75590ce21
🤖 Updates baselines for Dependency Guard
2 years ago
dependabot[bot]
a161109168
🤖 Updates baselines for Dependency Guard
2 years ago
Simon Marquis
61143ca98b
Merge remote-tracking branch 'origin/main' into fix/1161-2
2 years ago
Don Turner
be752e779d
Fix tests, fix spotless
...
Change-Id: I55e779abe4ee49dc93916d9e1184ed81e1b2bbd0
2 years ago
Don Turner
aba2b2c154
Remove different deeplink destination, add route for nested nav host
...
Change-Id: Idb9586752d815449243d6d529e9b655c45e395ad
2 years ago
Don Turner
68152e5056
Update to adaptive alpha12, fix merge issues
...
Change-Id: I99703db37712abb46b844beb73bb14ddd5283165
2 years ago
Don Turner
e3d45af760
Merge pull request #1406 from SimonMarquis/patch-1
...
Remove duplicated AndroidX Work testing dependency
2 years ago
Don Turner
25ffcb12c1
Merge pull request #1300 from android/dependabot/gradle/protobuf-4.26.0
...
Bump protobuf from 3.25.2 to 4.26.0
2 years ago
Don Turner
10ff0f3e2b
Merge pull request #1127 from android/dependabot/gradle/androidx.activity-activity-compose-1.8.2
...
Bump androidx.activity:activity-compose from 1.8.0 to 1.8.2
2 years ago
Don Turner
f711e69cd2
Merge branch 'main' into dt/nav-safe-args (AnimatedPane broken)
...
* main:
Save nested nav key in instance state
🤖 Updates baselines for Dependency Guard
Recreate nested nav to work with AnimatedPane
Remove forgotten Trace.endSection()
Offload connectivity monitor to a background thread
Change-Id: I4002a07484a4d633c57406aedabf9f5d813a8592
2 years ago
Don Turner
4a84cf2bf4
Add specific type for deeplinks
...
Change-Id: I63c0abb16cbf540ef72dfb945518a48113bdbf75
2 years ago
Don Turner
173ac6711a
Remove autoVerify from intent filter
...
Change-Id: Ia7460a618b2ddf8a25debce92308573bc18368a8
2 years ago
Don Turner
93a48a221a
Use version catalog reference to serialization plugin
...
Change-Id: Ia197b2403e8250720387123d8c5d5d9ad809a036
2 years ago
Don Turner
f67f4d1a83
Update ForYou destination to match current deeplink pattern
...
Change-Id: Ia5ab36f2d75d8d061e63c0cac5262503bc93a638
2 years ago
Don Turner
7ec21d9d2f
Fix issue where selected topic in list was not showing as selected. Minor tidy ups.
...
Change-Id: Icfa79eac6f7327c365f79fd7d15dfa1f8c77184d
2 years ago
Alex Vanyo
3fb6df7c33
Add NavigationSuiteScaffold
...
Change-Id: I36710d880bff381ed86c61632f2ab91902727775
2 years ago
Alex Vanyo
a324fcc8d3
Fix state loss with workaround
...
Change-Id: I96025bd8b2f4f59019df95d1391b832249e7dc91
2 years ago
Alex Vanyo
c2fc34c761
Save nested nav key in instance state
...
Change-Id: If1155bfbe080eb4df3c59faaec0fb4cd4da3821d
2 years ago
alexvanyo
1f90979509
🤖 Updates baselines for Dependency Guard
2 years ago
Alex Vanyo
1c0508a678
Recreate nested nav to work with AnimatedPane
...
Change-Id: I6b526331b7fc62b968ac39e91753a8a1e5343023
2 years ago
Don Turner
2264451bb8
Use navigation argument topicId as default value to InterestListDetailScreen
...
Change-Id: I659f729191bce00683b1621c360c8f36f00595f9
2 years ago
Don Turner
116e961f1b
Change startDestination from KClass to default instance
...
Change-Id: Ia5bb0abd366653aff5cf5a772ac11a837e96b9b1
2 years ago
dturner
8cc0fc00e6
🤖 Updates screenshots
2 years ago
dturner
0f926ba859
🤖 Updates baselines for Dependency Guard
2 years ago
Don Turner
924391cd22
Fix spotless
...
Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428
2 years ago
Don Turner
2d45b84031
Merge branch 'main' into dt/nav-safe-args
2 years ago
Don Turner
29e08ea1a0
Add deeplink action to enable testing from terminal
...
Change-Id: Ia112f87c7f1bb7fa9ebe08b82d26e00b4ad17d05
2 years ago
Don Turner
9779074997
Remove Interests2PaneViewModel as it was overkill for holding a single string value
...
Change-Id: I4767578028b55c2bc7b1763bdeef87345b9fbf06
2 years ago
Don Turner
89163b5ea1
Migrate remainder of app to type-safe navigation
...
Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b
2 years ago
Don Turner
490997281a
Update to alpha08, use toRoute to obtain destination inside VM
...
Change-Id: I72f617c594b5e0ae272cf94d2d7288446153420a
2 years ago
Don Turner
d96bcf8ffe
Migrate Interests nested NavHost to safe args
...
Change-Id: I4f3c310be693ecbcbc8b99c4e573d7fc6e9a2f74
2 years ago
Don Turner
afad1b9ac7
Merge pull request #1383 from android/av/navigation-2.7.7
...
Update to navigation 2.7.7
2 years ago
Alex Vanyo
068cee0278
Add workaround for state loss bug
...
Change-Id: I7ac4495c8e3ada419358688c61214c33c0d4040e
2 years ago
Simon Marquis
3e1f545869
Update build.gradle.kts
2 years ago
Jose Alcérreca
ead3f49f7b
Fixes flakiness in app's screenshot tests ( #1395 )
...
* Disables WM init in app's screenshot tests
Change-Id: Ib0994e744f49b53f58c0eebd52f80c0eba67bbed
* Spotless
Change-Id: Ic0212889354481433ce45ec4292ae7be9bd24b2e
* [CI] Uploads roborazzi reports if they fail
Change-Id: I5a25a7e156d3fcb72a396d3b503e62068a20b417
* Uses unused test module and enables LocalInspection
Change-Id: Iac36347dc3d702248d7515a74823e0bc0cbf2a2b
* Fixes timezone in snackbar screenshot tests
Change-Id: Ic517e8822218abeaddd3f8d2740b03e651d72d31
* Fixes conflict
Change-Id: Ia42fb78781d2469a608183594fc25c7c69f7e76c
* 🤖 Updates screenshots
2 years ago
Jose Alcérreca
1da560f582
Revert "Configure baseline profiles in the baselineProfile lambda" ( #1398 )
...
This reverts commit 7980c1d0df .
2 years ago
Ben Weiss
7980c1d0df
Configure baseline profiles in the baselineProfile lambda ( #1060 )
...
* Configure baseline profiles in the baselineProfile lambda
* This is the correct and easiest way to set up baseline profiles correctly.
* See b/313428246 for more context.
* Handle empty topics during baseline profile generation
* Revert to API 33 GMD and fail empty screen tests
* Rename withChildren to noChildren for better legibility
* Remove unused log tags
* Update benchmark and metrics versions
* 🤖 Updates baselines for Dependency Guard
---------
Co-authored-by: Tomáš Mlynarič <mlykotom@google.com>
Co-authored-by: Jaehwa Noh <shwoghk14@gmail.com>
2 years ago
Alex Vanyo
91215c5c89
Update to navigation 2.7.7
...
Change-Id: Iaceea1fc216c899f7fac58e7f5eeaea4e1c10dbb
2 years ago
Don Turner
c7d5cb4012
Replace TestHarness with DeviceConfigurationOverride after merging main
...
Change-Id: Ie49b67981929fd3932ce3da68571a6305cf67aef
2 years ago
Don Turner
61cce4bf19
Merge branch 'main' into replace-testharness
2 years ago
Sergey Pinkevich
2ade8c8f1c
Merge branch 'dependabot/gradle/androidx.activity-activity-compose-1.8.2' of https://github.com/android/nowinandroid into dependabot/gradle/androidx.activity-activity-compose-1.8.2
2 years ago
Alex Vanyo
d452f22a68
Update badging
...
Change-Id: If6b1327554bc855baa86fd47519ca56e015b9d14
2 years ago
Alex Vanyo
9b4c22cb2d
Update to material3-adaptive alpha10
...
Change-Id: I810c36323a35c445c22dd3876c52df0360a5cb48
2 years ago
Alex Vanyo
0be0bc191f
Update usage of material3 adaptive to be edge-to-edge
...
Change-Id: I481c79db77bbdd657182f5355200f63e2355f40d
2 years ago
Jose Alcérreca
16f45c0b1a
Adds screenshot tests for snackbar ( #1343 )
...
* Adds screenshot tests for snackbar
Change-Id: I81566e3301fb17e3f31cbc408e6cc3325eab5a12
* Small tweaks, RFR
Change-Id: Ia16db6e6f5bec2714081b5ceaeeba36b2ee26105
* 🤖 Updates screenshots
* Update NiaApp.kt
Adds modifier to NiaApp
2 years ago
Tomáš Mlynarič
8d506bd598
Fix format
...
Change-Id: I54c9a794cbb84ffba4378ccc901ceb603de4642c
2 years ago
Tomáš Mlynarič
400f3b8a65
Fix default value
...
Change-Id: I6b77e1c23ad91c1c97f31a705161d444be7913c0
2 years ago
Tomáš Mlynarič
bd508c477a
Optimized handling of dark/light mode
...
- Activity handles uiMode config change to prevent re-creating the whole activity
- Wrap uiState logic into its classes
- Optimize startup to prevent recomposing twice on startup
- Optimize startup to call enableEdgeToEdge only once or when change occurs
Change-Id: I6f7a48b3b6ce9b55db4ab2ec1770583028e9bc50
2 years ago
Tomáš Mlynarič
d71383c288
Add niaEdgeToEdge trace tag
...
Change-Id: I8012c8b4544abc9488f96f6f01822fb15bb0775a
2 years ago
Don Turner
739dc00987
Fix spotless
...
Change-Id: I98a9b9fa1de5cc0bb3a3caa7d795053fd784b238
2 years ago
Don Turner
fc2146c970
Merge branch 'main' into replace-testharness
2 years ago
Don Turner
655aebccdc
Remove workaround for https://issuetracker.google.com/327149166
...
Change-Id: I335f9f5da1ff3f2574acca8e3fcb27b949a07c7a
2 years ago
Jaehwa Noh
a22b724a66
Change getByName to named
...
- reference by [APIs to avoid](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#apis_to_avoid )
Change-Id: Idf1ce9cf372b8f5da2f0da95fcf53454ffb3388f
2 years ago
Jose Alcérreca
78e3725f9f
Sets up jacoco coverage with a combined report and a GHA ( #1303 )
...
* Uses jacoco coverage reporting in AGP
2 years ago
Simon Marquis
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
2 years ago
Don Turner
bd89507f10
Merge pull request #1306 from yongsuk44/feat/weak-warning
...
Cleaned up unnecessary '@opt-in' annotations and removed empty constructors
2 years ago
yongsuk44
e2a4706470
Remove unnecessary opt-in annotations
2 years ago
dependabot[bot]
c4b669a138
🤖 Updates baselines for Dependency Guard
2 years ago
dependabot[bot]
7d2026f180
🤖 Updates baselines for Dependency Guard
2 years ago
Jonathan Koren
dac1a9e446
Topic detail pane placeholder ( #1280 )
...
* Topic detail pane placeholder
Change-Id: I92b84493a5406240285c0759b30aa10d29871f09
* Add modifier parameter
Change-Id: Ie363be83b44f26291030c04c1513cecb851a6899
2 years ago
Don Turner
70dcd5119d
Make path to module graph image dynamic. Fixes #1286
...
Change-Id: I595a841ef7b06cccc959ca96d18824f4fad4c261
2 years ago
Don Turner
3e4aad3210
Merge pull request #1257 from android/dt/add-module-graphs
...
Update module dependency graphs and add script to create them
2 years ago
Don Turner
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
2 years ago
SergeyPinkevich
06f08a58dd
🤖 Updates baselines for Dependency Guard
2 years ago
alexvanyo
a6f223301e
🤖 Updates baselines for Dependency Guard
2 years ago
Alex Vanyo
cc02c30b8e
Update material3-adaptive to 1.0.0-alpha08
...
Change-Id: Ic218c6b061b5cea4e56b544073541421862bc1d0
2 years ago
Don Turner
0c9f0dd48c
Merge pull request #1217 from android/dependabot/gradle/org.jetbrains.kotlinx-kotlinx-serialization-json-1.6.3
...
Bump org.jetbrains.kotlinx:kotlinx-serialization-json from 1.6.0 to 1.6.3
2 years ago
Don Turner
e9565a567e
Merge pull request #1258 from Jaehwa-Noh/rename-test-function
...
Rename test function, and delete explicit type argument
2 years ago
Don Turner
74d1d91c28
Merge pull request #1263 from android/dependabot/gradle/kotlinxCoroutines-1.8.0
...
Bump kotlinxCoroutines from 1.7.3 to 1.8.0
2 years ago
Don Turner
91af060e77
Merge pull request #1264 from android/dependabot/gradle/androidx.hilt-hilt-navigation-compose-1.2.0
...
Bump androidx.hilt:hilt-navigation-compose from 1.0.0 to 1.2.0
2 years ago
Don Turner
1fde4f5753
Merge pull request #1266 from android/dependabot/gradle/androidx.browser-browser-1.8.0
...
Bump androidx.browser:browser from 1.6.0 to 1.8.0
2 years ago
mlykotom
a7a7736426
🤖 Updates baselines for Dependency Guard
2 years ago
dependabot[bot]
5448786c4d
🤖 Updates baselines for Dependency Guard
2 years ago
dependabot[bot]
72f968ff2c
🤖 Updates baselines for Dependency Guard
2 years ago
dependabot[bot]
6e5548a837
🤖 Updates baselines for Dependency Guard
2 years ago
Jaehwa Noh
d67b1a2504
Merge branch 'android:main' into rename-test-function
2 years ago
Jaehwa Noh
e017b84a12
Remove explicit type argument.
...
Change-Id: Id02756d780309af6638698de856b563d9e775cc3
2 years ago
Jaehwa Noh
8cfd42453c
Rename test function name
...
- Given-when-then format.
Change-Id: I3305c5a7cc5a0f41be31292534a086034f642404
2 years ago
Jonathan Koren
19f6f9e09a
2 pane support in Interests screen ( #1234 )
...
* Add dependency on material3 adaptive
Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6
* Add InterestsListDetailScreen composable
Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971
* Store selectedTopicId in InterestsViewModel
Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce
* Pass detail pane composable down
Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293
* Navigate to initial topic if provided
Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b
* Lift LDPS up to app module
Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85
* Fix some navigation behavior
Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b
* Navigate to initial topic if provided
Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed
* Remove dependency in interests feature module
Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f
* Hide back arrow when the topics list is visible
Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8
* Update interests tests
Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd
* Highlight selected topic when displaying 2 panes
Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415
* update dependency baselines
Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00
* run spotless apply
Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8
* Convert isListPaneHidden to isListPaneVisible
Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657
* Set semantics for selected state
Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca
* Use scaffold roles when determining visibility
Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648
* Update multipleBackStackInterests test
Change-Id: I1e372f7989817151a6765205291b13b561187fa8
2 years ago
Don Turner
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
2 years ago
Don Turner
2d610b0775
Merge branch 'main' into replace-testharness
...
* main: (37 commits)
Disable animations of instrumented tests (#1167 )
Bump gradle/wrapper-validation-action from 1 to 2
Remove unused release variable. Fixes #1231
Apply Composable Parameter Ordering Guidelines
Remove kotlinx-coroutines-guava dependency from :sync:work
Add explicit guava-android dependency for :sync:work
Extract ScreenshotHelper to separate testing module
Update AGP to 8.3.0
Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert.
🤖 Updates baselines for Dependency Guard
Bump the kotlin-ksp-compose group with 6 updates
🤖 Updates baselines for Dependency Guard
Bump hilt from 2.50 to 2.51
Bump com.google.truth:truth from 1.1.5 to 1.4.2
Move java to kotlin folder.
Remove disk usage testing
Figuring out what is using 66Gb in the runner
Dpm
Improve converting to kotlin timezone
Use trySend multiple times
...
Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a
2 years ago
Don Turner
7737368c0e
Update app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
2 years ago
Don Turner
14b60b3a59
Merge branch 'main' into dependabot/gradle/org.jetbrains.kotlinx-kotlinx-serialization-json-1.6.3
2 years ago
Don Turner
8a3c34994d
Merge pull request #1239 from Jaehwa-Noh/java-to-kotlin
...
Move java to kotlin folder.
2 years ago
Don Turner
747c9275bc
Merge pull request #1249 from android/dt/fix-1231
...
Remove unused release variable. Fixes #1231
2 years ago
Don Turner
77cbdb62a4
Remove unused release variable. Fixes #1231
...
Change-Id: I8c03d3d2e1aee85a22d1a03b97e3bec4069e0fcb
2 years ago
Alex Vanyo
e3c7018124
Extract ScreenshotHelper to separate testing module
...
Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af
2 years ago
Don Turner
d768c796d4
Merge pull request #1244 from android/dependabot/gradle/hilt-2.51
...
Bump hilt from 2.50 to 2.51
2 years ago
Jaehwa Noh
1ca0085423
Merge branch 'android:main' into java-to-kotlin
2 years ago
Tomáš Mlynarič
f31fdb3ec2
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Id49a580012629163ec4a3663d95ab71b98910220
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
# gradle/libs.versions.toml
2 years ago
dependabot[bot]
b2b9f12915
🤖 Updates baselines for Dependency Guard
2 years ago
Jaehwa Noh
9b488bf70a
Move java to kotlin folder.
...
Change-Id: Iaf4723dea6169fbf3f9a8d3bf8779179ac56ab86
2 years ago
dturner
43b2240bdd
🤖 Updates screenshots
2 years ago
Don Turner
73d0b70f21
Workaround for new ForcedSize behaviour, bump ui-test version
...
Change-Id: Ibf93c1b65250e6527e34bc90602c1b1001b2df46
2 years ago
Don Turner
fa811ab85f
Bump to ui-test:1.7.0-alpha03, add parameter name
...
Change-Id: Ib1bbe4ad0d823c632d387587aa55c5eeb39e4b8d
2 years ago
dturner
50d5583fe1
🤖 Updates screenshots
2 years ago
Don Turner
d6357be8c4
Replace Accompanist TestHarness with DeviceConfigurationOverride
...
Change-Id: I6742d5e221f86a019f44d3e623609bf76d2a3a2a
2 years ago
dturner
27fd4e544a
🤖 Updates screenshots
2 years ago
dturner
02d4fea615
🤖 Updates screenshots
2 years ago
Don Turner
a507ff6d8e
Wrap NiaApp with NiaTheme for app screenshot tests
...
Change-Id: I8e298da139b19721b90ae778e7ab184f600d0bd7
2 years ago
Tomáš Mlynarič
75a3295381
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt
2 years ago
dturner
6b2b01ed82
🤖 Updates screenshots
2 years ago
dturner
076a2af757
🤖 Updates baselines for Dependency Guard
2 years ago
dturner
08d8f1393a
🤖 Updates baselines for Dependency Guard
2 years ago
dependabot[bot]
0c0adddf42
🤖 Updates baselines for Dependency Guard
2 years ago
dependabot[bot]
6add4d68e3
Bump protobuf from 3.24.4 to 3.25.2 ( #1214 )
...
* Bump protobuf from 3.24.4 to 3.25.2
Bumps `protobuf` from 3.24.4 to 3.25.2.
Updates `com.google.protobuf:protobuf-kotlin-lite` from 3.24.4 to 3.25.2
Updates `com.google.protobuf:protoc` from 3.24.4 to 3.25.2
- [Release notes](https://github.com/protocolbuffers/protobuf/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl )
- [Commits](https://github.com/protocolbuffers/protobuf/compare/v3.24.4...v3.25.2 )
---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-kotlin-lite
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.google.protobuf:protoc
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* 🤖 Updates baselines for Dependency Guard
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
2 years ago
Ben Weiss
f64f1c0aa2
Remove legacy benchmark build type ( #1207 )
...
* Remove legacy benchmark build type
Now that we have the baseline profile gradle plugin,
there is no need for a benchmark build type.
The plugin does the setup and configuration and runs against the
correct app flavor.
* Remove explicit benchmark build type from benchmark module
* Remove stale build task exclusions
* Fix tracing import location
FYI @mlykotom
2 years ago
Tomáš Mlynarič
58483b6166
Revert fast initialization of Coil
...
As discussed in https://github.com/coil-kt/coil/issues/2097 the problem is caused by regitering system services, which will be fixed in 2.6.0
Change-Id: I9085309780508137f10b25ff82deed3c62e5d159
2 years ago
Tomáš Mlynarič
f3e89bad4a
Add braces
...
Change-Id: I859babab7278137a4a2e49e5a085c65632888dd0
2 years ago
Tomáš Mlynarič
d1211f15e7
Inline initialization
...
Change-Id: I0a77eb6457cac27c1a4d604c8efdcbbdce95bc48
2 years ago
Tomáš Mlynarič
e853748cf7
Don't use runBlocking if async init completed
...
Change-Id: I641187ce277f434c6fca49a11b3cfccd50ecf5da
2 years ago
Tomáš Mlynarič
7c33946ce1
Launch loader directly without additional coroutine scope
...
Change-Id: Icbbdbcbcac1a6275857ebe998509f1e09109db7a
2 years ago
Tomáš Mlynarič
8e3903e90c
Fix comment
...
Co-authored-by: Yuri Schimke <yuri@schimke.ee>
2 years ago
Tomáš Mlynarič
5f0612102d
Improve lazy loading for Coil + OkHttp
...
This way, we can load Coil's backend on a background thread and not block the MainThread with it.
Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames.
Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62
2 years ago
Tomáš Mlynarič
12a3a6edde
Use trySend multiple times
...
Change-Id: Ie00c4180d07fc4bb9d457647f3b7ddadd5a3c032
2 years ago
Tomáš Mlynarič
08bfc54832
Update dependency guard baseline
...
Change-Id: I2557753f1eb4c6845aca6473a6aba5b7e758ebbf
2 years ago
Tomáš Mlynarič
f8e797fd26
Rename currentTimezone variable
...
Change-Id: I92630f6851b0253294a8d3ec2e5b3cbe7db74b4d
2 years ago
Tomáš Mlynarič
98e9e80639
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Ie83fb57676934ca3bdda59a986eb1a01a7c97424
2 years ago
Tomáš Mlynarič
ea1573fcc1
Use kotlinx.datetime.Timezone instead of java ZoneId
...
Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628
2 years ago
Jonathan Koren
c1d6c88bb0
Run dependencyGuard task during CI ( #1064 )
...
* Run dependencyGuard task during CI
Run the `dependencyGuard` task during CI, which will fail if there are
detected changes.
Change-Id: If5f2b18a4c765bd38a3353df2adaaa91cf1739c3
* Add actions to update dependency guard baselines
* Update baselines
* Better glob for update baselines action
2 years ago
Tomáš Mlynarič
44ae059a2b
Rename LocalTimeZone -> LocalZoneId + collects with lifecycle
...
Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3
2 years ago
Tomáš Mlynarič
cb00d2c8cb
Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers
...
This way, we can save ~1ms per composed item on screen.
Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d
2 years ago
Tomáš Mlynarič
395b9853df
Add Composition Tracing
...
Change-Id: I3ad60930de2fab71a700a0c2df3f0a1f566cafd8
2 years ago
Don Turner
f5b3ae56dc
Merge pull request #951 from SimonMarquis/issue-945
...
Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`
2 years ago
Don Turner
691bf2aad6
Merge pull request #785 from SimonMarquis/optimize-avd
...
Optimize AVD to fix long vector paths Lint warning
2 years ago
Simon Marquis
48fde2c3bf
Fix badging after merge
2 years ago
Simon Marquis
d9d9153eda
Merge branch 'main' into firebase-ktx
2 years ago
SimonMarquis
afdfd8acc5
🤖 Updates screenshots
2 years ago
Simon Marquis
377d3bef0c
Optimize AVD to fix long vector paths Lint warning
...
... with SVGOM, but you'll have to check on Android Studio the AVD diff.
https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html
2 years ago
Don Turner
707117a4f2
Merge branch 'main' into kotlinify
2 years ago
Don Turner
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
2 years ago
Don Turner
046831df36
Update dependency guard classpaths
...
Change-Id: I5f729bce92ec1cc9f71e34e42cbe38765966fc31
2 years ago
Simon Marquis
0699efc592
Merge branch 'main' into issue-945
2 years ago
Simon Marquis
be9dc533e3
Replace `Enum.values()` with `Enum.entries`
...
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9
2 years ago
Don Turner
a5c030f740
Merge pull request #956 from KDW03/add_saved_test
...
Add Test for Saved Top Level Destination
2 years ago
Don Turner
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
2 years ago
Don Turner
9d41ffa318
Merge branch 'main' into kotlinify
2 years ago
Don Turner
ad15f0137e
Merge pull request #1094 from lihenggui/main
...
Upgrade Spotless and Ktlint and remove code convention violations
2 years ago
Don Turner
8d5ef578c6
Merge pull request #1103 from android/add_icon_comment
...
Add comment explaining why the launcher icon colors differ per build
2 years ago
Simon Marquis
b6d82e24df
Merge branch 'main' into kotlinify
2 years ago
Don Turner
b801a7deea
Moving comments to _after_ first XML element
...
Change-Id: Id4271a67ffcfbd712a2dd1f363970fcd31ee5ac0
2 years ago
lihenggui
2a2d8ed88d
Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE
2 years ago
Don Turner
d018e57f52
Fix spotless
...
Change-Id: I5dea4fec5b391e8cb7794af13e99978fcb622fbb
2 years ago
Don Turner
e6b5560f07
Revert "Move app screenshot tests to match dependencies declaration"
2 years ago
Don Turner
28bb3f1b2f
Add comment explaining why the launcher icon colors differ per build variant
...
Change-Id: I30126402370162ccbe53e177652583e4472f2030
2 years ago
Simon Marquis
83764082ff
Move app screenshot tests to match dependencies declaration
...
Fixes #990
2 years ago
lihenggui
32e1ec0447
Remove violations: property-naming
2 years ago
lihenggui
fb5bd225be
Spotless
2 years ago
Simon Marquis
2b739c0ffe
Fix badging, which is not "stable" when it comes to ordering
2 years ago