Angie Sasmita
dbbe8ffecb
Small fix for naming and boolean logic
...
Change-Id: I3dd291bdd581494574c557329bf23f5ed07af0bb
2 years ago
Angie Sasmita
19efc1b5e8
Fix Spotless issue manually
...
Change-Id: Icd560e6ceaaeee0a6f502fe49b3403ab07f926ef
2 years ago
Angie Sasmita
6046f6e943
Add dynamic color option in settings for API >=32
...
Change-Id: Ib42c1cbd0208e98ef7610a1c8aca5d721aa464e6
2 years ago
Takeshi Hagikura
4633609930
Introduce GMD + ATD ( #479 )
...
Introduce Gradle Managed Device definitions to modules that have instrumented tests.
At the moment, defining it as a convention plugin isn't possible due to the bug. That bug is now fixed and will be included in Android Studio Flamingo.
Once Flamingo becomes stable, convert the GMD definitions as a convention plugin (#523 )
Change-Id: I0866369e3d0bbe148ca5ec1f92bad59239a347b8
2 years ago
Don Turner
bad3ea60f5
Refactor Topics news feed, tidy a few other bits up
...
Change-Id: Id4c9d1bce484137b363ec4cd21a45ca9863a2e7f
2 years ago
magicalmeghan
45e3cfd989
fixed string issue for testTopicsChipColorBackground_matchesFollowedState test
2 years ago
magicalmeghan
de6a4ec6c7
Merge remote-tracking branch 'github/mm/chipcolor' into mm/chipcolor
2 years ago
magicalmeghan
5137cd7777
removed hardcoded strings
2 years ago
Don Turner
cafac8eb09
fix spotless, tidy test data
...
Change-Id: I4ceb7b85e5a8dd4d4f20088b2594c6b4030299bb
2 years ago
magicalmeghan
66046a86b0
Updated NewsResourceCardTest
2 years ago
Don Turner
6207fe3bcf
mapToUserNewsResources converts List<NewsResource> to List<UserNewsResource>
...
Change-Id: I072effef0f66caf51227ba8c64f0857fb837308d
2 years ago
Don Turner
24df51349d
Move mapping logic into secondary constructor
...
Change-Id: I032326f502d27f2d3bd9fb8273ae44df878d172c
2 years ago
Don Turner
355b0540aa
Move construction of UserNewsResource into separate function
...
Change-Id: I7c1f6427cd7d95c2016349fec301b88455b33cf2
2 years ago
Don Turner
99227b06b5
Spotless
2 years ago
Don Turner
32bc5c1590
Fix merge conflicts
2 years ago
magicalmeghan
ffb5aeba86
Added third draft of tests
2 years ago
magicalmeghan
d9e18607be
Added second draft of tests
2 years ago
magicalmeghan
8089866079
Added second draft of tests
2 years ago
Alex Vanyo
ba11e6bf38
Merge pull request #491 from android/av/fix-background-composable
...
Updated background composable for gradient
2 years ago
Chris Sinco
2f454de21c
Spacing polish based on design spec
2 years ago
Don Turner
47bc4a7b88
Merge pull request #504 from android/dt/fix-build-warnings
...
Fix build warnings
2 years ago
Don Turner
0917cdebec
Refactor NiaGradientBackground to accept GradientColors
...
Change-Id: I55840b22e123490097710570bf11554554df90f9
2 years ago
Don Turner
1acee42167
Merge pull request #493 from andhiratobing/main
...
Set visibility modifier of composable preview to private
2 years ago
Don Turner
cf053ade5a
Fix build warnings
2 years ago
magicalmeghan
9a900f9900
Added first draft of tests
2 years ago
magicalmeghan
a8f55d9d38
Renamed SaveableNewsResource to UserNewsResource
2 years ago
Don Turner
5638e253ae
Fix unit and UI tests. Apply spotless.
...
Change-Id: Iab75852a27a44309d349f84e65226911ab59fcd5
2 years ago
magicalmeghan
ec4bceead3
Renamed SaveableNewsResource to UserNewsResource
2 years ago
magicalmeghan
6941e2082b
Renamed SaveableNewsResource to UserNewsResource
2 years ago
Nick Rout
a1d0dfcaa5
Merge pull request #492 from ricknout/main
...
Fix issues with NiaTheme gradients and backgrounds
2 years ago
ratobing
1e493c0bbc
Set visibility modifier of composable preview to private
2 years ago
Nick Rout
c742aa3eca
Fix issues with NiaTheme gradients and backgrounds
2 years ago
Nick Rout
7903f87dcc
Merge pull request #485 from ricknout/main
...
Update :core-designsystem module based on Figma file
2 years ago
Nick Rout
9fd47261c9
Address design system PR feedback
2 years ago
Nick Rout
cac02c418d
Fix ThemeTest
2 years ago
Nick Rout
61bbd406c5
Fix ThemeTest
2 years ago
Nick Rout
a34bc2d7c2
Fix spotless issues
2 years ago
Nick Rout
be4ad40441
Fix spotless issues
2 years ago
Nick Rout
c12fe1fbe5
Update :core-designsystem module based on Figma file
2 years ago
Caren
65fdb0c09c
Merge pull request #476 from android/caren/resource_type
...
Display resource type for each news resource
2 years ago
Caren
4ff9c039b3
Rename NewsResourceDataAndType -> NewsResourceMetaData
...
Change-Id: Ide67bb9adf740d9cf0bba58f369688f91e0eb85f
2 years ago
Caren
b05302fddd
Fix tests
...
Change-Id: Ie1e2408ea523e6ddc0941fe261fce7f2502e3416
2 years ago
Caren
7d42831ee9
Merge pull request #465 from android/caren/custom_chrome_tab
...
Use Chrome Custom tab for opening articles
2 years ago
Caren
352bac94fb
run spotless
...
Change-Id: Ieb751d960ade646dfe35ed7d2ca039e3b8f38ba7
2 years ago
Caren
3712ba8c2f
Add test and add string template in strings.xml for RTL purposes
...
Change-Id: I1bce9ac7534f376a9626cac2c50e1bcc7620cf61
2 years ago
Caren
f563862df3
Rename NewsResourceDateAndNewsType -> NewsResourceDateAndType
...
Change-Id: I535c62f3317d6ada882a08235c0c4465d9963201
2 years ago
Caren
f150516b3c
Display resource type for each news resource
...
Change-Id: Ib33ffd0e9b87ec91d2ee4316a4e3dbf70bb5cfc9
2 years ago
mlykotom
90674c0c07
Add niaTopAppBar testTag
...
Change-Id: I02a207675e106137fe005140965c96f1b50f98ce
2 years ago
mlykotom
0018144827
LoadingWheel testTag for every loading wheel
...
Change-Id: I7728e1717925abdfb607e93f3d48226910d42c0d
2 years ago
Caren
1280565466
Add ColorInt annotation
...
Change-Id: If6ea8e4c3a09c6de932797ddcb64bbfff1e52ede
2 years ago
Jolanda Verhoef
4ba63c0de8
Remove author concept from app
...
Change-Id: Icd03c0288ba5f3f23dbcbdbefbbe802db2815793
2 years ago
Caren
94e2bb0ec2
Run spotless
...
Change-Id: I1deee3c9b38d352afca0f646366598e32710ffca
2 years ago
Caren
45f8e069c5
Implement custom chrome tabs in NewsResourceCardList as well
...
Change-Id: Ie5851666117a7c756b3d9ad02d6e17be0d3ba904
2 years ago
Caren
55c3ebd085
Use Chrome Custom tab for opening articles
...
Change-Id: I0024038f918a18d3c3e803587a7e1c159bfb9169
2 years ago
Márton Braun
9c22a7a4e7
Remove `Stream` suffixes
...
Change-Id: I45decae965d7e35289d3fa31fc58b8c463fbead1
2 years ago
Marek Rzeźniczek
7e0a154489
Migrate core:domain namespace to build.gradle file
2 years ago
Milosz Moczkowski
a70761f24b
Merge pull request #441 from android/refactor/remote_fake_data_source
...
Remove FakeDataSource
2 years ago
Mohsen Rzna
c19b8b9319
New empty bookmarks handling ( #443 )
...
* Added the png file for error state
This should be removed later - couldn't convert the design to vector from svg - there is a problem with the `<mask` tag.
* Added two new strings based on the Figma file
* Redesign and reimplementation for the empty BookmarksScreen along with two clarifying comments.
* Removed the png file and replaced it with vector
* Code refactor after code reviewing
Made contentDescription null, removed extra spaces and renaming for the Composable function as suggested.
* Moved the modifier after Text
* Added a space after the curly bracket to pass the Spotless check
* Spotless apply
* Simplify logic in Bookmarks screen
* Change order of composables in BookmarksScreen and add previews
* Refactor after code review
Removed the space before `if`, and changed the padding from 5 to 8dp.
Co-authored-by: Jolanda Verhoef <JolandaVerhoef@users.noreply.github.com>
2 years ago
Simon Marquis
a3c3b1af19
Configure `isReturnDefaultValues` for `:core:datastore`
2 years ago
Simon Marquis
23f414a05b
Configure `isReturnDefaultValues` to fix #448
2 years ago
Don Turner
9fa3dadcfd
Fix comment
2 years ago
Adetunji Dahunsi
841f58ef26
Check active network for connectivity state each time network changes
...
Change-Id: I5d3eb0251f62a57a5767911167067d35aeec8e6a
2 years ago
Miłosz Moczkowski
6174a3a3ef
Spotless apply
...
Change-Id: Iaf82b44487f001417265ad97acfe6eea8dd6a78f
2 years ago
Miłosz Moczkowski
67fea35e6d
Replace networkJson and FakeAssetManager with FakeNiaDataSource in all repositories
...
Change-Id: Ibeb9fd09bd862000794f41edcddd2cea434a9bb1
2 years ago
Miłosz Moczkowski
e653b738d2
Remove FakeDataSource
...
Change-Id: I5e1486feeade67f0f7276458187694e684310ad3
2 years ago
Milosz Moczkowski
c62673d035
Merge pull request #179 from Abhimanyu14/niaicons
...
Icons alignment to use NiaIcons
2 years ago
Simon Marquis
ee8eac34b8
Refactor `:core:network` DI
...
- Delete unused `NetworkModule` from benchmark sourceSet (contains unknowns references)
- Extract common bindings into a single `NetworkModule`
- Expose "flavored" bindings through `FlavoredNetworkModule`s
2 years ago
Simon Marquis
7e0bfb43fa
Add missing binding in NetworkModule
2 years ago
Simon Marquis
b5d342468e
Merge remote-tracking branch 'fork/main' into patch/assets-as-json-files
2 years ago
Milosz Moczkowski
cec83dc316
Merge pull request #431 from SaeedNoshadi89/show-all-news-authors
...
Show all authors in the news card
2 years ago
Saeed Noshadi
adeb06c5ac
replace StringBuilder with joinToString
2 years ago
Saeed Noshadi
dcce95ada6
remove unused import
2 years ago
Saeed Noshadi
e44811f265
show all authors in the news card
2 years ago
Abhimanyu14
d69a37af7c
Icons alignment to use NiaIcons
2 years ago
Simon Marquis
0e6f16e0a8
Fix spotless issues
2 years ago
Simon Marquis
321b1602e1
Remove duplicated link
2 years ago
Simon Marquis
e128f9b877
Fix lint crash
2 years ago
Simon Marquis
67dea1c136
Fix spotless issues
2 years ago
Simon Marquis
fbaa8eaff5
Migrate hard-coded JSON data into JSON assets files
...
JSON minification is no longer necessary since assets files are already gzipped during APK/AAB packaging.
Fixes #391
2 years ago
Simon Marquis
90dc300783
Migrate from JUnit assertions to Kotlin's test framework
...
Fixes #419
2 years ago
Don Turner
317c72af1a
Merge branch 'main' into fix/typos
2 years ago
Don Turner
86ef9ff594
Make updateShouldHideOnboardingIfNecessary private
...
Change-Id: I7917b025d258a07604e98950396ec3e119e2d9a7
2 years ago
Simon Marquis
a680b14763
Fix typos
2 years ago
Don Turner
5b8c284c74
Rename hasDismissedOnboarding to shouldHideOnboarding
...
Change-Id: I8a6b35f7216f9944652d8da346e7458614311e08
2 years ago
Don Turner
6654403498
Refactor onboarding to save interests to user data
...
Change-Id: I97772a8b65e1e94a95187ebb7c514104af2d3a08
2 years ago
Don Turner
a9aa3eafab
Add data from the last 10 episodes
2 years ago
Milosz Moczkowski
398c399c1c
Merge pull request #297 from android/av/remove-dolphin-preview-todos
...
Remove Preview TODOs for Dolphin
2 years ago
Don Turner
7a223f5d8e
Merge pull request #356 from android/jv/compose-bom
...
Update to new Compose release
2 years ago
Jolanda Verhoef
e7b2ed623e
Update to new Compose release
2 years ago
Don Turner
dbff140b64
Fix minor issues
2 years ago
Don Turner
76daa393b1
Address review feedback from Manu
2 years ago
Don Turner
cf4dd1fbff
Added null branches for reading user data from datastore
2 years ago
Don Turner
8c30ab9f80
Add settings module, refactor top bar
2 years ago
Don Turner
add486a0ab
Fix spotless issues
2 years ago
Alex Vanyo
7e3faad699
Add data logic for theme switcher
...
Change-Id: Ifffadb897de4f6e08f7115103f99c156a7098b70
2 years ago
Manuel Vivo
a0b22d8ed2
Updates Navigation approach with new guidance ( #347 )
2 years ago
Automerger
9435c1cd79
Merge branch 'github/main'
2 years ago
Ben Weiss
7e6cb46436
Merge pull request #328 from android/bw/moreJankstats
...
Add more jank tracking
2 years ago
Ben Weiss
ee2e3db928
Add more jank tracking
2 years ago
Don Turner
7ca17f68ed
Merge branch 'main' into av/remove-dolphin-preview-todos
2 years ago
Automerger
d0ba51efec
Merge branch 'github/main'
2 years ago
Don Turner
f3debd0af1
Merge "Add domain layer. See go/nia-domain-layer for details." into main
2 years ago
Don Turner
4a4de7d6a4
Add domain layer. See go/nia-domain-layer for details.
...
Change-Id: I3f4684005e81fb9c4163bf59c7026dcff6e88dc4
2 years ago
Don Turner
40c0cb2a03
Merge pull request #332 from android/kotlin-1720
...
Update Kotlin to 1.7.20
2 years ago
Wojtek Kaliciński
dcc23829d4
Migrate packages to namespaces in build files
...
Change-Id: I21e021caa0ea72a7097dfd9af04a3c07a0cc9aa5
2 years ago
Márton Braun
02c052e7f4
Update Kotlin to 1.7.20
...
Change-Id: Ib3ce03b0a1d78e90424f8431f039511c04446a62
2 years ago
Adetunji Dahunsi
8dbd53c898
Merge pull request #311 from yveskalume/main
...
Use @Upsert from Room instead of a custom helper
2 years ago
YvesKalume
b05ea4724c
fix failling tests
...
Change-Id: I88b6d80dfb473010f8742890d9f6b17ed153ecc5
2 years ago
Don Turner
6351a89545
Merge pull request #310 from android/documentation/dep_graphs
...
Add dependency graphs to every module
2 years ago
YvesKalume
4006d8d40a
update : remove unused upsert method.
...
Change-Id: I737c7c0078512594a719fe3966cdd99ead39331f
2 years ago
Adetunji Dahunsi
9371d0d4b8
Merge pull request #304 from android/tj/sync-ui
...
Offline-first UX improvements
2 years ago
YvesKalume
d094e96a72
update : Use @Upsert from Room instead of a custom helper
...
Change-Id: I21194fda29976e069d5cfc1e083cf48d3dd149fe
2 years ago
Adetunji Dahunsi
c4debb74e7
Give feedback when syncing on ForYouScreen
...
Change-Id: I10a646e8a17f81d96351e69d36f0cb6ccf28e05c
2 years ago
Milosz Moczkowski
06e60063b5
Add dependency graphs to every module
...
Change-Id: I629fef818f7521c13bb3069a3ff9ed9bc42e57f3
2 years ago
Márton Braun
f68a112cfe
Merge pull request #307 from android/update-kotlinx-serialization-optin
...
Opt in to experimental kotlinx.serialization API locally
2 years ago
Márton Braun
5fd5d17caf
Opt in to experimental kotlinx.serialization API locally
...
Change-Id: Ibc88151f5a8b7a3a82e2c0043839c1cb9e016bcf
2 years ago
Alex Vanyo
738210166a
Refine backgrounds and navigation colors
...
Change-Id: I9fd863cc608f21078ab78c39c2c3d227aedbac7c
2 years ago
Alex Vanyo
8c11769622
Update to material3 1.0.0-beta03 wih built-in insets support
...
Change-Id: I4d07f89d4faa6e3417468ad78acf3fbb161f0797
2 years ago
Milosz Moczkowski
f914d6a412
Merge pull request #299 from android/refactor/remove_episodes
...
Remove episodes related code
2 years ago
Automerger
3083c5e2ce
Merge branch 'github/main'
2 years ago
Caren
d89812ee90
Merge pull request #288 from android/caren/remove_search
...
Remove Search from top app bar
2 years ago
Automerger
2531f1be9f
Merge branch 'github/main'
2 years ago
Caren
f16e9d011e
Merge pull request #272 from android/caren/fix_toggle_buttons
...
Fix toggle buttons interaction when using TalkBack
2 years ago
Milosz Moczkowski
5de3f6156b
Spotless improvements
2 years ago
Milosz Moczkowski
303d08dd28
Spotless improvements
2 years ago
Milosz Moczkowski
cbdf6a2d3c
Remove episodes related code
2 years ago
Automerger
6765d79065
Merge branch 'github/main'
2 years ago
Alex Vanyo
bfedf75665
Remove Preview TODOs for Dolphin
...
Change-Id: I35219c7dd6a902c43cd310dcaf8d0e2c2dbdec45
2 years ago
Don Turner
6825138452
Merge pull request #294 from dturner/proto-list-to-map
...
Change user data fields to use maps instead of lists.
2 years ago
Don Turner
c4c01cf99b
Change user data fields to use maps instead of lists.
2 years ago
Takeshi Hagikura
9ae03c3590
Fix the lint warnings
2 years ago
Takeshi Hagikura
74737cad49
Introduce Multipreview annotation to simplify the preview configurations
...
- Bump the AGP version to 7.3.0
- Introduce Multipreview annotation class that represents device
previews and theme previews
Fixes #282
2 years ago
Caren Chang
f76984539b
Fix toggle buttons interaction when using TalkBack
2 years ago
Caren Chang
b74767921c
Remove Search from top app bar
2 years ago
Wojtek Kaliciński
4683918cc7
Move spotless to init script
...
Also adds automatic git hooks installation
Change-Id: I18debbee43af27db7b95a4202f824fa87e186713
2 years ago
Wojtek Kaliciński
d0cff2b11c
Build cleanup
...
* Move Hilt setup to convention plugin
* Disable Hilt on modules where it's not needed
* Enable non-transitive R classes
* Fix `configuration` blocks called in wrong scope
* Move imperative Flavors code from build.gradle
* Disable unnecessary build features globally
* Disable configure-on-demand as it's not encouraged
* Don't use internal AGP packages in plugins
Change-Id: I1bee3e3fd0103054637b979a350f9fd2312ae8ba
2 years ago
madroid
3bd81154b5
Move 'core-' module to core subfolder
2 years ago