ec53d03854
Merge pull request #722 from android/tj/scrollbars
...
Add scrollbars to app
11 months ago
03610d229a
Update feedItemsSize calculation
...
Change-Id: I2bf6a2fa0e210cef1318707d948a49d2ef010452
11 months ago
e8449112b4
Replace StringDecoder injection with simpler API
...
The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String.
For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`).
Unit tests would fail because Uri is not mocked (since we are not using Robolectric).
Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc.
FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded".
The solution to this problem was to simply use regular Java APIs:
- `URLDecoder.decode(urlEncodedTopicId, "UTF-8")`
- `URLEncoder.encode(topicId, "UTF-8")`
11 months ago
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
11 months ago
b7799f0475
Convert 'sealed' sub-object to 'data object'
11 months ago
9f3103c212
Merge branch 'android:main' into loading-progress-for-image
11 months ago
995d7b643f
Add missing full stop in `search_not_ready` string
11 months ago
f1a2993adc
feat: remove add placeholder todo
11 months ago
e13e84c155
Replace usages of 'displacement' to 'moved' in parameter names
...
Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a
12 months ago
eeb4973265
PR feedback
...
Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f
12 months ago
bdf3ee3cb0
PR feedback
...
Change-Id: Ie22aa3c7fdf4c8ca8d8118837cfd279de8c6d80b
12 months ago
cb1d50e65e
Even better names
...
Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65
12 months ago
3aec705048
Add padding to scrollbars
12 months ago
31b4841cb2
Add scrollbars to app
12 months ago
0016b10037
Added TextStyle color for ClickableText
12 months ago
9197b332c4
Merge pull request #825 from android/refactor/interest_item
...
Refactor InterestsItem to a Material3 ListItem
12 months ago
ed90a382aa
Rename LazyListScope.TopicBody LazyListScope.topicBody
12 months ago
445c18a803
Refactor InterestsItem to Material3 ListItem
...
Change-Id: I12adc8820964aecd97ea0b4e22ae13e95e1428ab
1 year ago
4d65946f95
Merge pull request #808 from SimonMarquis/compose-bom-2023-06-00
...
Upgrade Compose BoM `2023.06.00` and Compose compiler `1.4.7`
1 year ago
4af86580eb
Move analytics tracking of news deep link to an extension method
...
Change-Id: Id3d1a30d86634b9176067696db5ecfd4d02854a5
1 year ago
7203460051
Merge branch 'main' into compose-bom-2023-06-00
1 year ago
c4686cfa54
Track when deep link notifications are opened
...
Change-Id: I223b1c8fbca36f9b7f2a35d9cb2fa901d6f5be91
1 year ago
21777aba65
Merge pull request #799 from android/tm/feed-content-type
...
Add contentType to news feed
1 year ago
40b5248302
Replace deprecated method `TextFieldDefaults.textFieldColors`
...
```
TextFieldColors' is deprecated. Renamed to `TextFieldDefaults.colors` with additional parameters to controlcontainer color based on state.
```
1 year ago
9cd390c56a
Merge pull request #684 from MaximillianLeonov/feature-settings
...
Replace `if` condition with AnimatedVisibility component
1 year ago
19ffb53150
Don't use lambda contentType for a single item
...
Change-Id: I0588c031428d523707463c5f0f0b6c586ea5e2c3
1 year ago
4a8a43551a
Add contentType to news feed
...
Before
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5
frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
After
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2
frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef
1 year ago
cb84082ae7
Merge branch 'main' into patch/proguard
1 year ago
7826b4f5f2
Merge pull request #748 from SimonMarquis/fix/permissions
...
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
1 year ago
512930c239
Fix inline comment as suggested in PR
1 year ago
87c27f6b82
Apply suggested changes to inline comment
1 year ago
dd70bbd589
Fix ForYouScreen Compose Previews
...
Permissions should only be called in an Activity context, which is a layoutlib limitation. We need to avoid launching the permission request when in LocalInspectionMode, otherwise we'll have render errors on the ForYouScreen previews.
1 year ago
bea3661f81
Merge branch 'main' into feature-settings
...
# Conflicts:
# feature/settings/src/main/java/com/google/samples/apps/nowinandroid/feature/settings/SettingsDialog.kt
1 year ago
7dadf033c1
Add comment for ColumnScope usage
1 year ago
7b30720b25
Remove nested scaffold from the bookmarks screen
...
Change-Id: Ie8b6f160d341156a6f9c02c0ca7f530095fb2950
1 year ago
1345764649
Merge pull request #770 from android/refactor/remove_unused_statements
...
Remove unused statements
1 year ago
83fa8c887f
Spotless apply
...
Change-Id: I80457acc6a49fe9755240a3d52ff96a8fdfd6b92
1 year ago
99094199bc
Remove redundant suppressions
...
Change-Id: Iae08b6f284cf7a387922fdec34c8a0aa0da809ef
1 year ago
5bf66739bd
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
1 year ago
2bf3018898
Merge pull request #763 from SimonMarquis/cleanup/unused-resources
...
Cleanup unused string resources
1 year ago
9aba5cc0fe
Cleanup unused string resources
1 year ago
b453386327
Ellipsis string can be replaced with ellipsis character
...
Lint: Replace `...` with ellipsis character `…`
1 year ago
8f41a6b3ab
Cleanup proguard configuration
...
- Remove custom KotlinX Serialization config as it's already provided, see https://github.com/Kotlin/kotlinx.serialization#android .
- Delete empty config files.
1 year ago
823c4db201
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
...
Continues the work initiated in #738 .
Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.
1 year ago
a03307e14d
Merge pull request #738 from SimonMarquis/patch-5
...
Grant `POST_NOTIFICATIONS` permission in instrumented tests
1 year ago
a93cce92f7
Update ForYouScreenTest.kt
1 year ago
69879ff874
Grant permission only if TIRAMISU or above
1 year ago
331e8cffac
Grant `POST_NOTIFICATIONS` permission in instrumented tests
1 year ago
d6ba65c77f
Update `BookmarksGrid` horizontal spacing to fix #732
1 year ago
f809142cb2
Add missing appcompat dependency
...
Change-Id: I6192623d21986962c17204720fa1a1778b773b56
1 year ago
13f1f8d096
Exclude transient appcompat dependency
...
Change-Id: Ifdd7e34192c5db8598c42f67088ac292b38ee3e2
1 year ago
c7c2bb04aa
Spotless apply
...
Change-Id: I773059a755bebf99af30a71fd44aa12e58f46b23
1 year ago
fc3d0ced20
Replace hardcoded license file with OSS licenses plugin
...
Change-Id: I4427fd5d7b7abd8a2912a41f61ffedfac4af9d6a
1 year ago
5f49c6ae25
Merge pull request #568 from vishesh211/vishesh211/bug-534-interests-multiple-click
...
Interests multiple click
1 year ago
aae307ee08
Fix spotless
...
Change-Id: I84da36ba957cb74f9fb4479e81d714c2d8928a01
1 year ago
6343b831b9
Use NoOpAnalyticsHelper for tests
...
Change-Id: I44657037f8f7ec6e38bcc3901e235ceab8c71237
1 year ago
0e40e26f22
Add analytics for search queries
...
Change-Id: If5290a903afb928fc1c3aaa66a52d2f182aba118
1 year ago
6a8736d4d0
Improvement in the Search screen ( #717 )
...
Combine the search result of topics and news resources in one
LazyVerticalGrid so that topics don't get in the way.
Before this change, the result of topics created a LazyColumn and
the result of news resources created the LazyVerticalGrid separately
that made the situation where there were two separete vertical scrolling
lists.
1 year ago
3b1b1ea4c1
Merge pull request #712 from android/tj/news-notifications
...
Notify users when news are updated
1 year ago
0ebd0ab660
Remove unused import
1 year ago
2291eb0fe2
Remove unused imports
1 year ago
634e7f0289
Remove `toUri()`
1 year ago
3b11156af5
Replace manual URI handling with Compose's `LocalUriHandler`
1 year ago
5d51cdcd28
Fix navigation tests
1 year ago
ef97cb941c
Route notification deep link through for you screen
1 year ago
2499c0a0bd
Notify users when news are updated
1 year ago
794d84cf67
done required cleanup
1 year ago
079f92ea32
feat: added launchSingleTop in navigate
1 year ago
487a288191
fix: removed disableSplitMotionEvents
1 year ago
b3cdc172cd
Implement search feature ( #685 )
...
Implement search feature
- Add a feature module named "search"
- Add a SearchScreen that is navigated by tapping the search icon at the top left corner
- Add a data layer that takes care of populating the *Fts tables and querying them by a search query
- Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen
The SearchScreen has following features:
- The user is able to type the search query in the TextField
- The search result is displayed as the user types
- When the search result is clicked, it navigates to:
- The InterestsScreen when a topic is clicked
- Chrome custom tab with the URL of the clicked news resource
- When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches
- Latest recent searches are displayed in the SearchScreen
1 year ago
6c18b25d5d
Replace `if` condition with AnimatedVisibility component
1 year ago
bf747434cd
Add Undo snackbar on Bookmark removal
...
Change-Id: I1fefd6e72378e26ae35b66e032529a116cff9a79
1 year ago
2c18740d62
Merge pull request #665 from AnirudhPudari/migrate-to-compose_flowlayouts
...
[Bug]: Migrate away from accompanist/flowlayout
1 year ago
050db2cb72
Merge branch 'main' into jr/track-viewed
1 year ago
b49767a88c
Rename getUserNewsResources to observeAll
1 year ago
33a3e360a4
Deprecated FlowLayouts from accompanist
1 year ago
3b7e7e3c02
Use ReportDrawnWhen
...
Change-Id: I77b4db63f72f43c6c826e66358f7672792ef137d
1 year ago
08956492c8
Backend triggered sync
...
Change-Id: I53c43b136ebb755f6258b1e815301dddb3b536a3
1 year ago
ba6a697844
Merge pull request #624 from SimonMarquis/gradle-sort
...
Sort and group Gradle dependencies
1 year ago
93c01ad184
Fix trailing commas based on spotless check
1 year ago
049750dd51
Merge branch 'main' into ui-polish
1 year ago
6b605a779c
Fix ForYouScreenTopicSelection Compose Preview
1 year ago
57c13d84bd
Incorporate code review changes: Move UserNewsResourceRepository to data
...
module; move UserNewsResource to model module. Implement unread dot for
bookmarked articles. Keep the flows cold in UserNewsResourceRepository.
1 year ago
8ec54d19d8
Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter
1 year ago
ebfbb5bafd
Display unread state on the news feed and bottom nav bar
...
When a news resource is unread, display a dot on its card in the news
feed. When the For You section has unread resources, display a dot on
its icon in the navigation bar.
Update the read status when a resource is opened.
1 year ago
bd450099fb
Replace GetUserNewsResourcesUseCase with UserNewsResourceRepository
...
This moves the responsibility for joining the UserData and the
NewsResources to UserNewsResourceRepository. This way, the work can be
done once and shared with all consumers in a SharedFlow, rather than
having each consumer perform the join itself by invoking the UseCase.
1 year ago
098649d02f
Remove unnecessary text description for buttons on Interest page
...
Change-Id: I33968bf3a42de795eaa55e72cb86c2898f936dd1
1 year ago
ae58d1e1b0
Merge pull request #592 from android/tj/news-resource-query
...
Add NewsResourceQuery to better query encapsulation
1 year ago
09f5c3bc61
Add NewsResourceQuery to better query encapsulation
...
Change-Id: I93f8c8ae2d1144975f6f9ff1ba93be9a4600768a
1 year ago
874c2d1487
Merge pull request #561 from SimonMarquis/update/androidx-lifecycle
...
Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05
1 year ago
17ffb5bf3e
Merge pull request #586 from takagimeow/fix/add-padding-for-loading-wheel
...
Add padding between the loading wheel and the top of the screen
1 year ago
cc3f7905e5
Resolved format violations error
1 year ago
4d4f7d4a15
Merge remote-tracking branch 'origin/main' into update/androidx-lifecycle
1 year ago
36eeb19da8
Merge remote-tracking branch 'goog/main' into feb13-merge
...
* goog/main:
Revert "Revert "Revert "Revert "New build trigger""""
Bump versionCode to 5
Remove AD_ID permission
Add Firebase analytics. See go/nia-firebase-services.
Simplify build script
Copy local.properties during build
Fix exit codes
Remove .prod from the applicationIdSuffix in preparation for Play launch
Build aab with play services enabled
Build release artifacts separately, using google-services
Enable use-google-services in release builds
Revert "Revert "Revert "New build trigger"""
Revert "Revert "New build trigger""
Revert "New build trigger"
New build trigger
Increment internal build trigger
Adding a file which can be modified to trigger an internal build
Add Firebase dependencies
Remove API 23 from list of APIs to test in Firebase Test Lab (it's flaky)
Copy google-services.json from prebuilts folder
Change-Id: Ibc76e1b89c6c7e7f58843edb56581e169c9ce14e
1 year ago
8b8401e3ec
Add padding between the loading wheel and the top of the screen
1 year ago
0d23e64848
Merge pull request #558 from android/av/gmd-convention-plugin
...
Switch GMD to use a convention plugin
1 year ago
4284e6912e
Merge remote-tracking branch 'github/main' into feb9automerger
...
* github/main:
Bump version to 4
Remove unused DropdownMenu component
Route topic chip tap events up to NiaNavHost
Apply suggestions from code review
Migrate custom room configuration into a convention plugin
Update docs/ArchitectureLearningJourney.md - User action follow topic
Update docs/ArchitectureLearningJourney.md - Writing data
Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea
1 year ago
322ff63dbc
Route topic chip tap events up to NiaNavHost
...
Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7
1 year ago
e3e33d8497
Merge "Add Firebase analytics. See go/nia-firebase-services." into main
1 year ago
2a4d0434a5
Add Firebase analytics. See go/nia-firebase-services.
...
Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689
1 year ago
a8d7d3b1a2
Increase settings touch target for radio button and text link
...
Change-Id: If80f1a94a82eb6fd7aef7b6ee8fff9640032d180
1 year ago
0695fbdc27
Merge remote-tracking branch 'origin/vishesh211/bug-534-interests-multiple-click' into vishesh211/bug-534-interests-multiple-click
...
# Conflicts:
# feature/interests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/TabContent.kt
1 year ago
f9a3533df3
Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05
...
> `Transformations` is now written in Kotlin. This is a *source incompatible change* for those classes written in Kotlin that were directly using syntax such as `Transformations.map`
> Kotlin code *must* now use the Kotlin extension method syntax that was previously only available when using `lifecycle-livedata-ktx`.
> The `collectAsStateWithLifecycle()` APIs of `lifecycle-runtime-compose` are no longer in experimental status. (I09d42, b/258835424)
Changelog: https://developer.android.com/jetpack/androidx/releases/lifecycle#2.6.0-alpha05
1 year ago
6146dd5576
Switch GMD to use a convention plugin
...
Change-Id: Ia4f94cd7533c9168752ee39e3f960108fe802ab4
1 year ago
5b8fef7c26
Merge pull request #528 from android/refactor/preview_parameters
...
Replace global variables with PreviewParameterProvider
1 year ago
a4eddf6fa3
bug: fixed bug #534 of multiple clicks on the interests screen
1 year ago
f9dcdb4390
More refactoring
1 year ago
e536c396f9
Move new UseCase and tests into separate files
...
Change-Id: I4c337473ca0a60a5fccbb8aa640735cf7d616e71
1 year ago
bcb4d7d592
Replace global variables with PreviewParameterProvider
1 year ago
5a29414b7a
Fix spotless
1 year ago
a9bf21aaf4
Add UseCase for getting followed news resources, refactor ForYouVM
1 year ago
20c29a6c09
Fix bookmarking scrolling to top of the page bug ( #548 )
1 year ago
1d081ce26f
Fix formatting for a trailing comma
...
Change-Id: I300ec889aa9cd726a3cc60294e0cf7707e3361a6
1 year ago
11fbf53f12
Merge pull request #543 from android/mb/trailing-commas
...
Enable trailing commas via .editorconfig
1 year ago
893ac390a6
Merge pull request #524 from andhiratobing/main
...
Set item keys for smart recomposition of topics
1 year ago
819dd494ad
Run Spotless to add trailing commas (and apply other rule updates)
...
Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209
1 year ago
cfbf782613
Merge pull request #542 from android/as/dynamic-color-option
...
Add dynamic color option in settings for API >=32
1 year ago
f28d7f0eef
change the bookmark image to SVG
...
Change-Id: I2a9ae27d338127ab2a7b2b90ecff5b565fe5bd1a
1 year ago
257d3e5c70
change the bookmark image to SVG
...
Change-Id: I995faf3ac437cf78c7c447801a969fab01dbc85d
1 year ago
6b48b355cc
Merge branch 'main' into tm/fix-benchmarks-no-people
...
Change-Id: I94ca19fad5527c11a2f0f28cc43a23ab22f419a7
1 year ago
46c1d510d4
Android-CI workflow -> GMD refactor ( #537 )
...
This PR is about updating the operating system to macOS-12 as the previous one was going to be deprecated, as well as updating the checkout to v3 to avoid the warnings in the panel; adding setup SDK action to accept the license which was missing from the beginning.
I also added imports instead of adding them directly with the codes.
As a reference, there was another PR with a similar topic, but it wasn't complete: #483
1 year ago
dbbe8ffecb
Small fix for naming and boolean logic
...
Change-Id: I3dd291bdd581494574c557329bf23f5ed07af0bb
1 year ago
19efc1b5e8
Fix Spotless issue manually
...
Change-Id: Icd560e6ceaaeee0a6f502fe49b3403ab07f926ef
1 year ago
aa6f338f38
Make empty bookmark icon dynamic to dynamic color settings
...
Change-Id: I6a69f0a82f91536d43d986cc5a382b65f4219816
1 year ago
6046f6e943
Add dynamic color option in settings for API >=32
...
Change-Id: Ib42c1cbd0208e98ef7610a1c8aca5d721aa464e6
1 year ago
4633609930
Introduce GMD + ATD ( #479 )
...
Introduce Gradle Managed Device definitions to modules that have instrumented tests.
At the moment, defining it as a convention plugin isn't possible due to the bug. That bug is now fixed and will be included in Android Studio Flamingo.
Once Flamingo becomes stable, convert the GMD definitions as a convention plugin (#523 )
Change-Id: I0866369e3d0bbe148ca5ec1f92bad59239a347b8
1 year ago
8eac9a4bdd
Set item keys for smart recomposition of topics
2 years ago
bad3ea60f5
Refactor Topics news feed, tidy a few other bits up
...
Change-Id: Id4c9d1bce484137b363ec4cd21a45ca9863a2e7f
2 years ago
cafac8eb09
fix spotless, tidy test data
...
Change-Id: I4ceb7b85e5a8dd4d4f20088b2594c6b4030299bb
2 years ago
dd81618f89
Fix UI tests
...
Change-Id: Ie42077d20523c28a61c75bccfdc11d8a34d8a8a9
2 years ago
24df51349d
Move mapping logic into secondary constructor
...
Change-Id: I032326f502d27f2d3bd9fb8273ae44df878d172c
2 years ago
355b0540aa
Move construction of UserNewsResource into separate function
...
Change-Id: I7c1f6427cd7d95c2016349fec301b88455b33cf2
2 years ago
32bc5c1590
Fix merge conflicts
2 years ago
2f454de21c
Spacing polish based on design spec
2 years ago
47bc4a7b88
Merge pull request #504 from android/dt/fix-build-warnings
...
Fix build warnings
2 years ago
4484743830
Merge pull request #453 from LinX64/no_bookmarks_state_test
...
[Saved screen] Added the test for empty state and refactor
2 years ago
1acee42167
Merge pull request #493 from andhiratobing/main
...
Set visibility modifier of composable preview to private
2 years ago
cf053ade5a
Fix build warnings
2 years ago
2534bdc5f8
CI error due to invalid file format resolved
2 years ago
5638e253ae
Fix unit and UI tests. Apply spotless.
...
Change-Id: Iab75852a27a44309d349f84e65226911ab59fcd5
2 years ago
ec4bceead3
Renamed SaveableNewsResource to UserNewsResource
2 years ago
6941e2082b
Renamed SaveableNewsResource to UserNewsResource
2 years ago
a9a8a18d16
remove the redundant "interests" prefix
2 years ago
cfe6e65311
Typo fix for search
2 years ago
1e493c0bbc
Set visibility modifier of composable preview to private
2 years ago
154f05e23f
Remove tab state from InterestsViewModel
...
Change-Id: I5c15015f27fa0aa7709d0c3959d761355c8d9722
2 years ago
8a051eaa5c
Fix spotless issues
2 years ago
c12fe1fbe5
Update :core-designsystem module based on Figma file
2 years ago
0018144827
LoadingWheel testTag for every loading wheel
...
Change-Id: I7728e1717925abdfb607e93f3d48226910d42c0d
2 years ago
ec6e902c0f
Waiting for topic selection
...
Change-Id: I44226a7c5e693ee92eed27070c09cd4e0751e674
2 years ago
Adetunji Dahunsi
dahunsi
Simon Marquis
Qamar A. Safadi
qamarelsafadi
TJ Dahunsi
Silvia García Bouza
Milosz Moczkowski
takahirom
Alex Vanyo
Don Turner
Tomáš Mlynarič
Simon Marquis
James Rose
Amaury Medeiros
Maximillian Leonov
Don Turner
Takeshi Hagikura
vishesh211
Maximillian Leonov
Neelansh Sahai
AnirudhPudari
Chris Sinco
Caren
Caren
Keisuke Takagi
Márton Braun
Angie Sasmita
Manuel Vivo
Mohsen Rzna
ratobing
Muhammad Anas Shamsi
magicalmeghan
Nick Rout