Jaehwa Noh
eee94e4b7d
Finalize bump agp 9.0 (enable newDsl) ( #2054 )
...
* Bump protobufPlugin 0.9.6
Change-Id: I9f4174946f043c79bba9a669655f6654036b5679
* Change Android library to Jvm library.
Change-Id: I20ca1f71610f26a18d4573b3122994bc32c18723
* Enable newDsl.
Change-Id: Ifb855133593f64771e81f60b96c3e34d946dac8f
* Update README.
Change-Id: I3df518dd4a5f37ba7ca6e568914783b1ea417fce
8 months ago
Don Turner
8f269ff57a
Fix module graph generation.
9 months ago
Don Turner
92fd6f6605
Remove feature module READMEs (they will be replaced by submodule READMEs)
9 months ago
Don Turner
53cbbbf594
Rename settings feature string resources
...
Updated string resource identifiers in the `SettingsDialogTest` to follow the `feature_settings_impl_` prefix convention. This aligns the test resources with the recent module renaming.
9 months ago
Don Turner
1ded3e3db5
Refactor settings feature from api to impl
...
The `feature:settings:api` module has been renamed to `feature:settings:impl` to better reflect its role as an implementation module.
This change includes:
* Updating module paths and namespaces.
* Moving all related files, including source code, resources, and tests, to the new `impl` directory.
* Updating dependencies and project configurations in Gradle scripts and README files to point to the new module path.
* Renaming string resources to include the `_impl` suffix for clarity.
* Updating the AndroidX Lifecycle dependency to version 2.10.0.
9 months ago
Don Turner
cedc689f1a
Disable checkGraphs CI step as it is failing for an unknown reason
9 months ago
Clara Fok
e373828f5f
Update feature ViewModels and tests
10 months ago
Clara Fok
068d8cc93c
Split feature modules into api and impl modules
...
Source code is still left in api module. impl module is empty at this point.
10 months ago
Simon Marquis
17162dab60
graphUpdate
12 months ago
Simon Marquis
1c61be7b7b
Update color mapping
...
| Type | Plugin ID | Color |
|-------------|------------------------------------|------------------------|
| Application | `nowinandroid.android.application` | `#CAFFBF` PastelGreen |
| Feature | `nowinandroid.android.feature` | `#FFD6A5` PastelOrange |
| Library | `nowinandroid.android.library` | `#9BF6FF` PastelBlue |
| Test | `nowinandroid.android.test` | `#A0C4FF` PastelMauve |
| JVM | `nowinandroid.jvm.library` | `#BDB2FF` PastelPurple |
| Unknown | `?` | `#FFADAD` PastelRed |
1 year ago
Simon Marquis
e8dc43b58b
graphUpdate
1 year ago
Simon Marquis
e079e68815
Delete old graphs
1 year ago
Don Turner
9a183d5fcc
Fix spotless
2 years ago
Don Turner
a6680e4bab
Update feature/settings/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/settings/SettingsDialog.kt
2 years ago
Abhinav Srivastava
20e568e98b
Update SettingsDialog.kt
2 years ago
saeedishayan76
26dd4424f6
remove blank lines for resolve spotless error
2 years ago
saeedishayan76
0356b873e9
change collectJob to backgroundScope coroutine
2 years ago
Simon Marquis
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
3 years ago
Don Turner
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
3 years ago
Don Turner
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
3 years ago
Don Turner
522efac8c0
Update Compose BOM to 2024.02.00. Fixes #1218
...
Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b
3 years ago
Don Turner
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
3 years ago
Simon Marquis
b043d8db86
Replace workaround on SettingsViewModel now that a fix has been deployed
...
The issue has been addressed in `androidx.compose.ui:ui:1.5.0`.
3 years ago
Don Turner
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
3 years ago
lihenggui
fb5bd225be
Spotless
3 years ago
Simon Marquis
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
3 years ago
kimdowoo
129099e219
refactor/Convert object to data object in sealed interface
3 years ago
Melwin Magalhaes
6247712064
Add convention plugins to version catalogs
3 years ago
Simon Marquis
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
3 years ago
Simon Marquis
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
3 years ago
Simon Marquis
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
3 years ago
Simon Marquis
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
3 years ago
Alex Vanyo
9cd390c56a
Merge pull request #684 from MaximillianLeonov/feature-settings
...
Replace `if` condition with AnimatedVisibility component
3 years ago
Simon Marquis
cb84082ae7
Merge branch 'main' into patch/proguard
3 years ago
Maximillian Leonov
bea3661f81
Merge branch 'main' into feature-settings
...
# Conflicts:
# feature/settings/src/main/java/com/google/samples/apps/nowinandroid/feature/settings/SettingsDialog.kt
3 years ago
Maximillian Leonov
7dadf033c1
Add comment for ColumnScope usage
3 years ago
Milosz Moczkowski
1345764649
Merge pull request #770 from android/refactor/remove_unused_statements
...
Remove unused statements
3 years ago
Miłosz Moczkowski
83fa8c887f
Spotless apply
...
Change-Id: I80457acc6a49fe9755240a3d52ff96a8fdfd6b92
3 years ago
Miłosz Moczkowski
99094199bc
Remove redundant suppressions
...
Change-Id: Iae08b6f284cf7a387922fdec34c8a0aa0da809ef
3 years ago
Miłosz Moczkowski
5bf66739bd
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
3 years ago
Simon Marquis
b453386327
Ellipsis string can be replaced with ellipsis character
...
Lint: Replace `...` with ellipsis character `…`
3 years ago
Simon Marquis
8f41a6b3ab
Cleanup proguard configuration
...
- Remove custom KotlinX Serialization config as it's already provided, see https://github.com/Kotlin/kotlinx.serialization#android .
- Delete empty config files.
3 years ago
Miłosz Moczkowski
f809142cb2
Add missing appcompat dependency
...
Change-Id: I6192623d21986962c17204720fa1a1778b773b56
3 years ago
Miłosz Moczkowski
13f1f8d096
Exclude transient appcompat dependency
...
Change-Id: Ifdd7e34192c5db8598c42f67088ac292b38ee3e2
3 years ago
Miłosz Moczkowski
c7c2bb04aa
Spotless apply
...
Change-Id: I773059a755bebf99af30a71fd44aa12e58f46b23
3 years ago
Miłosz Moczkowski
fc3d0ced20
Replace hardcoded license file with OSS licenses plugin
...
Change-Id: I4427fd5d7b7abd8a2912a41f61ffedfac4af9d6a
3 years ago
Simon Marquis
0ebd0ab660
Remove unused import
3 years ago
Simon Marquis
2291eb0fe2
Remove unused imports
3 years ago
Simon Marquis
634e7f0289
Remove `toUri()`
3 years ago
Simon Marquis
3b11156af5
Replace manual URI handling with Compose's `LocalUriHandler`
3 years ago