nowinandroid

Commit Graph

Author	SHA1	Message	Date
saeedishayan76	26dd4424f6	remove blank lines for resolve spotless error	2 years ago
saeedishayan76	0356b873e9	change collectJob to backgroundScope coroutine	2 years ago
yongsuk44	f0434e52a4	Spotless Apply	2 years ago
yongsuk44	46e15f21dc	Fix duplicate composition trace markers in composable	2 years ago
Don Turner	8d57134663	Fix spotless Change-Id: Ib093c206809a470b7f6135933bd2a72046865684	2 years ago
Don Turner	a8ffd1f2f1	Fix incorrect deep link key name in ForYouViewModelTest Change-Id: I945632c419e11671eb73690999f9a234e577d16b	2 years ago
Don Turner	4b3f5370b9	Clean up deep link handling Change-Id: I9d589cfe5c20a6b55708b99f5d79b10271af8ab4	2 years ago
Don Turner	00efda54e8	Merge branch 'main' into dt/nav-safe-args * main: (58 commits) Instrumented tests for InterestsListDetailScreen (#1518) Remove Firebase AD_SERVICE_CONFIG property updateProdReleaseBadging Merge Android & JVM plugins into a single `HiltConventionPlugin` Update dependency guard 🤖 Updates baselines for Dependency Guard Update to Lifecycle 2.8.3 Add android.adservices.AD_SERVICES_CONFIG to badges Apply suggestions from code review Update app/src/main/AndroidManifest.xml generateModuleGraphs dependencyGuardBaseline updateProdReleaseBadging Fix spotless. Change set to `=` operator Cleanup unused reference in `libs.versions.toml` Regenerate SVG graphs Update comment wording Use stdin to avoid repeating the output file name Replace bash commands with proper svgo cli ... Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5	2 years ago
Simon Marquis	1c5513283a	Merge remote-tracking branch 'origin/main' into fix/1161-2	2 years ago
Don Turner	95bdc0f533	Rename ForYouRoute composable to ForYouScreen Change-Id: I47456f19f2b41cafe44ba7636cad6d1fea782a33	2 years ago
Don Turner	da8f32a2ea	Rename Destinations to Routes Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7	2 years ago
Don Turner	aba2b2c154	Remove different deeplink destination, add route for nested nav host Change-Id: Idb9586752d815449243d6d529e9b655c45e395ad	2 years ago
Don Turner	4a84cf2bf4	Add specific type for deeplinks Change-Id: I63c0abb16cbf540ef72dfb945518a48113bdbf75	2 years ago
Don Turner	f67f4d1a83	Update ForYou destination to match current deeplink pattern Change-Id: Ia5ab36f2d75d8d061e63c0cac5262503bc93a638	2 years ago
Don Turner	7ec21d9d2f	Fix issue where selected topic in list was not showing as selected. Minor tidy ups. Change-Id: Icfa79eac6f7327c365f79fd7d15dfa1f8c77184d	2 years ago
Alex Vanyo	3fb6df7c33	Add NavigationSuiteScaffold Change-Id: I36710d880bff381ed86c61632f2ab91902727775	2 years ago
dturner	8cc0fc00e6	🤖 Updates screenshots	2 years ago
Don Turner	924391cd22	Fix spotless Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428	2 years ago
Don Turner	89163b5ea1	Migrate remainder of app to type-safe navigation Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b	2 years ago
Simon Marquis	930e061611	Cleanup dependencies This is a followup cleanup of #1163 that was partially addressed by #1140. - Remove unused `projects.core.testing` dependencies (or replace with direct dependencies). - Introduce `androidx.compose.ui.test` bundle. - Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.	2 years ago
Don Turner	0584f191bc	Merge pull request #1271 from android/dt/remove-feature-dep Remove the search module's dependency on other feature modules	2 years ago
Alex Vanyo	78c77737c0	Merge pull request #1275 from Jaehwa-Noh/rename-function Rename function to setNewsResourceBookmarked	2 years ago
Don Turner	a4c52e6485	Remove the search module's dependency on other feature modules Change-Id: I17df9948fed04ddc7ba507b437d39536b8b180bb	2 years ago
Don Turner	a5025390af	Add title to READMEs to describe the dependency graph Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528	2 years ago
Jaehwa Noh	ee4320723f	Fix typo. Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f	2 years ago
Jaehwa Noh	ed91723e2f	Fix #1270 Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c	2 years ago
Don Turner	80a82de945	Update module dependency graphs and add script to create them Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31	2 years ago
Alex Vanyo	e3c7018124	Extract ScreenshotHelper to separate testing module Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af	2 years ago
Don Turner	db5e2b649e	Remove unnecessary Boxes Change-Id: Ia404cde7f6b555234bef4b27058fabd4471ea3c6	3 years ago
dturner	27fd4e544a	🤖 Updates screenshots	3 years ago
dturner	02d4fea615	🤖 Updates screenshots	3 years ago
dturner	81a5c0a3a7	🤖 Updates screenshots	3 years ago
dturner	9e645356f6	🤖 Updates screenshots	3 years ago
Don Turner	2271d01da5	Fix spotless Change-Id: I8d19c437fc6e2e2198af5ac871c3f7813d280923	3 years ago
Don Turner	b1d867f827	Replace BoxWithConstraints with Box (fixes linter error) Change-Id: Iea0401e28ae0e884511800652fde0f1896642aa0	3 years ago
dturner	6b2b01ed82	🤖 Updates screenshots	3 years ago
Ben Weiss	f64f1c0aa2	Remove legacy benchmark build type (#1207 ) * Remove legacy benchmark build type Now that we have the baseline profile gradle plugin, there is no need for a benchmark build type. The plugin does the setup and configuration and runs against the correct app flavor. * Remove explicit benchmark build type from benchmark module * Remove stale build task exclusions * Fix tracing import location FYI @mlykotom	3 years ago
Tomáš Mlynarič	d9aaec0699	Use androidx.tracing everywhere Change-Id: I847827efc08f5cbc00f0c809ad992c267f826e50	3 years ago
Jose Alcérreca	3ff5d48f37	Restores screenshot tests in foryou (#1199 )	3 years ago
Don Turner	707117a4f2	Merge branch 'main' into kotlinify	3 years ago
Don Turner	0f0511748e	Merge pull request #1088 from SimonMarquis/cleanup-dependencies Reduce overall build complexity	3 years ago
Don Turner	89d39a7242	Merge pull request #767 from SimonMarquis/resource-prefix Enforce `resourcePrefix` on Android library modules	3 years ago
Simon Marquis	65f0d5b2d9	Update feature/foryou/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/foryou/navigation/ForYouNavigation.kt	3 years ago
Don Turner	9d41ffa318	Merge branch 'main' into kotlinify	3 years ago
Simon Marquis	b6d82e24df	Merge branch 'main' into kotlinify	3 years ago
lihenggui	2a2d8ed88d	Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE	3 years ago
lihenggui	32e1ec0447	Remove violations: property-naming	3 years ago
lihenggui	f8f932705a	Remove violations: discouraged-comment-location	3 years ago
Simon Marquis	f27a2e176e	Reduce overall build complexity - Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces - Correctly configure the visibility of dependencies: - `api` when it's part of it's public `api` - `implementation` when it's part of it's internal `implementation` - Remove unnecessary dependencies in build.gradle.kts files - Remove unnecessary dependencies provided by plugins - Remove unnecessary applied plugins (i.e. roborazzi) - Sort dependencies in `build.gradle.kts` - Delete unused entries in `libs.versions.toml`	3 years ago
Simon Marquis	caa482bc71	Kotlinify codebase - Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)	3 years ago
Simon Marquis	988002e692	Update Robolectric 4.11.1 - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11 - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1 > Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below. Removing explicit API 33 Robolectric configuration.	3 years ago
Adetunji Dahunsi	0287af8d9a	Merge pull request #947 from android/tj/staggered-grid-feed Use lazy vertical staggered grid in feed to maximize space utilization	3 years ago
Melwin Magalhaes	6247712064	Add convention plugins to version catalogs	3 years ago
tunjid	b2498c763f	🤖 Updates screenshots	3 years ago
dahunsi	03d2455f41	Use lazy vertical staggered grid in feed to maximize space utilization Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926	3 years ago
Simon Marquis	b2cd980170	Merge remote-tracking branch 'origin/main' into resource-prefix	3 years ago
Simon Marquis	ebfe01affd	Enforce `resourcePrefix` on Android library modules ``` :ui-test-hilt-manifest -> ui_test_hilt_manifest_ :core:analytics -> core_analytics_ :core:common -> core_common_ :core:data -> core_data_ :core:data-test -> core_data_test_ :core:database -> core_database_ :core:datastore -> core_datastore_ :core:datastore-test -> core_datastore_test_ :core:designsystem -> core_designsystem_ :core:domain -> core_domain_ :core:network -> core_network_ :core:notifications -> core_notifications_ :core:testing -> core_testing_ :core:ui -> core_ui_ :feature:bookmarks -> feature_bookmarks_ :feature:foryou -> feature_foryou_ :feature:interests -> feature_interests_ :feature:search -> feature_search_ :feature:settings -> feature_settings_ :feature:topic -> feature_topic_ :sync:sync-test -> sync_test_ :sync:work -> sync_work_ ```	3 years ago
Simon Marquis	a33dafccad	Migrate from `java` to `kotlin` sourceSet directory	3 years ago
Roy Matero	298f3ce4db	Merge branch 'android:main' into main	3 years ago
Jose Alcérreca	5b79869324	Adds dark screenshot tests and fixes background colors in ForYou (#918 ) * Adds dark screenshot tests and fixes background colors in ForYou * 🤖 Updates screenshots	3 years ago
Roy Matero	4e6cda1965	Renamed toggle function signature with boolean parameters Change-Id: I0d6c0ed4d4c0ee4bd387e5645fc558970f5f202b	3 years ago
Jose Alcérreca	886158d3cb	Adds Screenshot testing with Roborazzi (#876 ) * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	3 years ago
Simon Marquis	daa2228132	Restore original `type` labels	3 years ago
Simon Marquis	0377fd8712	Replace `NewsResourceType` enum with simpler String type See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901	3 years ago
Adetunji Dahunsi	153b34fd50	Merge pull request #850 from qamarelsafadi/loading-progress-for-image Fix #849: Loading progress for image	3 years ago
Don Turner	492697ce6b	Merge pull request #873 from SimonMarquis/misc-warnings Fix miscellaneous warnings	3 years ago
Qamar A. Safadi	2db3e0c804	Merge branch 'android:main' into loading-progress-for-image	3 years ago
Don Turner	8901e5932a	Merge pull request #872 from SimonMarquis/data-objects Convert 'sealed' sub-object to 'data object'	3 years ago
Qamar A. Safadi	8aa0457ca9	Merge branch 'android:main' into loading-progress-for-image	3 years ago
dahunsi	03610d229a	Update feedItemsSize calculation Change-Id: I2bf6a2fa0e210cef1318707d948a49d2ef010452	3 years ago
Simon Marquis	4bdc9705af	Fix miscellaneous warnings - Remove unused namespace declaration - Collapse empty manifest tags - Remove redundant qualifier name - Remove redundant suppression	3 years ago
Simon Marquis	b7799f0475	Convert 'sealed' sub-object to 'data object'	3 years ago
qamarelsafadi	f1a2993adc	feat: remove add placeholder todo	3 years ago
TJ Dahunsi	e13e84c155	Replace usages of 'displacement' to 'moved' in parameter names Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a	3 years ago
TJ Dahunsi	eeb4973265	PR feedback Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f	3 years ago
TJ Dahunsi	cb1d50e65e	Even better names Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65	3 years ago
TJ Dahunsi	3aec705048	Add padding to scrollbars	3 years ago
TJ Dahunsi	31b4841cb2	Add scrollbars to app	3 years ago
TJ Dahunsi	4af86580eb	Move analytics tracking of news deep link to an extension method Change-Id: Id3d1a30d86634b9176067696db5ecfd4d02854a5	3 years ago
TJ Dahunsi	c4686cfa54	Track when deep link notifications are opened Change-Id: I223b1c8fbca36f9b7f2a35d9cb2fa901d6f5be91	3 years ago
Tomáš Mlynarič	19ffb53150	Don't use lambda contentType for a single item Change-Id: I0588c031428d523707463c5f0f0b6c586ea5e2c3	3 years ago
Tomáš Mlynarič	4a8a43551a	Add contentType to news feed Before ScrollForYouFeedBenchmark_scrollFeedCompilationFull frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5 frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1 Traces: Iteration 0 1 2 3 4 5 6 7 8 9 After ScrollForYouFeedBenchmark_scrollFeedCompilationFull frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2 frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7 Traces: Iteration 0 1 2 3 4 5 6 7 8 9 Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef	3 years ago
James Rose	7826b4f5f2	Merge pull request #748 from SimonMarquis/fix/permissions Grant `POST_NOTIFICATIONS` permission in more instrumented tests	3 years ago
Amaury Medeiros	512930c239	Fix inline comment as suggested in PR	3 years ago
Amaury Medeiros	87c27f6b82	Apply suggested changes to inline comment	3 years ago
Amaury Medeiros	dd70bbd589	Fix ForYouScreen Compose Previews Permissions should only be called in an Activity context, which is a layoutlib limitation. We need to avoid launching the permission request when in LocalInspectionMode, otherwise we'll have render errors on the ForYouScreen previews.	3 years ago
Miłosz Moczkowski	5bf66739bd	Remove redundant statements Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89	3 years ago
Simon Marquis	9aba5cc0fe	Cleanup unused string resources	3 years ago
Simon Marquis	823c4db201	Grant `POST_NOTIFICATIONS` permission in more instrumented tests Continues the work initiated in #738. Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.	3 years ago
Simon Marquis	a93cce92f7	Update ForYouScreenTest.kt	3 years ago
Simon Marquis	69879ff874	Grant permission only if TIRAMISU or above	3 years ago
Simon Marquis	331e8cffac	Grant `POST_NOTIFICATIONS` permission in instrumented tests	3 years ago
TJ Dahunsi	5d51cdcd28	Fix navigation tests	3 years ago
TJ Dahunsi	ef97cb941c	Route notification deep link through for you screen	3 years ago
TJ Dahunsi	2499c0a0bd	Notify users when news are updated	3 years ago
Milosz Moczkowski	2c18740d62	Merge pull request #665 from AnirudhPudari/migrate-to-compose_flowlayouts [Bug]: Migrate away from accompanist/flowlayout	3 years ago
James Rose	050db2cb72	Merge branch 'main' into jr/track-viewed	3 years ago
AnirudhPudari	33a3e360a4	Deprecated FlowLayouts from accompanist	3 years ago
mlykotom	3b7e7e3c02	Use ReportDrawnWhen Change-Id: I77b4db63f72f43c6c826e66358f7672792ef137d	3 years ago
Adetunji Dahunsi	08956492c8	Backend triggered sync Change-Id: I53c43b136ebb755f6258b1e815301dddb3b536a3	3 years ago

1 2 3 4 5

249 Commits (main)