Aurimas Liutikas
15cc536a44
Upgrade to spotless 8.3.0
...
This picks up a fix for Gradle project isolation
https://github.com/diffplug/spotless/issues/1979
This makes progress on https://github.com/android/nowinandroid/issues/1842
Test: ./gradlew build -Dorg.gradle.unsafe.isolated-projects=true --dry-run
4 months ago
Aurimas
4a5becfc88
Make isolated projects mode pass without issues ( #2073 )
...
- Enable KSP isolated projects support https://github.com/google/ksp/issues/1752
- Disable spotless in isolated projects mode https://github.com/diffplug/spotless/issues/1979
- Disable graph tasks in isolated projects mode
https://github.com/android/nowinandroid/issues/1842
Test: ./gradlew build -Dorg.gradle.unsafe.isolated-projects=true --dry-run
5 months ago
Aurimas
5ba16edde9
Apply spotless by default ( #2055 )
...
* Apply spotless by default
- Upgrades to spotless 8.2.1
- Moves spotless setup from an init.gradle.kts to build-logic
- Narrows down the scope of `target` in spotless configuration to
be more precise to workaround https://github.com/diffplug/spotless/issues/2717
- Updates all references to init.gradle.kts
Ran gradle-profiler ./gradlew build --dry-run to validate performance
impact.
Before PR:
Mean 10,527.96 ms with 289.01 ms std dev
After PR:
Mean 11,251.78 ms with 530.29 ms std dev
Regression is there, but quite minor.
Test: ./gradlew spotlessCheck
* Address comments from AI overlords
* Fix usage of rootProject
* Enable spotless for build-logic via root project
5 months ago
Simon Marquis
9e984e5be8
Fix Hilt error by forcing kotlin-metadata-jvm version to match kotlin version
...
```
[Hilt] Provided Metadata instance has version 2.3.0, while maximum supported version is 2.2.0. To support newer versions, update the kotlin-metadata-jvm library.: java.lang.IllegalArgumentException: Provided Metadata instance has version 2.3.0, while maximum supported version is 2.2.0. To support newer versions, update the kotlin-metadata-jvm library.
```
6 months ago
Simon Marquis
718921fc67
Apply requested removal
6 months ago
Simon Marquis
374ed8b002
fix: restore removal during merge
6 months ago
Simon Marquis
7839613a5b
Restore kotlin-dsl extension available on `NamedDomainObjectContainer<T>`
6 months ago
Simon Marquis
c02fb76201
Merge remote-tracking branch 'origin/main' into agp-9
6 months ago
Aurimas
940d2b236c
Merge pull request #2018 from SimonMarquis/enum-entries
...
Replace `Enum.values()` with `Enum.entries`
7 months ago
Aurimas
282ffdb565
Merge pull request #2017 from SimonMarquis/fix-todo-aapt2
...
Replace provided APPT2 executable path
7 months ago
Aurimas Liutikas
0cc1d9ebf6
Upgrade to KGP 2.3.0 and KSP 2.3.4
...
Leave language version as 2.2 because AGP 8.x does
not yet support 2.3 in R8
Test: ./gradlew test
7 months ago
Simon Marquis
26dbc7948e
Replace `Enum.values()` with `Enum.entries`
...
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9
... started in #1120
7 months ago
Simon Marquis
7af1c8bef9
Fix warnings on changed files
...
- Redundant suppression
- UnstableApiUsage
- There is more than one label with such a name in this scope.
7 months ago
Simon Marquis
27ca4256f4
Replace provided APPT2 executable path
7 months ago
Simon Marquis
269f445848
Merge remote-tracking branch 'origin/main' into agp-9
7 months ago
Don Turner
8f269ff57a
Fix module graph generation.
7 months ago
Clara Fok
e373828f5f
Update feature ViewModels and tests
8 months ago
Clara Fok
c9e38b329a
Refactor app to navigation3
8 months ago
Clara Fok
af3ca67f64
Add NiaBackStack and BackStack providers
...
Bump agp versions and add navigation 3 dependency
8 months ago
Simon Marquis
1e7095d76a
Revert AGP's APIs change workarounds with `.apply{}` to reduce visual changes as requested
8 months ago
Simon Marquis
1ebc99d32c
Clarify Jacoco configuration for debug build
...
Add comment to clarify Jacoco configuration for debug builds.
8 months ago
Simon Marquis
52b118a1e0
Prevent Jacoco convention plugins to enable test coverage on release buildTypes
...
leading to "debuggable" release builds.
8 months ago
Simon Marquis
b060fd0b71
Replace API breaking changes
...
not sure if they were dropped on purpose...
8 months ago
Simon Marquis
4312937890
Remove maven repository for snapshots
8 months ago
Simon Marquis
df589f6538
Firebase Perf fix
...
(included in firebase-bom 34.5.0)
8 months ago
Simon Marquis
fb4a5ca970
KSP 2.3.1-SNAPSHOT
8 months ago
Simon Marquis
80bee3db34
Add explicit junit dependency on Android library modules
...
They must have been removed as they are no longer resolved by default.
9 months ago
Simon Marquis
a0ad9253c9
`devices` is deprecated in `managedDevices`
9 months ago
Simon Marquis
d46b9dc291
🚧 AGP 9
9 months ago
Simon Marquis
29d9903f39
Normalize link length
10 months ago
Simon Marquis
5009c37bbc
🧜♀️ Mermaid Graphs legends
10 months ago
Simon Marquis
1c61be7b7b
Update color mapping
...
| Type | Plugin ID | Color |
|-------------|------------------------------------|------------------------|
| Application | `nowinandroid.android.application` | `#CAFFBF` PastelGreen |
| Feature | `nowinandroid.android.feature` | `#FFD6A5` PastelOrange |
| Library | `nowinandroid.android.library` | `#9BF6FF` PastelBlue |
| Test | `nowinandroid.android.test` | `#A0C4FF` PastelMauve |
| JVM | `nowinandroid.jvm.library` | `#BDB2FF` PastelPurple |
| Unknown | `?` | `#FFADAD` PastelRed |
10 months ago
Simon Marquis
5e34fb49c0
Create `RootPlugin` to `configureGraphTasks()` on `subprojects`
10 months ago
Simon Marquis
c94e82849b
Merge remote-tracking branch 'origin/main' into graphs
10 months ago
Don Turner
a152149dc5
Merge pull request #1947 from Jaehwa-Noh/gradle-to-gradle-api
...
Replace gradle to gradle-api.
10 months ago
Simon Marquis
c7dec20993
Generate Mermaid graphs
11 months ago
Aurimas Liutikas
4d45004820
Upgrade to latest stable AGP 8.12.2
...
- Upgrades to a newer version of compose bom that pulls in newer
versions of lint checks that work with AGP 8.12.2
- Bump the minSdk to 23 because compose now requires minSdk 23
- Update Navigation_fontScale2.png due to compose upgrade
- Clean up BuildConfig set up since we already use Gradle 9.0.0
Test: ./gradlew build
11 months ago
Jaehwa Noh
17100a4119
Replace gradle to gradle-api.
...
Should use `gradle-api`.
https://developer.android.com/build/releases/gradle-plugin-roadmap#agp-10
Change-Id: If1c4869eb57ef3d3e1834c57768b90e5d6967f10
11 months ago
Aurimas Liutikas
7ff1913855
Fixes host test tasks that were accidentally attemping to run
...
Gradle 9.0.0 has the new enforcement that Test task runs that
have sources but no tests run should fail. Without this change we get
Execution failed for task ':core:analytics:testDemoDebugUnitTest'.
> There are test sources present and no filters are applied, but the test task did not discover any tests to execute. This is likely due to a misconfiguration. Please check your test configuration. If this is not a misconfiguration, this error can be disabled by setting the 'failOnNoDiscoveredTests' property to false.
We get this because before this change AndroidCompose was always setting
isIncludeAndroidResources = true which generates a source to the test
task and in the case of :core:analytics it is the only source.
Instead of setting isIncludeAndroidResources in AndroidCompose move to
setting it in relevant build.gradle.kts files (most already had it)
11 months ago
Aurimas Liutikas
aa565cba5f
Remove Gradle Isolated Project violation
...
Calls to Project.properties is not Gradle Isolated Projects safe as it
causes Gradle to look through parent projects to find these. Move to
using providers.gradleProperty as that does not have the same behavior.
Test: ./gradlew build --dry-run -Dorg.gradle.unsafe.isolated-projects=true
fewer warnings after the PR
1 year ago
Jaehwa Noh
85cc2921ec
Follow kotlin dsl without type-safe documentation on plugins
...
https://docs.gradle.org/current/userguide/kotlin_dsl.html#ex-configuring-plugins-without-type-safe-accessors
Change-Id: I194844ace17cc2bfa2c80bcc4a338bccfd050a9e
2 years ago
Simon Marquis
e5f1b842ee
Gradle Configuration Cache on CI
...
- https://github.com/gradle/actions/blob/main/docs/setup-gradle.md#saving-configuration-cache-data
- https://docs.gradle.org/current/userguide/configuration_cache.html#config_cache:secrets
And enable parallel Configuration Cache:
- https://docs.gradle.org/current/userguide/configuration_cache.html#config_cache:usage:parallel
This needs a `GRADLE_ENCRYPTION_KEY` secret to be configured in the repository [settings/secrets/actions](https://github.com/android/nowinandroid/settings/secrets/actions ), otherwise no configuration cache will be saved or restored.
As explained in the docs, you can use this tool to generate a configuration-cache compatible key: `openssl rand -base64 16`.
2 years ago
Don Turner
af9631e80c
Merge pull request #1765 from SimonMarquis/patch-5
...
Replace deprecated `stabilityConfigurationFile` with `stabilityConfigurationFiles`
2 years ago
Simon Marquis
042cb7690d
Restore initial function call
2 years ago
Don Turner
992054b35f
Merge pull request #1662 from baksha97/patch-1
...
Fix TODO: Collect all java and kotlin source directories from the variant's source sets
2 years ago
Don Turner
1d67facf6f
Merge pull request #1532 from Jaehwa-Noh/refactor-flavor-diemsion
...
Refactor to improve `FlavorDimension` extensibility
2 years ago
Don Turner
f66fd84f92
Merge pull request #1739 from Jaehwa-Noh/without-type-safe
...
Followed Kotlin DSL without type-safe accessors documentation
2 years ago
Simon Marquis
2a180f9d49
Use lambda syntax
2 years ago
Simon Marquis
454e7b6e64
Replace deprecated `stabilityConfigurationFile` with `stabilityConfigurationFiles`
...
https://kotlinlang.org/api/kotlin-gradle-plugin/compose-compiler-gradle-plugin/org.jetbrains.kotlin.compose.compiler.gradle/-compose-compiler-gradle-plugin-extension/stability-configuration-file.html
2 years ago
Simon Marquis
c54b1dd0cf
Replace deprecated `KotlinTopLevelExtension` with `KotlinBaseExtension`
...
https://kotlinlang.org/docs/compatibility-guide-21.html#deprecate-kotlintoplevelextension-and-kotlintoplevelextensionconfig-interfaces
2 years ago