395b9853df
Add Composition Tracing
...
Change-Id: I3ad60930de2fab71a700a0c2df3f0a1f566cafd8
11 months ago
f5b3ae56dc
Merge pull request #951 from SimonMarquis/issue-945
...
Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`
1 year ago
691bf2aad6
Merge pull request #785 from SimonMarquis/optimize-avd
...
Optimize AVD to fix long vector paths Lint warning
1 year ago
48fde2c3bf
Fix badging after merge
1 year ago
d9d9153eda
Merge branch 'main' into firebase-ktx
1 year ago
afdfd8acc5
🤖 Updates screenshots
1 year ago
377d3bef0c
Optimize AVD to fix long vector paths Lint warning
...
... with SVGOM, but you'll have to check on Android Studio the AVD diff.
https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html
1 year ago
707117a4f2
Merge branch 'main' into kotlinify
1 year ago
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
1 year ago
046831df36
Update dependency guard classpaths
...
Change-Id: I5f729bce92ec1cc9f71e34e42cbe38765966fc31
1 year ago
0699efc592
Merge branch 'main' into issue-945
1 year ago
be9dc533e3
Replace `Enum.values()` with `Enum.entries`
...
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9
1 year ago
a5c030f740
Merge pull request #956 from KDW03/add_saved_test
...
Add Test for Saved Top Level Destination
1 year ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
1 year ago
9d41ffa318
Merge branch 'main' into kotlinify
1 year ago
ad15f0137e
Merge pull request #1094 from lihenggui/main
...
Upgrade Spotless and Ktlint and remove code convention violations
1 year ago
8d5ef578c6
Merge pull request #1103 from android/add_icon_comment
...
Add comment explaining why the launcher icon colors differ per build
1 year ago
b6d82e24df
Merge branch 'main' into kotlinify
1 year ago
b801a7deea
Moving comments to _after_ first XML element
...
Change-Id: Id4271a67ffcfbd712a2dd1f363970fcd31ee5ac0
1 year ago
2a2d8ed88d
Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE
1 year ago
d018e57f52
Fix spotless
...
Change-Id: I5dea4fec5b391e8cb7794af13e99978fcb622fbb
1 year ago
e6b5560f07
Revert "Move app screenshot tests to match dependencies declaration"
1 year ago
28bb3f1b2f
Add comment explaining why the launcher icon colors differ per build variant
...
Change-Id: I30126402370162ccbe53e177652583e4472f2030
1 year ago
83764082ff
Move app screenshot tests to match dependencies declaration
...
Fixes #990
1 year ago
32e1ec0447
Remove violations: property-naming
1 year ago
fb5bd225be
Spotless
1 year ago
2b739c0ffe
Fix badging, which is not "stable" when it comes to ordering
1 year ago
65a8b0d3b5
dependencyGuardBaseline
1 year ago
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
1 year ago
768738350b
Merge branch 'main' into firebase-ktx
1 year ago
32c3c3754d
updateProdReleaseBadging
...
See https://github.com/android/nowinandroid/pull/1006 for these new permissions and "Ad Services" property.
1 year ago
392eaa3e61
Add dependencyGuard to AndroidApplicationConventionPlugin
...
Change-Id: Ib695ca18512d0ccde4c67e101f09ebbff8897912
1 year ago
d15a203c59
Only record prodReleaseRuntimeClasspath configuration
...
Change-Id: I129fc4839ac2b4d5624c91cd25b47efba8847f44
1 year ago
d5d5e3561f
Add dependency guard plugin
1 year ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
1 year ago
988002e692
Update Robolectric 4.11.1
...
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1
> Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below.
Removing explicit API 33 Robolectric configuration.
1 year ago
9c89e98e5b
Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold"
...
This reverts commit 335a7ec68caa8ce0e1f6
1 year ago
f365e8b782
🤖 Updates screenshots
1 year ago
816a7b60c1
Replace manual navigation component switching with new NavigationSuiteScaffold
...
Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723
1 year ago
aa8ce0e1f6
Add automated baseline profile generation ( #880 )
...
Baseline profile generation is disabled for the PR level Build task. Release tasks require a fresh baseline profile. A new profile is generated using the baseline profile Gradle plugin.
* Prepare for usage of dex layout optimizations which can be actively used once NiA switches to AGP 8.2+.
* Add GMD config to release build
* Switch to macos-latest
* Update names for StartupBenchmark tests to better reflect states
* Stable release and recent GMD device
* Reduce flakiness by adding wait to benchmark
* More convenient waiting for objects
* Rename junit dependency to androidx-junit
* Only run baseline profile benchmarks during GH workflow
* Enable automatic BP generation for only release builds
* Disable BP generation from Build workflow
* Specify modules and skip benchmarking Build workflow
Bug: b/299334172
1 year ago
f3b2655e2f
Merge pull request #933 from danysantiago/main
...
Update to Hilt 2.48 and use the KSP version
1 year ago
c908f989c8
Update to Hilt 2.48.1 and use the KSP version
...
* Moved protobuf to separate module to avoid having to wire KSP's Plugin with the Protobuf Plugin.
* `@Binds` function cannot be an extension function.
* Commented `kotlin.compiler.execution.strategy=in-process` in CI to circumvent OOMs due to increased metaspace usage.
1 year ago
3f22248cb7
[CI] Better caching and fewer jobs run
...
* [CI] Runs build in macos to generate a cache for androidTest runs
* Build projects before running emulator
* Fixes flaky coroutines test
* Moves spotless up in local tests job
* Enables config cache by setting problems to warn. Fixes #1022
1 year ago
221b615690
remove ACCESS_ADSERVICES permissions
1 year ago
09304e2477
Add updated badging for prodRelease variant
...
Change-Id: Ibe71c285708ffec85520a0c7852600f361ed1646
1 year ago
360b33eb82
Add automatic checks for badging
...
Change-Id: Ic8fca86d7aa84675fa91fb1aa99abcc6e19d663e
1 year ago
d3d5b02428
Inline color values for app icons
1 year ago
9b83237bfd
Removed Comments
1 year ago
afb427b9c5
Use colors from design palette in build variant icons
1 year ago
38d0c15d33
Create different icons for each build variant
...
Added color values for DEBUG and BENCHMARK build variants.
1 year ago
431069ab77
NiaAppScreenSizesScreenshotTests.kt: Fixes screenshot test showing wrong width ( #986 )
...
* FIxes screenshot test
* 🤖 Updates screenshots
1 year ago
0287af8d9a
Merge pull request #947 from android/tj/staggered-grid-feed
...
Use lazy vertical staggered grid in feed to maximize space utilization
1 year ago
a381d13199
Merge pull request #958 from McGalanes/main
...
Use typesafe project accessors
1 year ago
6247712064
Add convention plugins to version catalogs
1 year ago
b1266dc05a
Use typesafe project accessors for project modules
1 year ago
b2498c763f
🤖 Updates screenshots
1 year ago
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
1 year ago
faf42aa133
Merge remote-tracking branch 'origin/main' into issue-945
1 year ago
bc56ba79bc
Add Test for Saved Top Level Destination
1 year ago
e40fb7925d
Merge pull request #779 from SimonMarquis/java-to-kotlin-sourceset
...
Migrate from `java` to `kotlin` sourceSet directory
1 year ago
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
1 year ago
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
1 year ago
49a2fb5272
Fix wrong configuration name, leaking `work-testing` to runtime classpath
...
Typo introduced recently when Roborazzi was added to the project:
886158d3cb (diff-8cff73265af19c059547b76aca8882cbaa3209291406f52df1dafbbc78e80c46)
1 year ago
03ba943632
Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`
...
- Prevent logging multiple times (because of `onResume()` callback)
- Remove unnecessary io dispatcher: `ListenableFuture<T>.await()` is already main-safe and prevent acquiring io slot.
- Merge comments into a single javadoc comment on the `ProfileVerifierLogger` type.
- Add proper javadoc format with markdown specific blocks.
- Update logs & tag to be more uniform.
Closes #945
1 year ago
151f877bbe
Adds screenshot tests to :core:designsystem ( #931 )
...
* WIP: Adds screenshot tests to :core:designsystem
Change-Id: I0672845feba4064652dd8d60f07047b87864e121
* 🤖 Updates screenshots
* Creates tests for more components and cleans up
Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22
* WIP: More cleanup and more combinations of themes
Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523
* Added the rest of the screenshot tests for designsystem
Change-Id: Ic427db5491910781c038882055524e3f3dbed194
* Some more cleanup
Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180
* Spotless
Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6
* 🤖 Updates screenshots
* ScreenshotHelper cleanup
Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0
1 year ago
851ca6388e
Merge pull request #868 from SimonMarquis/patch-4
...
Handle topic clicks from all destinations
1 year ago
886158d3cb
Adds Screenshot testing with Roborazzi ( #876 )
...
* Adds screenshot tests using Roborazzi (Robolectric Native Graphics)
- Adds Roborazzi to convention plugins
- Adds Screenshot helper in :core-testing
- Creates screenshot suites for :app and :feature-foryou
* CI and spotless
* Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier
* CI: Moves local tests to their own step
* CI: Adds --rerun to screenshot task
* CI: Moves screenshots before local tests
* CI: Fixes wrong if statement in workflow
* CI WIP: trying to trigger the push step
* CI: Re-enables roborazzi verification
* Fixes flaky screenshot tests by setting LocalInspectionMode on
* CI: screenshot commits now use the original author intead of bot account
* CI: Disables globbing because file_pattern didn't work
* CI: Trying new file pattern for png files
* CI: Adds a check for forks
* 🤖 Updates screenshots
* Code review: toml cleanup, comments
* Use new github.event.pull_request.head.repo.fork
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
* Uses Robolectric qualifiers to set the dpi, adds section to README
* Spotless
* Delegates creation of repository to Hilt in test
* Revert "Use new github.event.pull_request.head.repo.fork"
* 🤖 Updates screenshots
* Empty commit to trigger GHA on main branch
* Makes time zones deterministic in screenshot tests
* Increases GMD timeout to 90m, but it has to be reduced
---------
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
1 year ago
e96e54f7de
Merge pull request #806 from SimonMarquis/objenesis
...
Remove forced resolution strategy
1 year ago
b7799f0475
Convert 'sealed' sub-object to 'data object'
1 year ago
a3ee09ec3e
Merge pull request #817 from android/av/enable-edge-to-edge
...
Switch to new Activity.enableEdgeToEdge
1 year ago
d8a6d0de13
Replace NiaNetworkDataSource with TopicsRepository
...
to be closer to the actual source of data used by the instrumented app.
1 year ago
57f3700980
Select last topic by name instead of a random one
1 year ago
64f81751b3
Handle topic clicks from all destinations
...
Closes #865
1 year ago
2b218b97d9
Switch to new Activity.enableEdgeToEdge
...
Change-Id: I9bbb7b2d116099524525619714ef18448e707c4f
1 year ago
0a1f333fc6
Update NavigationTest.kt
1 year ago
bf5fdb4cf8
Update NavigationTest.kt
1 year ago
250850cf9b
Remove hardcoded topic names in `NavigationTest.kt`
1 year ago
654944430d
Fix for Retrofit R8 issue, bump version to 0.1.2
...
Change-Id: Ia90d693731c95248211b12b1ce2e9dfab0ecf34c
1 year ago
56389cb760
Merge pull request #752 from SimonMarquis/kotlin-1.9.0
...
Kotlin 1.9.0
1 year ago
ba82b06cc3
Fix Lint `RememberReturnType` issue with explicit type
1 year ago
7f62b725a6
Bump version to code=7, name=0.1.1
...
Change-Id: I2d8fa940dc5e4c14e3c9df650bc1f1432a330f02
1 year ago
49a3f47fd8
Merge branch 'github/main'
2 years ago
44c3c6d947
Merge branch 'github/main'
2 years ago
04d3da39b9
Merge pull request #809 from SimonMarquis/launcher-icon-dark-theme
...
Extract launcher icon tints and provide `-night` alternatives
2 years ago
e96dac39b2
changed from ListenableFuture.get() to ListenableFuture.await()
2 years ago
78ed9adca2
spotless fix
2 years ago
7b5c0f2be8
Adds ProfileViewer to log the app's Baseline Profile Compilation Status
2 years ago
cf64e25ad5
Extract launcher icon tints and provide `-night` alternatives
...
Implements #805
2 years ago
0a3069a0d8
Remove forced junit resolution strategy
...
By looking at the Gradle scan's dependency tab, junit 4.12 is already replaced by 4.13.2.
There is no need to manually force this at the configuration level.
2 years ago
d332f7b70d
Remove forced objenesis resolution strategy
...
The linked issue is marked as resolved, and not able to reproduce the mentioned compilation error.
2 years ago
8b024f0911
Merge branch 'github/main'
2 years ago
cb84082ae7
Merge branch 'main' into patch/proguard
2 years ago
b434112bf2
Merge branch 'github/main'
2 years ago
7826b4f5f2
Merge pull request #748 from SimonMarquis/fix/permissions
...
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
2 years ago
1c2a833e6c
Merge branch 'github/main'
2 years ago
7b30720b25
Remove nested scaffold from the bookmarks screen
...
Change-Id: Ie8b6f160d341156a6f9c02c0ca7f530095fb2950
2 years ago
a91ba16a9c
Merge branch 'github/main'
2 years ago
479a2f00b0
Refactor icons
2 years ago
9241b06e9f
Merge branch 'github/main'
2 years ago
ded8b109b9
Refactor custom notificationDot modifier
...
Change-Id: Ife24492a495b111f111a8bd16f21b7ebd469e5aa
2 years ago
8f41a6b3ab
Cleanup proguard configuration
...
- Remove custom KotlinX Serialization config as it's already provided, see https://github.com/Kotlin/kotlinx.serialization#android .
- Delete empty config files.
2 years ago
823c4db201
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
...
Continues the work initiated in #738 .
Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.
2 years ago
0c2e01bf4e
Merge branch 'github/main'
2 years ago
fc3d0ced20
Replace hardcoded license file with OSS licenses plugin
...
Change-Id: I4427fd5d7b7abd8a2912a41f61ffedfac4af9d6a
2 years ago
4eaad4c0a6
Merge branch 'github/main'
2 years ago
a68eedebfa
Merge pull request #713 from android/jr/settings-dialog-state
...
Save the showSettingsDialog flag in instance state
2 years ago
62a77321d3
Save the showSettingsDialog flag in instance state
...
This prevents the settings dialog from being dismissed when the device
is rotated.
2 years ago
0829cb73f7
Bump version name to 0.1.0 (versionCode 6)
...
Change-Id: I880683a37b4324f91499eeb47b418ab5e2d1242b
2 years ago
ef97cb941c
Route notification deep link through for you screen
2 years ago
553f55f978
Merge pull request #679 from SimonMarquis/patch-3
...
Simplify String resource loading in `NavigationTest.kt`
2 years ago
1341f7c2c5
Replace unused variable with simpler method calls
2 years ago
1921c6544d
Replace deprecated methods
2 years ago
e1ae12129a
Merge pull request #662 from android/av/agp-8.0
...
Update to AGP 8.0
2 years ago
b3cdc172cd
Implement search feature ( #685 )
...
Implement search feature
- Add a feature module named "search"
- Add a SearchScreen that is navigated by tapping the search icon at the top left corner
- Add a data layer that takes care of populating the *Fts tables and querying them by a search query
- Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen
The SearchScreen has following features:
- The user is able to type the search query in the TextField
- The search result is displayed as the user types
- When the search result is clicked, it navigates to:
- The InterestsScreen when a topic is clicked
- Chrome custom tab with the URL of the clicked news resource
- When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches
- Latest recent searches are displayed in the SearchScreen
2 years ago
3a810f015b
Remove unused variables
2 years ago
091abad348
Simplify String resource loading in NavigationTest.kt
2 years ago
b49767a88c
Rename getUserNewsResources to observeAll
2 years ago
96a0449ba9
Add dontwarn for proguard rules
...
Change-Id: I316513bd13b30cfcdbde0caba1d9c669815601f2
2 years ago
57c13d84bd
Incorporate code review changes: Move UserNewsResourceRepository to data
...
module; move UserNewsResource to model module. Implement unread dot for
bookmarked articles. Keep the flows cold in UserNewsResourceRepository.
2 years ago
ebfbb5bafd
Display unread state on the news feed and bottom nav bar
...
When a news resource is unread, display a dot on its card in the news
feed. When the For You section has unread resources, display a dot on
its icon in the navigation bar.
Update the read status when a resource is opened.
2 years ago
bcd4a6de59
Remove redundant code block for managed virtual device creation
2 years ago
01b5f34eb3
Update to Compose Material 3 1.1.0-alpha06
...
Change-Id: I6399358ad85254243b5aff547e31e3abe92fb6ed
2 years ago
874c2d1487
Merge pull request #561 from SimonMarquis/update/androidx-lifecycle
...
Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05
2 years ago
6a5feb767e
Merge pull request #582 from yschimke/loaders
...
Improve network pooling and avoid startup image fetches.
2 years ago
4d4f7d4a15
Merge remote-tracking branch 'origin/main' into update/androidx-lifecycle
2 years ago
9e399b69ea
Improve network pooling and avoid startup image fetches.
...
Change-Id: If747fb0833d31ce7c9bedffd400160e979bc945e
2 years ago
75f8fc7e08
Bump versionCode to 5
...
Change-Id: I4d6dc6b8d1a903172b7f11ab6166f6c631b1319b
2 years ago
79da80756e
Merge "Remove AD_ID permission" into main
2 years ago
11a4bbaa48
Remove AD_ID permission
...
Change-Id: Iaf691c8ff1e8fbbbcd39b068d8bfdc29c8f6a58c
2 years ago
4284e6912e
Merge remote-tracking branch 'github/main' into feb9automerger
...
* github/main:
Bump version to 4
Remove unused DropdownMenu component
Route topic chip tap events up to NiaNavHost
Apply suggestions from code review
Migrate custom room configuration into a convention plugin
Update docs/ArchitectureLearningJourney.md - User action follow topic
Update docs/ArchitectureLearningJourney.md - Writing data
Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea
2 years ago
d80668407a
Bump version to 4
2 years ago
322ff63dbc
Route topic chip tap events up to NiaNavHost
...
Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7
2 years ago
e3e33d8497
Merge "Add Firebase analytics. See go/nia-firebase-services." into main
2 years ago
2a4d0434a5
Add Firebase analytics. See go/nia-firebase-services.
...
Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689
2 years ago
6a12392f0b
Merge branch 'github/main'
2 years ago
f9a3533df3
Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05
...
> `Transformations` is now written in Kotlin. This is a *source incompatible change* for those classes written in Kotlin that were directly using syntax such as `Transformations.map`
> Kotlin code *must* now use the Kotlin extension method syntax that was previously only available when using `lifecycle-livedata-ktx`.
> The `collectAsStateWithLifecycle()` APIs of `lifecycle-runtime-compose` are no longer in experimental status. (I09d42, b/258835424)
Changelog: https://developer.android.com/jetpack/androidx/releases/lifecycle#2.6.0-alpha05
2 years ago
b72d0fe1af
Fix settings dialog dismissed test on non-portrait phones
...
Change-Id: I15ed475915fdef198029db2713b6f619da374cc7
2 years ago
2bb2d0fb15
Merge branch 'github/main'
2 years ago
9b6695d8dd
Remove unused import
...
Change-Id: I426995db727995c7af6d34082593b078756a3f9d
2 years ago
b4de09d0b2
Use only width to determine navigation UI
...
Change-Id: Icad00b9a3eecac9762f6c6b7c3790e8cf1c161d6
2 years ago
80cb70ae2d
Merge branch 'github/main'
2 years ago
6371cda677
Merge branch 'github/main'
2 years ago
819dd494ad
Run Spotless to add trailing commas (and apply other rule updates)
...
Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209
2 years ago
cfbf782613
Merge pull request #542 from android/as/dynamic-color-option
...
Add dynamic color option in settings for API >=32
2 years ago
8dd9abd6ac
Merge branch 'github/main'
2 years ago
6b48b355cc
Merge branch 'main' into tm/fix-benchmarks-no-people
...
Change-Id: I94ca19fad5527c11a2f0f28cc43a23ab22f419a7
2 years ago
ebb070c73b
Merge branch 'github/main'
2 years ago
46c1d510d4
Android-CI workflow -> GMD refactor ( #537 )
...
This PR is about updating the operating system to macOS-12 as the previous one was going to be deprecated, as well as updating the checkout to v3 to avoid the warnings in the panel; adding setup SDK action to accept the license which was missing from the beginning.
I also added imports instead of adding them directly with the codes.
As a reference, there was another PR with a similar topic, but it wasn't complete: #483
2 years ago
6046f6e943
Add dynamic color option in settings for API >=32
...
Change-Id: Ib42c1cbd0208e98ef7610a1c8aca5d721aa464e6
2 years ago
0aa17b5433
Merge branch 'github/main'
2 years ago
0365658935
Merge pull request #525 from hp902/patch/fix
...
Coil reference url fixed
2 years ago
f316be1d69
Add Firebase dependencies
...
This sets up the project for using Firebase Crashlytics and
Performance Monitoring.
Change-Id: I8d14cfd2e5c2ba1911f2c3175adc20d6714addb6
2 years ago
4633609930
Introduce GMD + ATD ( #479 )
...
Introduce Gradle Managed Device definitions to modules that have instrumented tests.
At the moment, defining it as a convention plugin isn't possible due to the bug. That bug is now fixed and will be included in Android Studio Flamingo.
Once Flamingo becomes stable, convert the GMD definitions as a convention plugin (#523 )
Change-Id: I0866369e3d0bbe148ca5ec1f92bad59239a347b8
2 years ago
c96ff9e3c8
Coil refrence url fixed
2 years ago
43bb4359f5
Revert "Add link of source code in app"
...
This reverts commit 197f4a5157
2 years ago
197f4a5157
Add link of source code in app
2 years ago
f3f01c3d2f
Typo fix for compact
2 years ago
0917cdebec
Refactor NiaGradientBackground to accept GradientColors
...
Change-Id: I55840b22e123490097710570bf11554554df90f9
2 years ago
088a1de92e
Rename to shouldShowGradientBackground
...
Change-Id: I79d4b43354f9da99d91fb21ee84fc084b374f4b8
2 years ago
2fad9fd1e5
Fix background composable
...
Change-Id: I548612191b0b99620777c3e2ad0ace56b228d27d
2 years ago
4e4f48e88c
Change variable name for 'not connected' message
2 years ago
a1d47d5418
Center title bar when nav rail is visible
...
Change-Id: I341833b71504462fdbfbe5073a2465be2af95fda
2 years ago
1b9ed220be
Regenerate profile without people
...
Change-Id: Ia412617ac2e4212b7b9b3a3fa6f39541e53584c4
2 years ago
4ba63c0de8
Remove author concept from app
...
Change-Id: Icd03c0288ba5f3f23dbcbdbefbbe802db2815793
2 years ago
56b3c1d0b9
Merge pull request #468 from android/remove-stream-suffixes
...
Remove `Stream` suffixes
2 years ago
e6c53a8aaa
Update baseline profile
...
Change-Id: Ida83e612d5595ea1d43f9105ac7e76f7db2f6caa
2 years ago
9c22a7a4e7
Remove `Stream` suffixes
...
Change-Id: I45decae965d7e35289d3fa31fc58b8c463fbead1
2 years ago
465d9aae06
Fix spotless
...
Change-Id: Ib46c68c765342d8c172cf2f224bb7f885803b483
2 years ago
369cd33b7a
Add accompanist/testharness
...
Adds a usage of accompanist/testharnness to force a given DpSize for its content, overriding the density if necessary to ensure that the size is achieved. This allows testing UI at arbitrary sizes on arbitrary emulators, lessening the need for using multiple emulators at different sizes (and filtering tests) when Android-specific window size has been hoisted appropriately.
The initial test using it is a test for checking whether or not the navigation bar or navigation rail is being shown, and these tests can run on any emulator.
Change-Id: I315384e5eafac23a3cd6d3818d9828f6d3c1acfc
2 years ago
b425f9560d
Merge pull request #458 from android/tm/fix-benchmarks
...
Fix benchmarks
2 years ago
7db33aa041
Refactor naming according to convention
...
Change-Id: Id74e2495d5909e4978247e0d7edfb5621b2064ff
2 years ago
867cc549cd
Update BLP
2 years ago
22b8f782eb
Make functions 'shouldUseDarkTheme' and 'shouldUseDarkTheme' private
2 years ago
eea70382d6
Fix code style
2 years ago
7ebc718ca0
Enable R8
2 years ago
6c1f8394d9
Fix flavors change
2 years ago
fe32e90cdd
Merge pull request #412 from SimonMarquis/patch-2
...
Remove test dependency from `implementation` configuration, fixes #411
2 years ago
06dac236fe
Merge pull request #420 from SimonMarquis/patch/kotlin-test
...
Migrate from JUnit assertions to Kotlin's test framework
2 years ago
df6207122d
Merge pull request #326 from MaximillianLeonov/redundant-label-on-activity
...
Remove redundant label on activity
2 years ago
c7859d3c3c
Merge pull request #324 from MaximillianLeonov/unused-color-resources
...
Remove redundant unused color resources
2 years ago
90dc300783
Migrate from JUnit assertions to Kotlin's test framework
...
Fixes #419
2 years ago
18e58678e3
Merge branch 'android:main' into patch-2
2 years ago
e050c22c88
Remove test dependency from `implementation` configuration, fixes #411
2 years ago
d616bf3a42
New version to trigger new build on server
...
Change-Id: I19e606f29c4d7449c09184282ba1e646ead52517
2 years ago
de403be3c4
Update app version
2 years ago
a9aa3eafab
Add data from the last 10 episodes
2 years ago
0171971dc7
Merge pull request #316 from android/bw/gradleCleanup
...
Update Baseline Profile generation
2 years ago
3ab6002531
New baseline profile
...
Change-Id: I8a20ab2f44b198afaf57f26d1bee20054ed1ce6d
2 years ago
de893cbad7
Resolves #206 , enables predictive back navigation support
2 years ago
505187482b
Add workaround for top app bar overlapping nav rail
2 years ago
1c6c812b76
Update app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
2 years ago
dbff140b64
Fix minor issues
2 years ago
e5183e21e0
Resolve conflict with navigation changes from main
2 years ago
76daa393b1
Address review feedback from Manu
2 years ago
0d5dd944ea
Fix getter for settings dialog state
2 years ago
828242dbad
Remove Scaffold from top level screens
2 years ago
f59da72383
Add comment about splashScreen.setKeepOnScreenCondition
2 years ago
5e4100fafc
Add MainActivity view model
2 years ago
c3f7870412
Fix spotless issues
2 years ago
56c0645816
Add tests
2 years ago
d42881e5d4
Add UI architecture for Settings dialog
2 years ago
8c30ab9f80
Add settings module, refactor top bar
2 years ago
b7500ea09b
Fix typo
2 years ago
add486a0ab
Fix spotless issues
2 years ago
7e3faad699
Add data logic for theme switcher
...
Change-Id: Ifffadb897de4f6e08f7115103f99c156a7098b70
2 years ago
a0b22d8ed2
Updates Navigation approach with new guidance ( #347 )
2 years ago
7e6cb46436
Merge pull request #328 from android/bw/moreJankstats
...
Add more jank tracking
2 years ago
ee2e3db928
Add more jank tracking
2 years ago
dcc23829d4
Migrate packages to namespaces in build files
...
Change-Id: I21e021caa0ea72a7097dfd9af04a3c07a0cc9aa5
2 years ago
348e2cc6f4
Shorten navigation trace, fixes #271
...
Change-Id: I4b33800a538b13996fc68b48854be56251a9db2c
2 years ago
f16b698ba6
Remove redundant label on activity
2 years ago
73a9960cbd
Remove redundant unused color resources
2 years ago
6351a89545
Merge pull request #310 from android/documentation/dep_graphs
...
Add dependency graphs to every module
2 years ago
c4debb74e7
Give feedback when syncing on ForYouScreen
...
Change-Id: I10a646e8a17f81d96351e69d36f0cb6ccf28e05c
2 years ago
06e60063b5
Add dependency graphs to every module
...
Change-Id: I629fef818f7521c13bb3069a3ff9ed9bc42e57f3
2 years ago
9be6e846d9
Apply spotless
...
Change-Id: I49eeb1984cb3e978a9cee5c1e4d53e856a10bb4e
2 years ago
738210166a
Refine backgrounds and navigation colors
...
Change-Id: I9fd863cc608f21078ab78c39c2c3d227aedbac7c
2 years ago
8c11769622
Update to material3 1.0.0-beta03 wih built-in insets support
...
Change-Id: I4d07f89d4faa6e3417468ad78acf3fbb161f0797
2 years ago
4683918cc7
Move spotless to init script
...
Also adds automatic git hooks installation
Change-Id: I18debbee43af27db7b95a4202f824fa87e186713
2 years ago
d0cff2b11c
Build cleanup
...
* Move Hilt setup to convention plugin
* Disable Hilt on modules where it's not needed
* Enable non-transitive R classes
* Fix `configuration` blocks called in wrong scope
* Move imperative Flavors code from build.gradle
* Disable unnecessary build features globally
* Disable configure-on-demand as it's not encouraged
* Don't use internal AGP packages in plugins
Change-Id: I1bee3e3fd0103054637b979a350f9fd2312ae8ba
2 years ago
d6555cbaa5
Merge pull request #269 from android/av/compose-tracing
...
Update Kotlin, Compose and add in the new runtime-tracing artifact
2 years ago
a60687ae73
Update Kotlin, Compose and add runtime-tracing
...
Change-Id: I1697541a70a47281424fa51dfe5cab78bf89a1f6
2 years ago
c35699280e
Move 'feature-' module to feature subfolder
2 years ago
3bd81154b5
Move 'core-' module to core subfolder
2 years ago
a37c06db10
Merge pull request #231 from android/jv/app-icon
...
Update app icon using Image Asset Studio
2 years ago
bcdc906f3a
Add round icon again for API 25.
2 years ago
f00cae012f
Add monochrome to v26 app icon, remove round icon (as per documentation: You may also define an icon drawable resource using the android:roundIcon attribute—but only if you require a different icon asset for circular masks, for example in a case where your branding relies on a circular shape.)
2 years ago
73cd535695
Fix dark mode system icons
...
Change-Id: I8af3435d2b83ebbd55b8adaa3f2066fbe2d22fa5
2 years ago
f851141b0d
Add v33 launcher icon with support for adaptive icons
2 years ago
152d571847
Update app icon using Image Asset Studio
...
Change-Id: I9eb8281abbb59da0b653dbe6c36786c90d330556
2 years ago
e0687e9aae
Merge pull request #217 from android/av/splash-screen
...
Removes non-Compose Material library and adds splash screen
2 years ago
200aede1c7
Rename NightAdjusted.Splash to NightAdjusted.Theme.Splash
...
Change-Id: I2493c664945d3cfbe1c52397133fdc955265ac56
2 years ago
8587ae8ee6
Merge pull request #219 from android/bw/metricsUpdate
...
Update JankStats to 1.0.0-alpha03
2 years ago
6dc17126da
Update JankStats to 1.0.0-alpha03
...
Accomodating API changes along the way.
2 years ago
063965c9cd
Add splashscreen integration
...
Change-Id: I1fbc5b7e663497ae52759afb7bcd6169c5987ce6
2 years ago
4523129fd4
Remove non-Compose material
...
Change-Id: I62a639b6c12e7d523c3dc5ad0766f180120d9e92
2 years ago
40cf1b8171
[NiA] Implement LazyVerticalGrid for Feed
...
Change-Id: I0fd51bdd4c64a3d9ceaba05244d384bb9b463315
2 years ago
37ad3e6299
Merge remote-tracking branch 'github/main' into jul22automerger
...
Change-Id: Ic54190a9d825ae9649d34a4e2bd9c83855511b71
2 years ago
ea07e97a07
Add more KDocs and nav args encoding
2 years ago
872a7a6523
Make the state holder stable
2 years ago
0eee3620b8
Add state holder for NiaApp composable
2 years ago
34411e3f70
Merge remote-tracking branch 'github/main'
...
* github/main: (21 commits)
Add stacktrace for test command
Add TODO comment with bug
Update Compose compiler to 1.2.0, Kotlin to 1.7.0
Consistent tags & named parameter usage
Address review comments
Remove redundant dependency
Fix spotless
Move JankStats metric gathering further down
Add ForYou TopicSelection scrolling state
Add ForYou feed scrolling state
Add JankMetricDisposableEffect
Add AuthorsCarousel scrolling state
Add JankMetricEffect
Remove InterestItem state
Use DisposableEffect + rememberMetricsStateHolder for Interests tab selection
Use rememberMetricsStateHolder for navigation
Add rememberMetricsStateHolder composable
Introduce view extension to track jank
Inject JankStats with Hilt
Add jankStats and rudamentary jank logging
...
Change-Id: I1ff0fb3ccb7d6082c17c6e69f5d9ea9cabe1d733
2 years ago
c4110e33c6
[NiA] Add Saved functionality
...
Change-Id: I38320a16999d063a023bbe9d329a275af4e78b1e
2 years ago
efb76d4941
Merge branch 'main' into bw/initialMetrics
2 years ago
9f929944d0
Address review comments
...
* Introduce gradle plugin for firebase perf
* Create TrackScrollJank composable to mask tracking code
2 years ago
c3ca38d31d
Remove redundant dependency
3 years ago
6509b6ac9d
Merge branch 'main' into bw/initialMetrics
3 years ago
a4e7488888
Update baseline profile
...
Contains CUJs:
- scrolling for you feed
- scrolling interests topics
- scrolling interests people
Change-Id: Iad124aafae9858b2922dcfa49302fe1f8aacae48
3 years ago
b2569c1576
Add testTag to access composables from UiAutomator
...
Change-Id: I5125cae0778151b11868b72f74f74f979774625c
3 years ago
2407a1d4b4
Fix debuggable build types
...
Change-Id: Ie3ecf462cac81bd462c48ad161521b18836325b9
3 years ago
90480286c9
Merge pull request #68 from RivanParmar/main
...
Fix Navigation Bar in landscape mode.
3 years ago
d05b573f52
Improve design system usage and add lint checks
...
Change-Id: I05f9400a9410e31bdf1534e458d560fe793b809f
3 years ago
334a6d07b3
Fix SpotlessApply.
3 years ago
fa16a25ac8
Merge branch 'main' into bw/initialMetrics
3 years ago
09e0aed124
Merge branch 'android:main' into main
3 years ago
22c5668133
Update dependency org.objenesis:objenesis to v3
3 years ago
2f35893b2e
Merge remote-tracking branch 'github/main'
...
Change-Id: I8706d94ba2850646218fc982719c99991d93f34c
3 years ago
42878c5e86
Move JankStats metric gathering further down
...
This isn't the thing a developer should be focusing on when first
opening the file. So moving it further down in the composable.
3 years ago
da79a98876
Update baseline profile and generation logic ( #61 )
3 years ago
e949749073
Merge branch 'bw/initialMetrics' of github.com:android/nowinandroid into bw/initialMetrics
3 years ago
747416ad84
Fix Navigation Bar in landscape mode.
3 years ago
5032136784
Fix Navigation Bar in landscape mode.
3 years ago
eb1973052d
Add demo and prod product flavors. Remove staging variant.
...
Change-Id: I7d251d477ef1ee770096b9971099e0bf59cfa6ea
3 years ago
b602abc263
Merge pull request #56 from sud007/fix/nia-naming-convention
...
Fix Bug #41 | Nia Naming conventions
3 years ago
bc7270d6c4
Add JankMetricDisposableEffect
...
Change-Id: Idcab0faa2e9b4cc9986064f45217cab101843697
3 years ago
a076a50010
Use rememberMetricsStateHolder for navigation
...
Change-Id: I3b038a9bbc6eed9b21343aa0fd75c044049386a4
3 years ago
58fd7dcec0
Merge branch 'github/main'
3 years ago
ea1114a337
Fix Bug #41
...
Fix bug #41 Made Naming Convention symmetrical. as 'Nia' instead of 'NiA' as that sounds more subtle and easy to follow in camel-case notation based Naming
3 years ago
7813757393
Remove ClearRippleTheme CompositionLocal from NavigationBar
...
Fixes #36
3 years ago
a37c932898
Introduce view extension to track jank
3 years ago
895ec4c337
Inject JankStats with Hilt
3 years ago
4f57975657
Add jankStats and rudamentary jank logging
3 years ago
103398682a
Add tracing library and start using it
...
Currently tracing sync and main navigation.
3 years ago
3a43928ef1
Merge branch 'github/main'
3 years ago
f74103c804
Merge pull request #44 from serbelga/fix_themed_app_icon_round
...
Fix themed app icon launcher roundIcon
3 years ago
9f10b5c4c6
Add cutout version of ic_launcher_foreground for drawable-v24 in app module in order to distinguish it from the nia-app-catalog version
3 years ago
72278b8cef
Add monochrome attribute to ic_launcher_round.xml in :app and :app-nia-catalog
3 years ago
1475e3e8f9
Fix nested navigation graphs
...
Change-Id: I2c3ad0a0f6c132230b821d3621389913cf37247c
3 years ago
0651d9dde6
Update benchmarking & baseline profiles
...
Uses newest versions from I/O release
Also updates baseline profile to match latest changes
Change-Id: I83c709338ea37d2187d1e8437f5b5d8e98a42f22
3 years ago
febbd26261
Refactor navigation
...
Change-Id: I3501446e73976f3872592038501fcef8c8324f74
3 years ago
52b771a8b5
Update baseline profile
...
Change-Id: I6b69df704e14ba9568494d773690a1121226273e
3 years ago
9bb7f9d8a7
Add staging build variant, move staging URL out of source control
...
Change-Id: I9388f8d2adc4800749fc7e5e79c2d165938401c4
3 years ago
d945a007c6
Add AuthorScreen and corresponding components
...
Change-Id: Iee5e8bd0932d1b68770aaa1e23fa660451109601
3 years ago
dc4af7e6f7
Rename following to interests
...
Change-Id: Iabcb8b495717e0cb3a993ecc0e09e3338fe5140f
3 years ago
ce0142b98a
Add gradient background to For You Screen
...
Change-Id: I6a85ee82a78b1897020f1737503611bd100764a1
3 years ago
cce9402b04
Add multi-column support for cards on the for you feed
...
Fixes: 228074722
Change-Id: Id077b4dd93452b5f9399f94161c9b66594436975
3 years ago
203c8e1ceb
Configure spotless for kts and xml files
...
Fixes: 230874524
Change-Id: I147b9f16d5424b3459435e3c5422867b40c480b7
3 years ago
7968a70398
Rename core-domain to core-data
...
Change-Id: Ief2eef982c9ebe4be729bee1d2f59e2ab8b1f911
3 years ago
f84320e9a9
Fix large screen insets handling
...
Bug: 228374243
Change-Id: I2a7af72e60450be3280872b46bd84eb1079b533d
3 years ago
643b230187
Converted model ids from ints to strings
...
Change-Id: Iad07926e04113bcd2c6d9e06e5e2a4e802a79b80
3 years ago
b677cc4508
Convert all build files to kts
...
Change-Id: I26bf730ee51f62cbd604c02b628c1f277cfceb72
3 years ago
7ac15771b3
Update to Kotlin 1.6.20 and using material3-window-size-class
...
Change-Id: I30bc9f729ab91f007de530af3a12b281430ac1cb
3 years ago
bcf05f5502
Remove material non-3 components
...
Bug: 228974929
Change-Id: Ie74189bd6ce1a4a2ece36962e0ad1627ac9c71dd
3 years ago
3558a6931e
Add People to interests screen
...
Screenshot: https://screenshot.googleplex.com/3XqkTwJQwgfoPsT
Change-Id: Iac7dc06c84523b4db8d05f538b74a08741d2c347
3 years ago
ca73f5598f
Setup convention plugins base
...
Change-Id: I66ea3a5c95ca9d87a1f0da39b6ba72faffc320ed
3 years ago
553d152844
Adds topic screen
...
Bug: 213876743
Tests: Local + UI tests + Navigation test
Change-Id: I6c521695d6b777084a6255c6d62623a4def83063
3 years ago
9ebea8ad29
Improving For You onboaring [ http://b/223204846 ]
...
Test: updated tests that were failing in firebase testlab due to the UI change.
Change-Id: If892a7a81eecc69bf71f41d75c11af363903f962
3 years ago
ab7b25ef6a
Add new fields to Topic and display SVG icon.
...
This CL makes the following changes to the Topic model:
Renamed description -> shortDescription
Added longDescription, url and imageUrl (this is the URL of the icon)
This makes the model of Topic in the app match the model in the back end.
The icon (an SVG file) for each topic is displayed in the Topic list UI.
Change-Id: Ibbb35c8be879ae4d6e45b69fa0eafa88f3537052
3 years ago
2b2bd496e0
Added launcher icons
...
Change-Id: I2c7fbfd36d91866956d7787e547affe1b90f4fbc
3 years ago
ccb822286f
Integrate WorkManager (WIP)
...
Change-Id: Iedf81220336911ab3ed6ea4ca71b10f07e645bc9
3 years ago
Tomáš Mlynarič
Don Turner
Simon Marquis
SimonMarquis
Don Turner
lihenggui
Jonathan Koren
Miłosz Moczkowski
mmoczkowski
Ben Weiss
Daniel Santiago
Jose Alcérreca
rosariopf
Alex Vanyo
TM
Adetunji Dahunsi
Melwin Magalhaes
Simon Marquis
kimdowoo
Márton Braun
Automerger
Murat Yener
James Rose
TJ Dahunsi
Takeshi Hagikura
AlfianHanantio
Caren
Yuri Schimke
Angie Sasmita
Mohsen Rzna
Ben Weiss
Harshit Pandey
Muhammad Anas Shamsi
Jolanda Verhoef
Masood Fallahpoor
Yura Laguta
Manuel Vivo
Wojtek Kaliciński
Maximillian Leonov
madroid
Nick Rout
Rivan
Rivan Parmar
Renovate Bot
kbuilder
Sudhanshu
Sergio Belda
Simona Stojanovic
Jose Alcérreca
Ran Nachmany