287 Commits (ja/restore-foryou-st)

Author	SHA1	Message	Date
Jose Alcérreca	90ac21ca54	Restores screenshot tests in foryou ... Change-Id: If42e15eb06c79b22ab89a27ab36de9aedcda6c6b	5 months ago
Don Turner	707117a4f2	Merge branch 'main' into kotlinify	7 months ago
Don Turner	0f0511748e	Merge pull request #1088 from SimonMarquis/cleanup-dependencies ... Reduce overall build complexity	7 months ago
Simon Marquis	b043d8db86	Replace workaround on SettingsViewModel now that a fix has been deployed ... The issue has been addressed in `androidx.compose.ui:ui:1.5.0`.	7 months ago
Don Turner	89d39a7242	Merge pull request #767 from SimonMarquis/resource-prefix ... Enforce `resourcePrefix` on Android library modules	7 months ago
Simon Marquis	cd62fd5e01	Update feature/search/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/search/navigation/SearchNavigation.kt	7 months ago
Simon Marquis	b7a628ece5	Update feature/interests/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/interests/navigation/InterestsNavigation.kt	7 months ago
Simon Marquis	6cd5958665	Update feature/bookmarks/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/bookmarks/navigation/BookmarksNavigation.kt	7 months ago
Simon Marquis	65f0d5b2d9	Update feature/foryou/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/foryou/navigation/ForYouNavigation.kt	7 months ago
Don Turner	9d41ffa318	Merge branch 'main' into kotlinify	7 months ago
Simon Marquis	b6d82e24df	Merge branch 'main' into kotlinify	7 months ago
lihenggui	2a2d8ed88d	Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE	7 months ago
lihenggui	32e1ec0447	Remove violations: property-naming	7 months ago
lihenggui	f8f932705a	Remove violations: discouraged-comment-location	7 months ago
lihenggui	fb5bd225be	Spotless	7 months ago
Simon Marquis	f27a2e176e	Reduce overall build complexity ... - Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces - Correctly configure the visibility of dependencies: - `api` when it's part of it's public `api` - `implementation` when it's part of it's internal `implementation` - Remove unnecessary dependencies in build.gradle.kts files - Remove unnecessary dependencies provided by plugins - Remove unnecessary applied plugins (i.e. roborazzi) - Sort dependencies in `build.gradle.kts` - Delete unused entries in `libs.versions.toml`	7 months ago
Simon Marquis	caa482bc71	Kotlinify codebase ... - Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)	8 months ago
Simon Marquis	988002e692	Update Robolectric 4.11.1 ... - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11 - https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1 > Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below. Removing explicit API 33 Robolectric configuration.	8 months ago
Miłosz Moczkowski	9c89e98e5b	Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold" ... This reverts commit 335a7ec68c, reversing changes made to aa8ce0e1f6.	8 months ago
Miłosz Moczkowski	816a7b60c1	Replace manual navigation component switching with new NavigationSuiteScaffold ... Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723	8 months ago
kimdowoo	129099e219	refactor/Convert object to data object in sealed interface	9 months ago
Adetunji Dahunsi	0287af8d9a	Merge pull request #947 from android/tj/staggered-grid-feed ... Use lazy vertical staggered grid in feed to maximize space utilization	9 months ago
Don Turner	a381d13199	Merge pull request #958 from McGalanes/main ... Use typesafe project accessors	9 months ago
Melwin Magalhaes	6247712064	Add convention plugins to version catalogs	10 months ago
Melwin Magalhaes	b1266dc05a	Use typesafe project accessors for project modules	10 months ago
tunjid	b2498c763f	🤖 Updates screenshots	10 months ago
dahunsi	03d2455f41	Use lazy vertical staggered grid in feed to maximize space utilization ... Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926	10 months ago
Simon Marquis	b2cd980170	Merge remote-tracking branch 'origin/main' into resource-prefix	10 months ago
Simon Marquis	ebfe01affd	Enforce `resourcePrefix` on Android library modules ... ``` :ui-test-hilt-manifest -> ui_test_hilt_manifest_ :core:analytics -> core_analytics_ :core:common -> core_common_ :core:data -> core_data_ :core:data-test -> core_data_test_ :core:database -> core_database_ :core:datastore -> core_datastore_ :core:datastore-test -> core_datastore_test_ :core:designsystem -> core_designsystem_ :core:domain -> core_domain_ :core:network -> core_network_ :core:notifications -> core_notifications_ :core:testing -> core_testing_ :core:ui -> core_ui_ :feature:bookmarks -> feature_bookmarks_ :feature:foryou -> feature_foryou_ :feature:interests -> feature_interests_ :feature:search -> feature_search_ :feature:settings -> feature_settings_ :feature:topic -> feature_topic_ :sync:sync-test -> sync_test_ :sync:work -> sync_work_ ```	10 months ago
Simon Marquis	a33dafccad	Migrate from `java` to `kotlin` sourceSet directory	10 months ago
Roy Matero	298f3ce4db	Merge branch 'android:main' into main	11 months ago
Jose Alcérreca	5b79869324	Adds dark screenshot tests and fixes background colors in ForYou (#918) ... * Adds dark screenshot tests and fixes background colors in ForYou * 🤖 Updates screenshots	11 months ago
Roy Matero	4e6cda1965	Renamed toggle function signature with boolean parameters ... Change-Id: I0d6c0ed4d4c0ee4bd387e5645fc558970f5f202b	11 months ago
Jose Alcérreca	886158d3cb	Adds Screenshot testing with Roborazzi (#876) ... * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	11 months ago
Adetunji Dahunsi	4716c7f841	Merge pull request #913 from hoangchungk53qx1/main ... Refactor Search Feature	11 months ago
hoangchungk53qx1	66eafdc38b	format modification for screen search	11 months ago
Milosz Moczkowski	b6459d41ee	Merge pull request #834 from takahirom/takahirom/rename-topicBody/2023-07-13 ... Rename LazyListScope.TopicBody LazyListScope.topicBody	11 months ago
Milosz Moczkowski	374808c284	Merge pull request #847 from SilviaGarciaBouza/wrong_color_in_dark_mode ... Added TextStyle color for ClickableText	11 months ago
hoangchungk53qx1	70498dd6e3	separate function logEvent for search triggered	11 months ago
hoangchungk53qx1	9cb20db93a	separate function logEvent for search triggered	11 months ago
hoangchungk53qx1	c52c4b88cd	replace object with data object in search feature, simple format code for the reader	11 months ago
hoangchungk53qx1	cd30ecf359	replace object with data object in search feature, simple format code for the reader	11 months ago
Milosz Moczkowski	89a1294c63	Merge branch 'main' into takahirom/rename-topicBody/2023-07-13	11 months ago
Simon Marquis	daa2228132	Restore original `type` labels	11 months ago
Simon Marquis	0377fd8712	Replace `NewsResourceType` enum with simpler String type ... See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901	11 months ago
Adetunji Dahunsi	153b34fd50	Merge pull request #850 from qamarelsafadi/loading-progress-for-image ... Fix #849: Loading progress for image	11 months ago
Don Turner	492697ce6b	Merge pull request #873 from SimonMarquis/misc-warnings ... Fix miscellaneous warnings	11 months ago
Qamar A. Safadi	2db3e0c804	Merge branch 'android:main' into loading-progress-for-image	11 months ago
Don Turner	8901e5932a	Merge pull request #872 from SimonMarquis/data-objects ... Convert 'sealed' sub-object to 'data object'	11 months ago
Don Turner	0e13207a40	Merge pull request #874 from SimonMarquis/string-decoder ... Replace StringDecoder injection with simpler API	11 months ago