c54b1dd0cf
Replace deprecated `KotlinTopLevelExtension` with `KotlinBaseExtension`
...
https://kotlinlang.org/docs/compatibility-guide-21.html#deprecate-kotlintoplevelextension-and-kotlintoplevelextensionconfig-interfaces
2 years ago
e4681fce31
Add androidx.lint:lint-gradle to build-logic
...
Change-Id: I95a0e1f5ae5d78d3725ab20031fe268515a50153
2 years ago
cf2db95db0
Restore into a plain String text.
...
Change-Id: I3f4ead0be88ed460de007dae7b53c4d2f6c2249b
2 years ago
f422b8539e
Remove StringSources.kt
...
Change-Id: I17972f94277364cd588f40d422370b21e40af0e9
2 years ago
f925bfc01c
fix: remove operator fun for simplicity
2 years ago
4277366b7c
Merge pull request #1729 from takahirom/takahirom/update-sdk-35/2024-12-11
...
Update SDK 35 with Theme Fixing
2 years ago
665fe9ff4a
Merge pull request #1528 from davidburstrom/main-single-source-of-plugin-ids
...
Use the version catalog as the source of truth for plugin IDs
2 years ago
3271208515
ergonomics
2 years ago
192a3a6e8a
rename fun
2 years ago
7d45a7c179
fix: rename
2 years ago
ffcd7d9581
fix: code cleanup
2 years ago
27f548fec5
fix: lazy query for task
2 years ago
f1bfe34786
nullability
2 years ago
c4cb8bc407
fix: compiler error
2 years ago
18e35c27f6
Followed Kotlin DSL without type-safe accessors.
...
https://docs.gradle.org/current/userguide/kotlin_dsl.html#ex-configuring-plugins-without-type-safe-accessors
Change-Id: Id711ad25146e291cbae40a5df4251f0ffef7b0a6
2 years ago
3009cdf081
Create Const value of `String`.
...
Change-Id: I8fa1a79ea71578395a4ce861ff883f8f6f01cdd0
2 years ago
b2b32e3ae7
Replace aapt2 executable with lazy property
...
Fixes #1677
Change-Id: Ic3ff5d8d54c607444c64fcd60671092344a726d7
2 years ago
6a49ba5fda
Use the version catalog as the source of truth for plugin IDs
...
The IDs stated in the build-logic build script must exactly match the plugin
IDs in the version catalog file. This solution reduces the inherent
duplication.
To avoid any IDE errors about missing plugin accessors when adding new plugins
to the build-logic script, it's recommended to add the new ID in the version
catalog first, then invoke Gradle (sync) in order to generate the accessor
classes.
2 years ago
9e42080bf5
Disable `GradleDependency` Lint warning
...
See #921
2 years ago
57d98cc2e2
Merge pull request #921 from SimonMarquis/sarif
...
Enable SARIF support on GitHub Actions
2 years ago
81e7ef0a05
Replace Annotation to compiler args. ( #1602 )
...
Change-Id: I691fc0f14d4bb2c62224dc77a5d0f3a08b59a75b
2 years ago
e0f30acddd
Target SDK 35
2 years ago
4a0723441f
Dependency version upgrades, not API 35 yet ( #1719 )
...
* Update screenshots
Change-Id: Ibed7889a3389ab6044e00a185158f36ce857b6b2
* Dependency version upgrades
Change-Id: Ib4a1f9bef1dd3e1736907479125d0abb5b22e9bd
* Address review comments
Change-Id: Ia2c6a52e289285a7a78336fa4250fa6a04ccb5c4
* 🤖 Updates baselines for Dependency Guard
* 🤖 Updates screenshots
2 years ago
085347e5e2
Merge branch 'main' into sarif
2 years ago
ab87857c9b
[Refactor]: Replace enableAndroidTest with androidTest.enable ( #1274 )
...
This is because enableAndroidTest is deprecated.
Fixes #1272
2 years ago
55dbe61c65
Optimize google maven downloading ( #1051 )
2 years ago
1d659b0eea
Replace kotlin("test") to version catalog `kotlin.test`.
...
Change-Id: Ifd7de5dda724102063a9df660cacc6d6b16699e0
2 years ago
6bb75909fe
Merge pull request #1667 from SimonMarquis/patch-2
...
[Fix] Add missing unit test dependency for JVM modules
2 years ago
489aebf629
Fix duplicated implementation of hilt. ( #1570 )
...
Change-Id: I82c2e06b594297cdae7009ee5e87162d0295eb7c
2 years ago
eae51a6df9
[Fix] Add missing unit test dependency for JVM modules
...
`:core:common` module would not be able to run its unit test: `:core:common:test`
Related to: #1546
2 years ago
8b199c134d
Update Jacoco.kt
2 years ago
20a42241e7
Use invariant locale when capitalizing Gradle task names
2 years ago
5a382e3a45
Merge pull request #1593 from Jaehwa-Noh/remove-enable-strong-skip
...
Remove deprecated enableStrongSkippingMode
2 years ago
206d2c42d0
Merge pull request #1547 from SimonMarquis/gradle-8.9
...
Update Gradle Wrapper from 8.7 to 8.10
2 years ago
cc15e40877
Remove enableStrongSkippingMode.
...
https://kotlinlang.org/docs/whatsnew2020.html#strong-skipping-mode-enabled-by-default
Change-Id: I7b97ba1e593e7e852d690f59d59dd94d0107743f
2 years ago
00efda54e8
Merge branch 'main' into dt/nav-safe-args
...
* main: (58 commits)
Instrumented tests for InterestsListDetailScreen (#1518 )
Remove Firebase AD_SERVICE_CONFIG property
updateProdReleaseBadging
Merge Android & JVM plugins into a single `HiltConventionPlugin`
Update dependency guard
🤖 Updates baselines for Dependency Guard
Update to Lifecycle 2.8.3
Add android.adservices.AD_SERVICES_CONFIG to badges
Apply suggestions from code review
Update app/src/main/AndroidManifest.xml
generateModuleGraphs
dependencyGuardBaseline
updateProdReleaseBadging
Fix spotless.
Change set to `=` operator
Cleanup unused reference in `libs.versions.toml`
Regenerate SVG graphs
Update comment wording
Use stdin to avoid repeating the output file name
Replace bash commands with proper svgo cli
...
Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5
2 years ago
cf0e6d0e5c
Replace internal `capitalized` extension
...
'capitalized(): String' is deprecated. This was never intended as a public API.
2 years ago
ba5edc5014
Add explicit variable name in lambda based on Type name.
...
Change-Id: Ife739bcebb9b2586a6045ddac241f1591927c4b6
2 years ago
65d7e4519e
Refactor to improve `FlavorDimension` extensibility, and replace to `register` lazy api.
...
Change-Id: I6e2980f19da5a6e22a7773c84493424663e33fc4
2 years ago
d56e06e676
Merge Android & JVM plugins into a single `HiltConventionPlugin`
2 years ago
e71ce1fc00
Merge remote-tracking branch 'origin/main' into jvm-alt
2 years ago
1c5513283a
Merge remote-tracking branch 'origin/main' into fix/1161-2
2 years ago
3dbca86a37
Merge remote-tracking branch 'origin/main' into jvm-alt
2 years ago
5a1529ee0c
Fix spotless.
...
Change-Id: Ib610c17b717305f186982679ddd35be74cf3791f
2 years ago
249d784ea1
Change set to `=` operator
...
lazy property assignment.
https://docs.gradle.org/current/userguide/kotlin_dsl.html#kotdsl:assignment
Change-Id: Ibe483324ddc8e4765ed4295e40f2e1483c835f20
2 years ago
a6397b7d82
Merge branch 'main' into dt/nav-safe-args
...
* main:
Kotlin 2.0.0 (#1036 )
Update app/src/main/kotlin/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
🤖 Updates screenshots
🤖 Updates baselines for Dependency Guard
Update material3-adaptive to beta01
🤖 Updates baselines for Dependency Guard
Bump androidxComposeAlpha from 1.7.0-alpha08 to 1.7.0-beta01
🤖 Updates baselines for Dependency Guard
Bump hilt from 2.51 to 2.51.1
Add NavigationSuiteScaffold
Fix state loss with workaround
Change-Id: I14d7294fe93f68b9aca6df9bf7bf87ff95583581
2 years ago
85129e4660
Kotlin 2.0.0 ( #1036 )
...
* 🚧 Kotlin 2.0.0-Beta4
* Testing useKSP2 useK2Uast
* KSP 2.0.0-Beta4-1.0.19
* Update lint 8.4.0-alpha13
* 2.0.0-Beta5
* Lint 8.5.0-alpha02
* Update libs.versions.toml
* Update libs.versions.toml
* 🤖 Updates baselines for Dependency Guard
* KSP `2.0.0-Beta5-1.0.20`
* 2.0.0-RC1
* lint 8.5.0-alpha06
* Kotlin 2.0.0-RC2
* Lint 8.5.0-alpha07
* Fix missing imports
* Migrate from deprecated `kotlinOptions` to `composeCompiler`
* Kotlin 2.0.0-RC3 and AGP 8.6.0-alpha01
* Kotlin 2.0.0 & KSP 2.0.0-1.0.21
* Add `.kotlin` directory to `.gitignore`
* Migrate from deprecated kotlinOptions to compilerOptions
* Restore main workflow
* Migrate from deprecated kotlinOptions to compilerOptions
* Restore relative directories for Compose compiler metrics & reports
---------
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
2 years ago
8fc2e15e73
Update to navigation 2.8.0-beta01
...
Change-Id: I2f01dc19e37b9fe890ad861909f57198cc5262d4
2 years ago
61143ca98b
Merge remote-tracking branch 'origin/main' into fix/1161-2
2 years ago
3cff2fbda2
Remove unnecessary comment
...
Change-Id: I535ca7fcec48c32b727c1c6c465a719d60dcb0f9
2 years ago
2d45b84031
Merge branch 'main' into dt/nav-safe-args
2 years ago
6dc59e7016
Use SafeArgs navigation for Topic feature
...
Change-Id: Idf4386f10c780d3edc1f8aa11b428cb146e982c3
2 years ago
5be13a047b
Enable strong skipping
2 years ago
23b0958311
added ksp arg to generate room code in kotlin
2 years ago
78e3725f9f
Sets up jacoco coverage with a combined report and a GHA ( #1303 )
...
* Uses jacoco coverage reporting in AGP
2 years ago
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
2 years ago
ab90334210
Disable animations of instrumented tests ( #1167 )
...
https://developer.android.com/reference/tools/gradle-api/com/android/build/api/dsl/TestOptions#animationsDisabled()
2 years ago
42e9a3a2c6
Merge pull request #1182 from SimonMarquis/api-compose-ui-tooling
...
Move `androidx.compose.ui:ui-tooling` dependency to convention plugin
2 years ago
9cd430ba7d
Update AGP to 8.3.0
...
Change-Id: I6ea5aeaf357dafbae7be0e7f5f0443fbb1a8e68b
2 years ago
dc22e8ae31
Merge remote-tracking branch 'origin/main' into jvm-alt
3 years ago
75a3295381
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt
3 years ago
69f4287ab5
Merge branch 'main' into lifecycle2.7.0
...
* main:
Bump protobuf from 3.24.4 to 3.25.2 (#1214 )
Remove legacy benchmark build type (#1207 )
Use androidx.tracing everywhere
Revert fast initialization of Coil
Add comment for Retrofit async OkHttp
Optimize OkHttp initialization for Retrofit
Add braces
Inline initialization
Don't use runBlocking if async init completed
Launch loader directly without additional coroutine scope
Fix comment
Improve lazy loading for Coil + OkHttp
Restores screenshot tests in foryou (#1199 )
Fix name and message of dependency guard actions (#1196 )
Change-Id: Ifcbfcfba4b7d8c24599e207b4a05dfea6125fde7
3 years ago
f64f1c0aa2
Remove legacy benchmark build type ( #1207 )
...
* Remove legacy benchmark build type
Now that we have the baseline profile gradle plugin,
there is no need for a benchmark build type.
The plugin does the setup and configuration and runs against the
correct app flavor.
* Remove explicit benchmark build type from benchmark module
* Remove stale build task exclusions
* Fix tracing import location
FYI @mlykotom
3 years ago
254b464259
Update Lifecycle to 2.7.0. Use new LifecycleEventEffect.
...
Change-Id: I71e7aa521f22499fd3f3e9f3ac7c81658f3abc3a
3 years ago
d9aaec0699
Use androidx.tracing everywhere
...
Change-Id: I847827efc08f5cbc00f0c809ad992c267f826e50
3 years ago
e629d5e4bf
Merge branch 'main' into jvm-alt
3 years ago
6ec3b3c7a2
Use androidx.tracing everywhere
...
Change-Id: I9a77c4434d271e2e23700823f9f513aa61d177f8
3 years ago
cb00d2c8cb
Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers
...
This way, we can save ~1ms per composed item on screen.
Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d
3 years ago
db4bf1c782
Keep `androidx.compose.ui:ui-tooling-preview` on all buildTypes
3 years ago
d932cde110
Move `androidx.compose.ui:ui-tooling` dependency to convention plugin
3 years ago
4dd51cb6b1
Merge common dependencies
3 years ago
bc8871a9b0
Convert inheritance into delegation
3 years ago
4f8f08380f
Prep work for JVM alternatives to modules/plugins
3 years ago
707117a4f2
Merge branch 'main' into kotlinify
3 years ago
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
3 years ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
3 years ago
ac9dafa7b3
Merge branch 'main' into cleanup-dependencies
3 years ago
b6d82e24df
Merge branch 'main' into kotlinify
3 years ago
34d8262e00
Merge branch 'main' into room-gradle-plugin
3 years ago
74466d6e21
Merge pull request #1085 from android/av/truth-for-badging
...
Add truth for better badging diff output
3 years ago
75cd16ba18
Merge pull request #1086 from SimonMarquis/patch-3
...
Remove unnecessary FlowPreview opt-in
3 years ago
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
3 years ago
5f7d4ea1d5
Replace custom `RoomSchemaArgProvider` in favor of the new Room Gradle plugin
...
> Since Room 2.6.0, a Gradle plugin was released to solve various existing issues in Room regarding having inputs and outputs of schemas via Gradle annotation processor options.
> Changelog: https://developer.android.com/jetpack/androidx/releases/room#2.6.0-alpha02
See https://github.com/gradle/android-cache-fix-gradle-plugin/issues/544 for reference.
3 years ago
e305b07271
Remove unnecessary RequiresOptIn opt-in
3 years ago
02adbe0aad
Remove unnecessary FlowPreview opt-in
3 years ago
5df9cce37c
Add truth for better badging diff output
...
Change-Id: Id3fab0107bc08adf44ddf07a30e0327e06897d47
3 years ago
46b0a81080
Use normal propery setting
...
Change-Id: I31aef2007b63c067ad80a9f65f2b9594d114f13a
3 years ago
8a992996a4
Enable stricter validation for build-logic convention plugins
...
Change-Id: I1955393c76e91bebfe4b7e349734c81a10263c8c
3 years ago
392eaa3e61
Add dependencyGuard to AndroidApplicationConventionPlugin
...
Change-Id: Ib695ca18512d0ccde4c67e101f09ebbff8897912
3 years ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
3 years ago
c908f989c8
Update to Hilt 2.48.1 and use the KSP version
...
* Moved protobuf to separate module to avoid having to wire KSP's Plugin with the Protobuf Plugin.
* `@Binds` function cannot be an extension function.
* Commented `kotlin.compiler.execution.strategy=in-process` in CI to circumvent OOMs due to increased metaspace usage.
3 years ago
f414cd482e
Merge pull request #1013 from android/av/sdkconstants-for-aapt2
...
Use SdkConstants for getting aapt2 executable location
3 years ago
c70049edd8
Use specific task name for updating badging
...
Change-Id: I52b75fb3ed2ae3a76656c211b7aee1aa521f1112
3 years ago
c730cf20fa
Use SdkConstants for getting aapt2 executable location
...
Change-Id: Ibc9ece0c3ade51a29954caee3af3a669ed99c384
3 years ago
66cb30a811
Fix #1008 : Use capitalized variant name when registering gradle tasks
3 years ago
360b33eb82
Add automatic checks for badging
...
Change-Id: Ic8fca86d7aa84675fa91fb1aa99abcc6e19d663e
3 years ago
6e96d30519
Merge pull request #912 from lihenggui/main
...
Upgrade Gradle to v8.3
3 years ago
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
3 years ago
151f877bbe
Adds screenshot tests to :core:designsystem ( #931 )
...
* WIP: Adds screenshot tests to :core:designsystem
Change-Id: I0672845feba4064652dd8d60f07047b87864e121
* 🤖 Updates screenshots
* Creates tests for more components and cleans up
Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22
* WIP: More cleanup and more combinations of themes
Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523
* Added the rest of the screenshot tests for designsystem
Change-Id: Ic427db5491910781c038882055524e3f3dbed194
* Some more cleanup
Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180
* Spotless
Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6
* 🤖 Updates screenshots
* ScreenshotHelper cleanup
Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0
3 years ago
eadcbe6795
Fix typo in `AndroidCompose.kt`
3 years ago
Simon Marquis
Alex Vanyo
Jaehwa Noh
Alfayed Baksh
Don Turner
David Burström
takahirom
Ben Weiss
sanao
Zongle Wang
cketti
Don Turner
Ben Trengrove
natarajkr007
Jose Alcérreca
Tomáš Mlynarič
Jonathan Koren
Daniel Santiago
lihenggui