8f2beaf889
🤖 Updates screenshots
1 year ago
211654ff16
Merge pull request #1373 from android/av/navigation-suite
...
Add NavigationSuiteScaffold
1 year ago
61143ca98b
Merge remote-tracking branch 'origin/main' into fix/1161-2
1 year ago
7659925df7
Merge branch 'main' into move-android-instrumented-test
1 year ago
f711e69cd2
Merge branch 'main' into dt/nav-safe-args (AnimatedPane broken)
...
* main:
Save nested nav key in instance state
🤖 Updates baselines for Dependency Guard
Recreate nested nav to work with AnimatedPane
Remove forgotten Trace.endSection()
Offload connectivity monitor to a background thread
Change-Id: I4002a07484a4d633c57406aedabf9f5d813a8592
1 year ago
f67f4d1a83
Update ForYou destination to match current deeplink pattern
...
Change-Id: Ia5ab36f2d75d8d061e63c0cac5262503bc93a638
1 year ago
7f2ce57c67
Merge pull request #1368 from android/mlykotom/offload-connectivity-monitor
...
Offload connectivity monitor to a background thread
1 year ago
3fb6df7c33
Add NavigationSuiteScaffold
...
Change-Id: I36710d880bff381ed86c61632f2ab91902727775
1 year ago
61cce4bf19
Merge branch 'main' into replace-testharness
1 year ago
16f45c0b1a
Adds screenshot tests for snackbar ( #1343 )
...
* Adds screenshot tests for snackbar
Change-Id: I81566e3301fb17e3f31cbc408e6cc3325eab5a12
* Small tweaks, RFR
Change-Id: Ia16db6e6f5bec2714081b5ceaeeba36b2ee26105
* 🤖 Updates screenshots
* Update NiaApp.kt
Adds modifier to NiaApp
1 year ago
c396352d83
Remove forgotten Trace.endSection()
...
Change-Id: Ib6f7678f5f1c4b0f93f1736b6453c649d6f7dc97
1 year ago
6b35cbb328
Offload connectivity monitor to a background thread
...
Change-Id: I9a2ef7766ae6abc6d8a7c86a4b49ef3c795e446c
1 year ago
0d6566b75b
🤖 Updates screenshots
2 years ago
fc2146c970
Merge branch 'main' into replace-testharness
2 years ago
aa688711f0
Lower visibility of some dependencies
2 years ago
88c3eb0b90
Merge pull request #1284 from sanao1006/remove-GetSearchContentsCountUseCase
...
Directly call SearchContentsRepository interface in SearchViewModel
2 years ago
0f88f6dd24
Merge pull request #1314 from squart300kg/main
...
clean up di module in core.database package
2 years ago
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
2 years ago
bd89507f10
Merge pull request #1306 from yongsuk44/feat/weak-warning
...
Cleaned up unnecessary '@opt-in' annotations and removed empty constructors
2 years ago
ecdfdef4e4
Merge pull request #1291 from Jaehwa-Noh/rename
...
Rename Fake to Demo
2 years ago
d9b66c4cac
clean up di module in core.database package
2 years ago
af7729586c
Remove empty primary constructors
2 years ago
e2a4706470
Remove unnecessary opt-in annotations
2 years ago
3c70183ce6
Change name Fake to Demo.
...
Change-Id: Ife321dd95238227bfdfc1f13f6832472bd699b6f
2 years ago
ee8797f940
Delete unused `combine` extension in `SyncUtilities.kt`
2 years ago
cd294a8654
Change lint ignore name in lint.xml.
...
Change-Id: I3b1e19dedd238ec96bd8debee5fcbcc91bc25094
2 years ago
2739168e33
Revert "Move main to demo."
...
This reverts commit a5be299e3d
2 years ago
a5be299e3d
Move main to demo.
...
Change-Id: I48bb3c26ef02d6302cb7caabcaa17d5b4659031a
2 years ago
5d99f381e9
Remove VisibleForTesting.
...
Change-Id: Icd7005ec38495a1a4bc6f1594f70a2c1228538ab
2 years ago
27ca860745
Rename fake to demo.
...
Change-Id: I5b1d7963e623832a766900aa74ef1085aac0cacc
2 years ago
51d3903a4b
Merge branch 'main' into remove-GetSearchContentsCountUseCase
2 years ago
0584f191bc
Merge pull request #1271 from android/dt/remove-feature-dep
...
Remove the search module's dependency on other feature modules
2 years ago
825a5e2f5f
[Refactor]: Directly call SearchContentsRepository interface in SearchViewModel
...
- Remove GetSearchContentsCountUseCase.
- Remove GetSearchContentsCountUseCase from SearchViewModel.
- Remove GetSearchContentsCountUseCase from SearchViewModelTest.
Fixes #1283
2 years ago
78c77737c0
Merge pull request #1275 from Jaehwa-Noh/rename-function
...
Rename function to setNewsResourceBookmarked
2 years ago
a4c52e6485
Remove the search module's dependency on other feature modules
...
Change-Id: I17df9948fed04ddc7ba507b437d39536b8b180bb
2 years ago
3e4aad3210
Merge pull request #1257 from android/dt/add-module-graphs
...
Update module dependency graphs and add script to create them
2 years ago
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
2 years ago
ee4320723f
Fix typo.
...
Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f
2 years ago
ed91723e2f
Fix #1270
...
Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c
2 years ago
c4642cea61
Add graph for screenshot testing module, minor update to script
...
Change-Id: I611f73d59790bde240756e8016aa721a1783335f
2 years ago
abe798056e
Add @After to guarantee DB was closed. ( #1240 )
...
* Add @After to guarantee DB was closed.
Change-Id: Ic29b7d12125853c71ddaef1a997ec123bb2dfc8b
* Fix spotless
- style
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
---------
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
2 years ago
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
2 years ago
2d610b0775
Merge branch 'main' into replace-testharness
...
* main: (37 commits)
Disable animations of instrumented tests (#1167 )
Bump gradle/wrapper-validation-action from 1 to 2
Remove unused release variable. Fixes #1231
Apply Composable Parameter Ordering Guidelines
Remove kotlinx-coroutines-guava dependency from :sync:work
Add explicit guava-android dependency for :sync:work
Extract ScreenshotHelper to separate testing module
Update AGP to 8.3.0
Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert.
🤖 Updates baselines for Dependency Guard
Bump the kotlin-ksp-compose group with 6 updates
🤖 Updates baselines for Dependency Guard
Bump hilt from 2.50 to 2.51
Bump com.google.truth:truth from 1.1.5 to 1.4.2
Move java to kotlin folder.
Remove disk usage testing
Figuring out what is using 66Gb in the runner
Dpm
Improve converting to kotlin timezone
Use trySend multiple times
...
Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a
2 years ago
42e9a3a2c6
Merge pull request #1182 from SimonMarquis/api-compose-ui-tooling
...
Move `androidx.compose.ui:ui-tooling` dependency to convention plugin
2 years ago
350e7b1bba
Merge pull request #1144 from SimonMarquis/move-fakes-to-data-test-module
...
Move `:core:data` fake repositories to `:core:data-test`
2 years ago
171fa88ac0
Merge pull request #1248 from yongsuk44/main
...
Apply Composable Parameter Ordering Guidelines
2 years ago
067d68e1c6
Merge pull request #1247 from Jaehwa-Noh/remove-unused-function
...
Remove Insert function
2 years ago
3fa75a037a
Apply Composable Parameter Ordering Guidelines
...
Change-Id: Id456e91b5ce8bd5807c40df67c3deac008c61670
2 years ago
e3c7018124
Extract ScreenshotHelper to separate testing module
...
Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af
2 years ago
52c0d7ae0a
Remove Insert function
...
- Insert is only used in test.
- Upsert do same thing as Insert.
Change-Id: Ib5f8e693e71c895b83e43f6b51cebdc698bf744b
2 years ago
f31fdb3ec2
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Id49a580012629163ec4a3663d95ab71b98910220
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
# gradle/libs.versions.toml
2 years ago
50d5583fe1
🤖 Updates screenshots
2 years ago
d6357be8c4
Replace Accompanist TestHarness with DeviceConfigurationOverride
...
Change-Id: I6742d5e221f86a019f44d3e623609bf76d2a3a2a
2 years ago
7abcefdfdf
Update Compose BOM to 2024.02.00. Fixes #1218
...
Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b
2 years ago
8d89a89096
Merge remote-tracking branch 'origin/main' into move-android-instrumented-test
2 years ago
dc22e8ae31
Merge remote-tracking branch 'origin/main' into jvm-alt
2 years ago
dc2f435a27
Merge remote-tracking branch 'origin/main' into move-fakes-to-data-test-module
2 years ago
27fd4e544a
🤖 Updates screenshots
2 years ago
08dfec01f6
Fix individual UI components
...
Change-Id: I7dec3672b9efc3524371811743b06efc1e113a36
2 years ago
02d4fea615
🤖 Updates screenshots
2 years ago
8494b74646
Fix spotless (really should enable the commit hook to do this)
...
Change-Id: I68cb9bd989a809e5db1bca3157c2c978ad8c8906
2 years ago
68c15a891c
Fix text styles and spacing now that includeFontPadding is false
...
Change-Id: I6894836a7cd3a6139511a5d1ac0a96702a265186
2 years ago
81a5c0a3a7
🤖 Updates screenshots
2 years ago
092daacced
Revert fontSize change
...
Change-Id: I4011205f8a07c418653ee463d7355fe1e4ff6f44
2 years ago
1de15f0fab
Fix spotless (again)
...
Change-Id: If6b292af514df435d7bd233bd634657904c67d6b
2 years ago
76d59b3da8
Merge branch 'main' into update-compose-bom
2 years ago
1d2029aa2c
Merge pull request #1040 from SimonMarquis/fix-unit-test
...
Fix `emptyResultIsReturned_withNotMatchingQuery` unit test
2 years ago
adddea6fc7
Remove includeFontPadding, default behaviour is fine
...
Change-Id: I334c5a488c1e2a2b49670a97b16385a7df1791c8
2 years ago
75a3295381
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt
2 years ago
9e645356f6
🤖 Updates screenshots
2 years ago
3868371ec8
Switch default padding to true since this was actually false by default since Compose 1.6.0-alpha01
...
Change-Id: Ifd291b247f848cea43e084cc0fb99917e47e26eb
2 years ago
c773fd7d0a
Switch off default font padding to avoid changing UI
...
Change-Id: Ida974df8fd4b1aba6f9525ef5335a6cbe02ddb18
2 years ago
3b1ee87194
Fix ShortText icon
...
Change-Id: I8b243ef88c1cc8be83f5fbeaee6a2576c453a062
2 years ago
6b2b01ed82
🤖 Updates screenshots
2 years ago
522efac8c0
Update Compose BOM to 2024.02.00. Fixes #1218
...
Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b
2 years ago
4cdc2ad345
Add comment for Retrofit async OkHttp
...
Change-Id: Ic7a6887b76caf26f00b58b0753271d426b67e75b
2 years ago
d110d92b87
Optimize OkHttp initialization for Retrofit
...
Change-Id: I347f1080ab5adf774a0cdd3c659cbf25c4820f9a
2 years ago
5f0612102d
Improve lazy loading for Coil + OkHttp
...
This way, we can load Coil's backend on a background thread and not block the MainThread with it.
Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames.
Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62
2 years ago
9daedc9690
Improve converting to kotlin timezone
...
Change-Id: I2af929c341cb274ae6b93bb8dffe696de6ed1c63
2 years ago
12a3a6edde
Use trySend multiple times
...
Change-Id: Ie00c4180d07fc4bb9d457647f3b7ddadd5a3c032
2 years ago
3d339e1658
Move `:core:data` fake repositories to `:core:data-test`
...
Now that these fake implementations are no longer used in the production source code (only in tests), we can safely extract them out of this module.
Hopefully, we'll later be able to use Kotlin testFixtures for that.
References:
- #709
- #875
2 years ago
e629d5e4bf
Merge branch 'main' into jvm-alt
2 years ago
6ec3b3c7a2
Use androidx.tracing everywhere
...
Change-Id: I9a77c4434d271e2e23700823f9f513aa61d177f8
2 years ago
ea1573fcc1
Use kotlinx.datetime.Timezone instead of java ZoneId
...
Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628
2 years ago
b687328567
Replace comments with proper `@TestOnly` annotations
2 years ago
a83f6691c4
Fix addNewsResources issue
2 years ago
5a1258232f
Fix `emptyResultIsReturned_withNotMatchingQuery` unit test
...
`searchResultUiState` transitively relied on `getSearchContentsCount` updates and on `userDataRepository` to emit something.
2 years ago
a16d5f726c
More readable zoneId creation
...
Change-Id: I912dc021554e4886a5d09e63799aa5c81e8fd16a
2 years ago
44ae059a2b
Rename LocalTimeZone -> LocalZoneId + collects with lifecycle
...
Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3
2 years ago
1e925ed99f
Conflate TimeZoneMonitor emissions
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
2 years ago
0b3ece1bb9
Fix spotless
...
Change-Id: I6583fa9ed7c1563f6164653be9bbaf7904ec0215
2 years ago
cb00d2c8cb
Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers
...
This way, we can save ~1ms per composed item on screen.
Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d
2 years ago
d932cde110
Move `androidx.compose.ui:ui-tooling` dependency to convention plugin
2 years ago
691bf2aad6
Merge pull request #785 from SimonMarquis/optimize-avd
...
Optimize AVD to fix long vector paths Lint warning
2 years ago
d9d9153eda
Merge branch 'main' into firebase-ktx
2 years ago
377d3bef0c
Optimize AVD to fix long vector paths Lint warning
...
... with SVGOM, but you'll have to check on Android Studio the AVD diff.
https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html
2 years ago
d17f3b1101
Merge branch 'main' into move-android-instrumented-test
2 years ago
c1118eaf22
Apply suggestions from code review
2 years ago
61c7d71870
Migrate `:core:common` to pure JVM module
...
The notification icons are now stored in `:core:notifications`.
This forces `:sync:work` to depend on it.
Another solution could be to provide the resource id through Hilt, but it would require more changes.
2 years ago
4f8f08380f
Prep work for JVM alternatives to modules/plugins
2 years ago
alexvanyo
Alex Vanyo
Simon Marquis
Don Turner
Don Turner
Tomáš Mlynarič
Jose Alcérreca
sangyoon
yongsuk44
Jaehwa Noh
sanao1006
kim-yongsuk