hiroaki404
8bb823ede7
use backgroundScope
...
Change-Id: I78d5e53d343dac7e7d27896c95714a53a9a7229a
9 months ago
Ben Weiss
e8035622b3
Enable the thread police 👮 for debug builds
...
* App will now crash if someone does funky stuff on the main thread.
Change-Id: I9026c100705f2fec6963a1d888b40906186f9d28
9 months ago
Jaehwa Noh
81e7ef0a05
Replace Annotation to compiler args. ( #1602 )
...
Change-Id: I691fc0f14d4bb2c62224dc77a5d0f3a08b59a75b
9 months ago
nosho.hiroaki
94f86b7975
fix test name and typo, and user assertion instead of check method
...
Change-Id: I45e04df676fe9f5e5e893a1fc6e8f54e9e7d7a1a
9 months ago
nosho.hiroaki
d372d6ecec
improve BookmarksViewModelTest coverage
...
Change-Id: Ide13abd9a125a337ba9c9fff2136221e16ebd46e
9 months ago
Andrea Severi
95ab14601f
opt out of forced dark mode
9 months ago
takahirom
7c5bc96e4e
Add comment for application theme
9 months ago
takahirom
86e38418d5
Add no actionbar theme to hilt
9 months ago
takahirom
e0f30acddd
Target SDK 35
9 months ago
takahirom
2a2f45d51e
Apply theme in test
9 months ago
Tram Bui
0e52982866
Merge branch 'main' into trambui/navigation-null-debug
9 months ago
Tram Bui
827d3d66e2
incorporate safe fallback destination to null destination UI flickering
9 months ago
Ben Weiss
4a0723441f
Dependency version upgrades, not API 35 yet ( #1719 )
...
* Update screenshots
Change-Id: Ibed7889a3389ab6044e00a185158f36ce857b6b2
* Dependency version upgrades
Change-Id: Ib4a1f9bef1dd3e1736907479125d0abb5b22e9bd
* Address review comments
Change-Id: Ia2c6a52e289285a7a78336fa4250fa6a04ccb5c4
* 🤖 Updates baselines for Dependency Guard
* 🤖 Updates screenshots
9 months ago
Rudr Pratap Singh
ba05404017
Issue #1272 rewrote it.enableAndroidTest to it.androidTest.enable ( #1456 )
9 months ago
Jaehwa Noh
e6ec99e793
Add clear instruction at CI screenshot tests error output ( #1423 )
...
* Add clear instruction
- Your fork's CI will take screenshots for your fork.
Change-Id: I7ea1a437be4f9723fcf71d4d18932f8f44f46fa8
* Remove screenshots to see CI instruction.
Change-Id: Ib12f0ee4ff4faff8287f9ddfd5e533868abca4f8
* Revert "Remove screenshots to see CI instruction."
This reverts commit 36de3be9ba
.
9 months ago
Jaehwa Noh
37fea198e4
Add instruction in ```generateModuleGraphs.sh``` documentation. ( #1361 )
...
* Add Others OS instruction in documentation.
Change-Id: I96be572051558d89e004187534da96a7b01a78ea
* Change apt-get to apt according to [documentation](https://graphviz.org/download/ )
Change-Id: I0c00ce50d6bce83de79b5612021822691090cb6f
9 months ago
Simon Marquis
2e1232c136
Merge remote-tracking branch 'upstream/main' into sarif
9 months ago
Don Turner
cc50941173
Add API 34 emulator
9 months ago
Don Turner
d183cbd412
Merge pull request #1724 from android/dt/remove-api30emu
...
Removing API 30 emulator while investigating flakiness
9 months ago
Don Turner
8267b619d6
Removing API 30 emulator while investigating flakiness
9 months ago
Don Turner
e8e107c17b
Update screenshots
9 months ago
Don Turner
ef56e5a2f9
Merge pull request #1720 from android/revert-1344-main
...
Revert "Upgrade retrofit to 2.10.0"
9 months ago
Don Turner
b21835909c
Merge pull request #1722 from android/revert-1630-dependabot/gradle/protobuf-4.28.2
...
Revert "Bump protobuf from 4.26.1 to 4.28.2"
9 months ago
Ben Weiss
729681b79a
Revert "Bump protobuf from 4.26.1 to 4.28.2 ( #1630 )"
...
This reverts commit 82b6352da1
.
9 months ago
dturner
802bc3e161
🤖 Updates screenshots
9 months ago
Don Turner
047b44dc68
Merge pull request #1721 from android/revert-1656-dependabot/gradle/firebaseCrashlyticsPlugin-3.0.2
...
Revert "Bump firebaseCrashlyticsPlugin from 2.9.9 to 3.0.2"
9 months ago
Don Turner
9ee490322f
Revert "Bump firebaseCrashlyticsPlugin from 2.9.9 to 3.0.2 ( #1656 )"
...
This reverts commit d10c8c0c25
.
9 months ago
Don Turner
c1dfad169e
Revert "Upgrade retrofit to 2.10.0 ( #1344 )"
...
This reverts commit 9f11fe6337
.
9 months ago
blue928sky
cdb1d25306
Move Android instrumented test NiaAppStateTest to unit test
...
Change-Id: I0a84dc37184a9ea7d4c18fa598bc447b0c48eb62
9 months ago
Simon Marquis
78dbdfac53
Bump `github/codeql-action/upload-sarif@v3`
9 months ago
Simon Marquis
085347e5e2
Merge branch 'main' into sarif
9 months ago
Jaehwa Noh
dfc3355054
Empty search text is added in recent searches problem fix. ( #1223 )
...
* Add if state to prevent blank query.
* Create test emptySearchText_NotAddToRecentSearches
- For empty query not add in recent query list.
* Apply early return.
* assertEquals to assertNull.
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
* Import org.junit.Assert.assertNull
* Change org.junit.Assert.assertNull to kotlin.test.assertNull.
Change-Id: I60083b0b9a1dcaed84d957b49c91e5163d5659d6
* Add 'or' to prevent search when query is blank.
Change-Id: If498de05889d6d5946b1bbb1d1c10cb311bb9b52
* Create stateIsEmptyQuery_withThreeWhiteSpacesSearchQuery test.
Change-Id: I6d6e8f9fe988ca83fae484e4f2338ad6fe58b676
* Add UI logic to prevent blank text search in SearchScreen.
- Early return to do not call onSearchExplicitlyTriggered()
Change-Id: I28db284eac9059fb6f48dd718721a1fc5fdb8f7a
* Apply trim at query to remove whitespace.
Change-Id: Id349af4bb1af3d0f1c3973e6fb9e6f3e7b924d9b
* Create test stateIsEmptyQuery_withThreeWhiteSpacesAndOneLetterSearchQuery
Change-Id: Iee59f6085e4045b2e3c532f78804926290b6c6c5
* Update feature/search/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModelTest.kt
Change name to emptySearchText_isNotAddedTorecentSearches()
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
* Change name to searchTextWithThreeSpaces_isEmptyQuery()
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
* Change name to searchTextWithThreeWhiteSpacesAndOneCharacter_isEmptyQuery()
Change-Id: I4c82b12e2c9bd4ff480e94061caf257a603e38da
* Revert "Change name to searchTextWithThreeWhiteSpacesAndOneCharacter_isEmptyQuery()"
This reverts commit e4c176598a
.
* Change name to searchTextWithThreeSpacesAndOneLetter_isEmptyQuery
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
* Add end curly bracket.
Change-Id: I7bd113e7b65d646f5321e34a7df2868f6e239cad
---------
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
9 months ago
dependabot[bot]
274c38c154
Bump madrapps/jacoco-report from 1.7.0 to 1.7.1 ( #1627 )
...
Bumps [madrapps/jacoco-report](https://github.com/madrapps/jacoco-report ) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/madrapps/jacoco-report/releases )
- [Commits](https://github.com/madrapps/jacoco-report/compare/v1.7.0...v1.7.1 )
---
updated-dependencies:
- dependency-name: madrapps/jacoco-report
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
9 months ago
dependabot[bot]
82b6352da1
Bump protobuf from 4.26.1 to 4.28.2 ( #1630 )
...
* Bump protobuf from 4.26.1 to 4.28.2
Bumps `protobuf` from 4.26.1 to 4.28.2.
Updates `com.google.protobuf:protobuf-kotlin-lite` from 4.26.1 to 4.28.2
Updates `com.google.protobuf:protoc` from 4.26.1 to 4.28.2
- [Release notes](https://github.com/protocolbuffers/protobuf/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl )
- [Commits](https://github.com/protocolbuffers/protobuf/commits )
---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-kotlin-lite
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.google.protobuf:protoc
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* 🤖 Updates baselines for Dependency Guard
* 🤖 Updates screenshots
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Weiss <keyboardsurfer@users.noreply.github.com>
9 months ago
dependabot[bot]
56c284a303
Bump com.google.accompanist:accompanist-permissions from 0.34.0 to 0.36.0 ( #1658 )
...
* Bump com.google.accompanist:accompanist-permissions
Bumps [com.google.accompanist:accompanist-permissions](https://github.com/google/accompanist ) from 0.34.0 to 0.36.0.
- [Release notes](https://github.com/google/accompanist/releases )
- [Commits](https://github.com/google/accompanist/compare/v0.34.0...v0.36.0 )
---
updated-dependencies:
- dependency-name: com.google.accompanist:accompanist-permissions
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* 🤖 Updates baselines for Dependency Guard
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
9 months ago
dependabot[bot]
bee6f6bb87
Bump androidxMacroBenchmark from 1.3.0 to 1.3.1 ( #1652 )
...
Bumps `androidxMacroBenchmark` from 1.3.0 to 1.3.1.
Updates `androidx.benchmark:benchmark-macro-junit4` from 1.3.0 to 1.3.1
Updates `androidx.baselineprofile` from 1.3.0 to 1.3.1
---
updated-dependencies:
- dependency-name: androidx.benchmark:benchmark-macro-junit4
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: androidx.baselineprofile
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
9 months ago
dependabot[bot]
eef7b9d6ae
Bump androidx.test:core from 1.5.0 to 1.6.1 ( #1654 )
...
Bumps androidx.test:core from 1.5.0 to 1.6.1.
---
updated-dependencies:
- dependency-name: androidx.test:core
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
9 months ago
dependabot[bot]
3b84a5fcdb
Bump com.google.truth:truth from 1.4.2 to 1.4.4 ( #1655 )
...
Bumps [com.google.truth:truth](https://github.com/google/truth ) from 1.4.2 to 1.4.4.
- [Release notes](https://github.com/google/truth/releases )
- [Commits](https://github.com/google/truth/compare/v1.4.2...v1.4.4 )
---
updated-dependencies:
- dependency-name: com.google.truth:truth
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
9 months ago
dependabot[bot]
d10c8c0c25
Bump firebaseCrashlyticsPlugin from 2.9.9 to 3.0.2 ( #1656 )
...
Bumps `firebaseCrashlyticsPlugin` from 2.9.9 to 3.0.2.
Updates `com.google.firebase:firebase-crashlytics-gradle` from 2.9.9 to 3.0.2
Updates `com.google.firebase.crashlytics` from 2.9.9 to 3.0.2
---
updated-dependencies:
- dependency-name: com.google.firebase:firebase-crashlytics-gradle
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: com.google.firebase.crashlytics
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
9 months ago
Ali Shariat
9f11fe6337
Upgrade retrofit to 2.10.0 ( #1344 )
...
* Upgrade retrofit to 2.10.0
* Update gradle/libs.versions.toml
---------
Co-authored-by: Ben Weiss <keyboardsurfer@users.noreply.github.com>
Co-authored-by: Zongle Wang <wangzongler@gmail.com>
9 months ago
Jaehwa Noh
1881730806
Bump spotless(6.23.3 to 6.25.0) and ktlint(1.0.1 to 1.4.0) ( #1318 )
...
* Bump up
- spotless.
- ktlint.
Change-Id: I4a0d1b4089dd4882df4653303a52f07f2bf6771f
* Update gradle/init.gradle.kts
* Disable all new features since ktlint 1.3.0.
https://github.com/pinterest/ktlint/releases/tag/1.3.0
Change-Id: I8f0ea640c06a2266cf0b7ede0da06bdd32651bbc
* Disabled `ktlint_standard_function-signature`.
Change-Id: Ib3e6e66d1774b39b5c92ec822308db107b070b82
---------
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
9 months ago
sanao
ab87857c9b
[Refactor]: Replace enableAndroidTest with androidTest.enable ( #1274 )
...
This is because enableAndroidTest is deprecated.
Fixes #1272
9 months ago
Zongle Wang
55dbe61c65
Optimize google maven downloading ( #1051 )
9 months ago
Don Turner
afb6741554
Merge pull request #1682 from blue928sky/use-lifecycle-compose-LocalLifecycleOwner
...
Use androidx.lifecycle.compose.LocalLifecycleOwner
10 months ago
Don Turner
284978fbcd
Merge pull request #1689 from Jaehwa-Noh/replace-test-to-version-catalog
...
Replace kotlin("test") to version catalog `kotlin.test`.
10 months ago
Adnan Habib
83a8beee72
Use typesafe project accessor
...
Change-Id: Ib9f0a68debaf75431fe45d5a81128e33e4885321
10 months ago
Yuri Schimke
92c5d4b068
reduce for now
10 months ago
Yuri Schimke
2415239d45
suppress checks
10 months ago
Yuri Schimke
e77dedf0dc
logging
10 months ago
Yuri Schimke
3e4f66b489
spotless
10 months ago