496d210b22
Merge pull request #2041 from SimonMarquis/cleanup-graphs-readme
...
Update README files that contained old svg references
6 months ago
5ba16edde9
Apply spotless by default ( #2055 )
...
* Apply spotless by default
- Upgrades to spotless 8.2.1
- Moves spotless setup from an init.gradle.kts to build-logic
- Narrows down the scope of `target` in spotless configuration to
be more precise to workaround https://github.com/diffplug/spotless/issues/2717
- Updates all references to init.gradle.kts
Ran gradle-profiler ./gradlew build --dry-run to validate performance
impact.
Before PR:
Mean 10,527.96 ms with 289.01 ms std dev
After PR:
Mean 11,251.78 ms with 530.29 ms std dev
Regression is there, but quite minor.
Test: ./gradlew spotlessCheck
* Address comments from AI overlords
* Fix usage of rootProject
* Enable spotless for build-logic via root project
7 months ago
379956cb30
Merge pull request #2045 from Jaehwa-Noh/rename-package
...
Rename package properly
8 months ago
1f729a896c
Update README files that contained old svg references
8 months ago
92fd6f6605
Remove feature module READMEs (they will be replaced by submodule READMEs)
9 months ago
b9a80fc038
Refactor navigation routes to NavKeys
...
This commit refactors the navigation implementation by renaming all `...Route` classes to `...NavKey`. This change provides more descriptive and consistent naming for navigation keys across the codebase.
Key changes include:
* Renamed `BookmarksRoute` to `BookmarksNavKey`
* Renamed `ForYouRoute` to `ForYouNavKey`
* Renamed `InterestsRoute` to `InterestsNavKey`
* Renamed `TopicRoute` to `TopicNavKey`
* Renamed `SearchRoute` to `SearchNavKey`
* Updated all associated feature modules, tests, and UI components to use the new `NavKey` names.
* Removed obsolete test utilities and mock providers related to the old navigation setup.
* Deleted outdated dependency graph images and their corresponding `README.md` files from feature modules.
9 months ago
f6824858c4
Refactor NavigationState and make tests pass
9 months ago
386d1a0a16
WIP remove DI 2
9 months ago
c9bba49957
WIP remove DI
9 months ago
dc29a5eb62
run spotless
10 months ago
b91a965ae2
Refactored NiaNavigator
...
Made NiaNavigator a stateless class only responsibly for navigating and pop (modifying backStack).
Navigation state now lives in a new class called NiaNavigatorState.
The state of this class is saved and restored by ViewModel.
10 months ago
a878b170dc
Update dependencyGuardBaseline
10 months ago
e373828f5f
Update feature ViewModels and tests
10 months ago
4a8eaba408
Refactor Interests to ListDetailScene
10 months ago
d30083005e
Refactor feature modules to navigation3
10 months ago
068d8cc93c
Split feature modules into api and impl modules
...
Source code is still left in api module. impl module is empty at this point.
10 months ago
17162dab60
graphUpdate
12 months ago
1c61be7b7b
Update color mapping
...
| Type | Plugin ID | Color |
|-------------|------------------------------------|------------------------|
| Application | `nowinandroid.android.application` | `#CAFFBF` PastelGreen |
| Feature | `nowinandroid.android.feature` | `#FFD6A5` PastelOrange |
| Library | `nowinandroid.android.library` | `#9BF6FF` PastelBlue |
| Test | `nowinandroid.android.test` | `#A0C4FF` PastelMauve |
| JVM | `nowinandroid.jvm.library` | `#BDB2FF` PastelPurple |
| Unknown | `?` | `#FFADAD` PastelRed |
1 year ago
e8dc43b58b
graphUpdate
1 year ago
e079e68815
Delete old graphs
1 year ago
502c719603
Update TopicViewModelTest
...
Change-Id: I8e881bb2cf549303be8612732bfb7df7555096aa
2 years ago
e25b3634ca
Add predictive back and pane expansion back handling
...
Change-Id: I8e881bb2cf549303be8612732bfb7df7555096aa
2 years ago
800e3d55c9
Assisted inject approach
...
Change-Id: I5fba15921520bc83b13601fa82ae71457d875805
2 years ago
5994d8c6fd
Add TopicScreen as a sub destination in the ForYou section. Fixes #1463
2 years ago
bd557fd604
Reduce icon sizes
2 years ago
987e87f4ed
Check topicViewModelTest for spotless
2 years ago
26dd4424f6
remove blank lines for resolve spotless error
2 years ago
0356b873e9
change collectJob to backgroundScope coroutine
2 years ago
00efda54e8
Merge branch 'main' into dt/nav-safe-args
...
* main: (58 commits)
Instrumented tests for InterestsListDetailScreen (#1518 )
Remove Firebase AD_SERVICE_CONFIG property
updateProdReleaseBadging
Merge Android & JVM plugins into a single `HiltConventionPlugin`
Update dependency guard
🤖 Updates baselines for Dependency Guard
Update to Lifecycle 2.8.3
Add android.adservices.AD_SERVICES_CONFIG to badges
Apply suggestions from code review
Update app/src/main/AndroidManifest.xml
generateModuleGraphs
dependencyGuardBaseline
updateProdReleaseBadging
Fix spotless.
Change set to `=` operator
Cleanup unused reference in `libs.versions.toml`
Regenerate SVG graphs
Update comment wording
Use stdin to avoid repeating the output file name
Replace bash commands with proper svgo cli
...
Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5
2 years ago
ec71b2a07e
Add Robolectric to allow ViewModel tests to pass
...
Change-Id: I782fab167103edbdaa1d95839b4fbc6e659fef4e
2 years ago
da8f32a2ea
Rename Destinations to Routes
...
Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7
2 years ago
61143ca98b
Merge remote-tracking branch 'origin/main' into fix/1161-2
2 years ago
7ec21d9d2f
Fix issue where selected topic in list was not showing as selected. Minor tidy ups.
...
Change-Id: Icfa79eac6f7327c365f79fd7d15dfa1f8c77184d
2 years ago
1c0508a678
Recreate nested nav to work with AnimatedPane
...
Change-Id: I6b526331b7fc62b968ac39e91753a8a1e5343023
2 years ago
924391cd22
Fix spotless
...
Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428
2 years ago
89163b5ea1
Migrate remainder of app to type-safe navigation
...
Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b
2 years ago
490997281a
Update to alpha08, use toRoute to obtain destination inside VM
...
Change-Id: I72f617c594b5e0ae272cf94d2d7288446153420a
2 years ago
d96bcf8ffe
Migrate Interests nested NavHost to safe args
...
Change-Id: I4f3c310be693ecbcbc8b99c4e573d7fc6e9a2f74
2 years ago
6dc59e7016
Use SafeArgs navigation for Topic feature
...
Change-Id: Idf4386f10c780d3edc1f8aa11b428cb146e982c3
2 years ago
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
3 years ago
dac1a9e446
Topic detail pane placeholder ( #1280 )
...
* Topic detail pane placeholder
Change-Id: I92b84493a5406240285c0759b30aa10d29871f09
* Add modifier parameter
Change-Id: Ie363be83b44f26291030c04c1513cecb851a6899
3 years ago
78c77737c0
Merge pull request #1275 from Jaehwa-Noh/rename-function
...
Rename function to setNewsResourceBookmarked
3 years ago
3e4aad3210
Merge pull request #1257 from android/dt/add-module-graphs
...
Update module dependency graphs and add script to create them
3 years ago
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
3 years ago
fc4f7930a6
Merge branch 'android:main' into rename-function
3 years ago
ee4320723f
Fix typo.
...
Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f
3 years ago
ed91723e2f
Fix #1270
...
Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c
3 years ago
547cb191d2
Merge pull request #1256 from lnbs97/main
...
Fix typo in TopicViewModel.kt
3 years ago
19f6f9e09a
2 pane support in Interests screen ( #1234 )
...
* Add dependency on material3 adaptive
Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6
* Add InterestsListDetailScreen composable
Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971
* Store selectedTopicId in InterestsViewModel
Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce
* Pass detail pane composable down
Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293
* Navigate to initial topic if provided
Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b
* Lift LDPS up to app module
Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85
* Fix some navigation behavior
Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b
* Navigate to initial topic if provided
Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed
* Remove dependency in interests feature module
Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f
* Hide back arrow when the topics list is visible
Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8
* Update interests tests
Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd
* Highlight selected topic when displaying 2 panes
Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415
* update dependency baselines
Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00
* run spotless apply
Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8
* Convert isListPaneHidden to isListPaneVisible
Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657
* Set semantics for selected state
Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca
* Use scaffold roles when determining visibility
Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648
* Update multipleBackStackInterests test
Change-Id: I1e372f7989817151a6765205291b13b561187fa8
3 years ago
96d210dc35
fix typo in TopicViewModel.kt
3 years ago
Don Turner
Aurimas
Jaehwa Noh
Simon Marquis
Don Turner
Clara Fok
Alex Vanyo
saeedishayan76
Jonathan Koren
lnbs97