nowinandroid

Commit Graph

Author	SHA1	Message	Date
Don Turner	707117a4f2	Merge branch 'main' into kotlinify	2 years ago
Don Turner	0f0511748e	Merge pull request #1088 from SimonMarquis/cleanup-dependencies Reduce overall build complexity	2 years ago
Don Turner	89d39a7242	Merge pull request #767 from SimonMarquis/resource-prefix Enforce `resourcePrefix` on Android library modules	2 years ago
Simon Marquis	cd62fd5e01	Update feature/search/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/search/navigation/SearchNavigation.kt	2 years ago
Don Turner	9d41ffa318	Merge branch 'main' into kotlinify	2 years ago
lihenggui	32e1ec0447	Remove violations: property-naming	2 years ago
lihenggui	f8f932705a	Remove violations: discouraged-comment-location	2 years ago
lihenggui	fb5bd225be	Spotless	2 years ago
Simon Marquis	f27a2e176e	Reduce overall build complexity - Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces - Correctly configure the visibility of dependencies: - `api` when it's part of it's public `api` - `implementation` when it's part of it's internal `implementation` - Remove unnecessary dependencies in build.gradle.kts files - Remove unnecessary dependencies provided by plugins - Remove unnecessary applied plugins (i.e. roborazzi) - Sort dependencies in `build.gradle.kts` - Delete unused entries in `libs.versions.toml`	2 years ago
Simon Marquis	caa482bc71	Kotlinify codebase - Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)	2 years ago
Adetunji Dahunsi	0287af8d9a	Merge pull request #947 from android/tj/staggered-grid-feed Use lazy vertical staggered grid in feed to maximize space utilization	2 years ago
Don Turner	a381d13199	Merge pull request #958 from McGalanes/main Use typesafe project accessors	2 years ago
Melwin Magalhaes	6247712064	Add convention plugins to version catalogs	2 years ago
Melwin Magalhaes	b1266dc05a	Use typesafe project accessors for project modules	2 years ago
dahunsi	03d2455f41	Use lazy vertical staggered grid in feed to maximize space utilization Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926	2 years ago
Simon Marquis	b2cd980170	Merge remote-tracking branch 'origin/main' into resource-prefix	2 years ago
Simon Marquis	ebfe01affd	Enforce `resourcePrefix` on Android library modules ``` :ui-test-hilt-manifest -> ui_test_hilt_manifest_ :core:analytics -> core_analytics_ :core:common -> core_common_ :core:data -> core_data_ :core:data-test -> core_data_test_ :core:database -> core_database_ :core:datastore -> core_datastore_ :core:datastore-test -> core_datastore_test_ :core:designsystem -> core_designsystem_ :core:domain -> core_domain_ :core:network -> core_network_ :core:notifications -> core_notifications_ :core:testing -> core_testing_ :core:ui -> core_ui_ :feature:bookmarks -> feature_bookmarks_ :feature:foryou -> feature_foryou_ :feature:interests -> feature_interests_ :feature:search -> feature_search_ :feature:settings -> feature_settings_ :feature:topic -> feature_topic_ :sync:sync-test -> sync_test_ :sync:work -> sync_work_ ```	2 years ago
Simon Marquis	a33dafccad	Migrate from `java` to `kotlin` sourceSet directory	2 years ago
Adetunji Dahunsi	4716c7f841	Merge pull request #913 from hoangchungk53qx1/main Refactor Search Feature	2 years ago
hoangchungk53qx1	66eafdc38b	format modification for screen search	2 years ago
Milosz Moczkowski	374808c284	Merge pull request #847 from SilviaGarciaBouza/wrong_color_in_dark_mode Added TextStyle color for ClickableText	2 years ago
hoangchungk53qx1	70498dd6e3	separate function logEvent for search triggered	2 years ago
hoangchungk53qx1	9cb20db93a	separate function logEvent for search triggered	2 years ago
hoangchungk53qx1	c52c4b88cd	replace object with data object in search feature, simple format code for the reader	2 years ago
hoangchungk53qx1	cd30ecf359	replace object with data object in search feature, simple format code for the reader	2 years ago
Don Turner	492697ce6b	Merge pull request #873 from SimonMarquis/misc-warnings Fix miscellaneous warnings	2 years ago
Adetunji Dahunsi	ec53d03854	Merge pull request #722 from android/tj/scrollbars Add scrollbars to app	3 years ago
Simon Marquis	4bdc9705af	Fix miscellaneous warnings - Remove unused namespace declaration - Collapse empty manifest tags - Remove redundant qualifier name - Remove redundant suppression	3 years ago
Simon Marquis	995d7b643f	Add missing full stop in `search_not_ready` string	3 years ago
TJ Dahunsi	e13e84c155	Replace usages of 'displacement' to 'moved' in parameter names Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a	3 years ago
TJ Dahunsi	eeb4973265	PR feedback Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f	3 years ago
TJ Dahunsi	bdf3ee3cb0	PR feedback Change-Id: Ie22aa3c7fdf4c8ca8d8118837cfd279de8c6d80b	3 years ago
TJ Dahunsi	cb1d50e65e	Even better names Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65	3 years ago
Silvia García Bouza	0016b10037	Added TextStyle color for ClickableText	3 years ago
Milosz Moczkowski	9197b332c4	Merge pull request #825 from android/refactor/interest_item Refactor InterestsItem to a Material3 ListItem	3 years ago
Miłosz Moczkowski	445c18a803	Refactor InterestsItem to Material3 ListItem Change-Id: I12adc8820964aecd97ea0b4e22ae13e95e1428ab	3 years ago
Simon Marquis	40b5248302	Replace deprecated method `TextFieldDefaults.textFieldColors` ``` TextFieldColors' is deprecated. Renamed to `TextFieldDefaults.colors` with additional parameters to controlcontainer color based on state. ```	3 years ago
Don Turner	aae307ee08	Fix spotless Change-Id: I84da36ba957cb74f9fb4479e81d714c2d8928a01	3 years ago
Don Turner	6343b831b9	Use NoOpAnalyticsHelper for tests Change-Id: I44657037f8f7ec6e38bcc3901e235ceab8c71237	3 years ago
Don Turner	0e40e26f22	Add analytics for search queries Change-Id: If5290a903afb928fc1c3aaa66a52d2f182aba118	3 years ago
Takeshi Hagikura	6a8736d4d0	Improvement in the Search screen (#717 ) Combine the search result of topics and news resources in one LazyVerticalGrid so that topics don't get in the way. Before this change, the result of topics created a LazyColumn and the result of news resources created the LazyVerticalGrid separately that made the situation where there were two separete vertical scrolling lists.	3 years ago
Takeshi Hagikura	b3cdc172cd	Implement search feature (#685 ) Implement search feature - Add a feature module named "search" - Add a SearchScreen that is navigated by tapping the search icon at the top left corner - Add a data layer that takes care of populating the *Fts tables and querying them by a search query - Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen The SearchScreen has following features: - The user is able to type the search query in the TextField - The search result is displayed as the user types - When the search result is clicked, it navigates to: - The InterestsScreen when a topic is clicked - Chrome custom tab with the URL of the clicked news resource - When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches - Latest recent searches are displayed in the SearchScreen	3 years ago

42 Commits (bug1192)