328 Commits (bug1192)

Author	SHA1	Message	Date
Melwin Magalhaes	b1266dc05a	Use typesafe project accessors for project modules	10 months ago
tunjid	b2498c763f	🤖 Updates screenshots	10 months ago
Simon Marquis	b2cd980170	Merge remote-tracking branch 'origin/main' into resource-prefix	10 months ago
Simon Marquis	faf42aa133	Merge remote-tracking branch 'origin/main' into issue-945	10 months ago
kimdowoo	bc56ba79bc	Add Test for Saved Top Level Destination	10 months ago
Don Turner	e40fb7925d	Merge pull request #779 from SimonMarquis/java-to-kotlin-sourceset ... Migrate from `java` to `kotlin` sourceSet directory	10 months ago
Simon Marquis	ebfe01affd	Enforce `resourcePrefix` on Android library modules ... ``` :ui-test-hilt-manifest -> ui_test_hilt_manifest_ :core:analytics -> core_analytics_ :core:common -> core_common_ :core:data -> core_data_ :core:data-test -> core_data_test_ :core:database -> core_database_ :core:datastore -> core_datastore_ :core:datastore-test -> core_datastore_test_ :core:designsystem -> core_designsystem_ :core:domain -> core_domain_ :core:network -> core_network_ :core:notifications -> core_notifications_ :core:testing -> core_testing_ :core:ui -> core_ui_ :feature:bookmarks -> feature_bookmarks_ :feature:foryou -> feature_foryou_ :feature:interests -> feature_interests_ :feature:search -> feature_search_ :feature:settings -> feature_settings_ :feature:topic -> feature_topic_ :sync:sync-test -> sync_test_ :sync:work -> sync_work_ ```	10 months ago
Simon Marquis	a33dafccad	Migrate from `java` to `kotlin` sourceSet directory	10 months ago
Simon Marquis	49a2fb5272	Fix wrong configuration name, leaking `work-testing` to runtime classpath ... Typo introduced recently when Roborazzi was added to the project: 886158d3cb (diff-8cff73265af19c059547b76aca8882cbaa3209291406f52df1dafbbc78e80c46)	10 months ago
Simon Marquis	03ba943632	Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication` ... - Prevent logging multiple times (because of `onResume()` callback) - Remove unnecessary io dispatcher: `ListenableFuture<T>.await()` is already main-safe and prevent acquiring io slot. - Merge comments into a single javadoc comment on the `ProfileVerifierLogger` type. - Add proper javadoc format with markdown specific blocks. - Update logs & tag to be more uniform. Closes #945	10 months ago
Jose Alcérreca	151f877bbe	Adds screenshot tests to :core:designsystem (#931) ... * WIP: Adds screenshot tests to :core:designsystem Change-Id: I0672845feba4064652dd8d60f07047b87864e121 * 🤖 Updates screenshots * Creates tests for more components and cleans up Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22 * WIP: More cleanup and more combinations of themes Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523 * Added the rest of the screenshot tests for designsystem Change-Id: Ic427db5491910781c038882055524e3f3dbed194 * Some more cleanup Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180 * Spotless Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6 * 🤖 Updates screenshots * ScreenshotHelper cleanup Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0	11 months ago
Milosz Moczkowski	851ca6388e	Merge pull request #868 from SimonMarquis/patch-4 ... Handle topic clicks from all destinations	11 months ago
Jose Alcérreca	886158d3cb	Adds Screenshot testing with Roborazzi (#876) ... * Adds screenshot tests using Roborazzi (Robolectric Native Graphics) - Adds Roborazzi to convention plugins - Adds Screenshot helper in :core-testing - Creates screenshot suites for :app and :feature-foryou * CI and spotless * Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier * CI: Moves local tests to their own step * CI: Adds --rerun to screenshot task * CI: Moves screenshots before local tests * CI: Fixes wrong if statement in workflow * CI WIP: trying to trigger the push step * CI: Re-enables roborazzi verification * Fixes flaky screenshot tests by setting LocalInspectionMode on * CI: screenshot commits now use the original author intead of bot account * CI: Disables globbing because file_pattern didn't work * CI: Trying new file pattern for png files * CI: Adds a check for forks * 🤖 Updates screenshots * Code review: toml cleanup, comments * Use new github.event.pull_request.head.repo.fork Co-authored-by: Simon Marquis <contact@simon-marquis.fr> * Uses Robolectric qualifiers to set the dpi, adds section to README * Spotless * Delegates creation of repository to Hilt in test * Revert "Use new github.event.pull_request.head.repo.fork" * 🤖 Updates screenshots * Empty commit to trigger GHA on main branch * Makes time zones deterministic in screenshot tests * Increases GMD timeout to 90m, but it has to be reduced --------- Co-authored-by: Simon Marquis <contact@simon-marquis.fr>	11 months ago
Don Turner	e96e54f7de	Merge pull request #806 from SimonMarquis/objenesis ... Remove forced resolution strategy	11 months ago
Simon Marquis	b7799f0475	Convert 'sealed' sub-object to 'data object'	12 months ago
Alex Vanyo	a3ee09ec3e	Merge pull request #817 from android/av/enable-edge-to-edge ... Switch to new Activity.enableEdgeToEdge	12 months ago
Simon Marquis	d8a6d0de13	Replace NiaNetworkDataSource with TopicsRepository ... to be closer to the actual source of data used by the instrumented app.	12 months ago
Simon Marquis	57f3700980	Select last topic by name instead of a random one	12 months ago
Simon Marquis	64f81751b3	Handle topic clicks from all destinations ... Closes #865	12 months ago
Alex Vanyo	2b218b97d9	Switch to new Activity.enableEdgeToEdge ... Change-Id: I9bbb7b2d116099524525619714ef18448e707c4f	12 months ago
Simon Marquis	0a1f333fc6	Update NavigationTest.kt	12 months ago
Simon Marquis	bf5fdb4cf8	Update NavigationTest.kt	12 months ago
Simon Marquis	250850cf9b	Remove hardcoded topic names in `NavigationTest.kt`	12 months ago
Don Turner	654944430d	Fix for Retrofit R8 issue, bump version to 0.1.2 ... Change-Id: Ia90d693731c95248211b12b1ce2e9dfab0ecf34c	12 months ago
Márton Braun	56389cb760	Merge pull request #752 from SimonMarquis/kotlin-1.9.0 ... Kotlin 1.9.0	1 year ago
Simon Marquis	ba82b06cc3	Fix Lint `RememberReturnType` issue with explicit type	1 year ago
Don Turner	7f62b725a6	Bump version to code=7, name=0.1.1 ... Change-Id: I2d8fa940dc5e4c14e3c9df650bc1f1432a330f02	1 year ago
Automerger	49a3f47fd8	Merge branch 'github/main'	1 year ago
Automerger	44c3c6d947	Merge branch 'github/main'	1 year ago
Milosz Moczkowski	04d3da39b9	Merge pull request #809 from SimonMarquis/launcher-icon-dark-theme ... Extract launcher icon tints and provide `-night` alternatives	1 year ago
Murat Yener	e96dac39b2	changed from ListenableFuture.get() to ListenableFuture.await()	1 year ago
Murat Yener	78ed9adca2	spotless fix	1 year ago
Murat Yener	7b5c0f2be8	Adds ProfileViewer to log the app's Baseline Profile Compilation Status	1 year ago
Simon Marquis	cf64e25ad5	Extract launcher icon tints and provide `-night` alternatives ... Implements #805	1 year ago
Simon Marquis	0a3069a0d8	Remove forced junit resolution strategy ... By looking at the Gradle scan's dependency tab, junit 4.12 is already replaced by 4.13.2. There is no need to manually force this at the configuration level.	1 year ago
Simon Marquis	d332f7b70d	Remove forced objenesis resolution strategy ... The linked issue is marked as resolved, and not able to reproduce the mentioned compilation error.	1 year ago
Automerger	8b024f0911	Merge branch 'github/main'	1 year ago
Simon Marquis	cb84082ae7	Merge branch 'main' into patch/proguard	1 year ago
Automerger	b434112bf2	Merge branch 'github/main'	1 year ago
James Rose	7826b4f5f2	Merge pull request #748 from SimonMarquis/fix/permissions ... Grant `POST_NOTIFICATIONS` permission in more instrumented tests	1 year ago
Automerger	1c2a833e6c	Merge branch 'github/main'	1 year ago
Miłosz Moczkowski	7b30720b25	Remove nested scaffold from the bookmarks screen ... Change-Id: Ie8b6f160d341156a6f9c02c0ca7f530095fb2950	1 year ago
Automerger	a91ba16a9c	Merge branch 'github/main'	1 year ago
Miłosz Moczkowski	479a2f00b0	Refactor icons	1 year ago
Automerger	9241b06e9f	Merge branch 'github/main'	1 year ago
Miłosz Moczkowski	ded8b109b9	Refactor custom notificationDot modifier ... Change-Id: Ife24492a495b111f111a8bd16f21b7ebd469e5aa	1 year ago
Simon Marquis	8f41a6b3ab	Cleanup proguard configuration ... - Remove custom KotlinX Serialization config as it's already provided, see https://github.com/Kotlin/kotlinx.serialization#android. - Delete empty config files.	1 year ago
Simon Marquis	823c4db201	Grant `POST_NOTIFICATIONS` permission in more instrumented tests ... Continues the work initiated in #738. Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.	1 year ago
Automerger	0c2e01bf4e	Merge branch 'github/main'	1 year ago
Miłosz Moczkowski	fc3d0ced20	Replace hardcoded license file with OSS licenses plugin ... Change-Id: I4427fd5d7b7abd8a2912a41f61ffedfac4af9d6a	1 year ago
Automerger	4eaad4c0a6	Merge branch 'github/main'	1 year ago
James Rose	a68eedebfa	Merge pull request #713 from android/jr/settings-dialog-state ... Save the showSettingsDialog flag in instance state	1 year ago
James Rose	62a77321d3	Save the showSettingsDialog flag in instance state ... This prevents the settings dialog from being dismissed when the device is rotated.	1 year ago
Don Turner	0829cb73f7	Bump version name to 0.1.0 (versionCode 6) ... Change-Id: I880683a37b4324f91499eeb47b418ab5e2d1242b	1 year ago
TJ Dahunsi	ef97cb941c	Route notification deep link through for you screen	1 year ago
Milosz Moczkowski	553f55f978	Merge pull request #679 from SimonMarquis/patch-3 ... Simplify String resource loading in `NavigationTest.kt`	1 year ago
Simon Marquis	1341f7c2c5	Replace unused variable with simpler method calls	1 year ago
Simon Marquis	1921c6544d	Replace deprecated methods	1 year ago
Don Turner	e1ae12129a	Merge pull request #662 from android/av/agp-8.0 ... Update to AGP 8.0	1 year ago
Takeshi Hagikura	b3cdc172cd	Implement search feature (#685) ... Implement search feature - Add a feature module named "search" - Add a SearchScreen that is navigated by tapping the search icon at the top left corner - Add a data layer that takes care of populating the *Fts tables and querying them by a search query - Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen The SearchScreen has following features: - The user is able to type the search query in the TextField - The search result is displayed as the user types - When the search result is clicked, it navigates to: - The InterestsScreen when a topic is clicked - Chrome custom tab with the URL of the clicked news resource - When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches - Latest recent searches are displayed in the SearchScreen	1 year ago
Simon Marquis	3a810f015b	Remove unused variables	1 year ago
Simon Marquis	091abad348	Simplify String resource loading in NavigationTest.kt	1 year ago
James Rose	b49767a88c	Rename getUserNewsResources to observeAll	1 year ago
Alex Vanyo	96a0449ba9	Add dontwarn for proguard rules ... Change-Id: I316513bd13b30cfcdbde0caba1d9c669815601f2	1 year ago
James Rose	57c13d84bd	Incorporate code review changes: Move UserNewsResourceRepository to data ... module; move UserNewsResource to model module. Implement unread dot for bookmarked articles. Keep the flows cold in UserNewsResourceRepository.	1 year ago
James Rose	ebfbb5bafd	Display unread state on the news feed and bottom nav bar ... When a news resource is unread, display a dot on its card in the news feed. When the For You section has unread resources, display a dot on its icon in the navigation bar. Update the read status when a resource is opened.	1 year ago
AlfianHanantio	bcd4a6de59	Remove redundant code block for managed virtual device creation	1 year ago
Alex Vanyo	01b5f34eb3	Update to Compose Material 3 1.1.0-alpha06 ... Change-Id: I6399358ad85254243b5aff547e31e3abe92fb6ed	1 year ago
Alex Vanyo	874c2d1487	Merge pull request #561 from SimonMarquis/update/androidx-lifecycle ... Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05	1 year ago
Caren	6a5feb767e	Merge pull request #582 from yschimke/loaders ... Improve network pooling and avoid startup image fetches.	1 year ago
Simon Marquis	4d4f7d4a15	Merge remote-tracking branch 'origin/main' into update/androidx-lifecycle	1 year ago
Yuri Schimke	9e399b69ea	Improve network pooling and avoid startup image fetches. ... Change-Id: If747fb0833d31ce7c9bedffd400160e979bc945e	1 year ago
Don Turner	75f8fc7e08	Bump versionCode to 5 ... Change-Id: I4d6dc6b8d1a903172b7f11ab6166f6c631b1319b	1 year ago
Don Turner	79da80756e	Merge "Remove AD_ID permission" into main	1 year ago
Don Turner	11a4bbaa48	Remove AD_ID permission ... Change-Id: Iaf691c8ff1e8fbbbcd39b068d8bfdc29c8f6a58c	1 year ago
Don Turner	4284e6912e	Merge remote-tracking branch 'github/main' into feb9automerger ... * github/main: Bump version to 4 Remove unused DropdownMenu component Route topic chip tap events up to NiaNavHost Apply suggestions from code review Migrate custom room configuration into a convention plugin Update docs/ArchitectureLearningJourney.md - User action follow topic Update docs/ArchitectureLearningJourney.md - Writing data Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea	1 year ago
Don Turner	d80668407a	Bump version to 4	1 year ago
Márton Braun	322ff63dbc	Route topic chip tap events up to NiaNavHost ... Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7	1 year ago
Don Turner	e3e33d8497	Merge "Add Firebase analytics. See go/nia-firebase-services." into main	1 year ago
Don Turner	2a4d0434a5	Add Firebase analytics. See go/nia-firebase-services. ... Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689	1 year ago
Automerger	6a12392f0b	Merge branch 'github/main'	1 year ago
Simon Marquis	f9a3533df3	Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05 ... > `Transformations` is now written in Kotlin. This is a *source incompatible change* for those classes written in Kotlin that were directly using syntax such as `Transformations.map` > Kotlin code *must* now use the Kotlin extension method syntax that was previously only available when using `lifecycle-livedata-ktx`. > The `collectAsStateWithLifecycle()` APIs of `lifecycle-runtime-compose` are no longer in experimental status. (I09d42, b/258835424) Changelog: https://developer.android.com/jetpack/androidx/releases/lifecycle#2.6.0-alpha05	1 year ago
Alex Vanyo	b72d0fe1af	Fix settings dialog dismissed test on non-portrait phones ... Change-Id: I15ed475915fdef198029db2713b6f619da374cc7	1 year ago
Automerger	2bb2d0fb15	Merge branch 'github/main'	1 year ago
Alex Vanyo	9b6695d8dd	Remove unused import ... Change-Id: I426995db727995c7af6d34082593b078756a3f9d	1 year ago
Alex Vanyo	b4de09d0b2	Use only width to determine navigation UI ... Change-Id: Icad00b9a3eecac9762f6c6b7c3790e8cf1c161d6	1 year ago
Automerger	80cb70ae2d	Merge branch 'github/main'	1 year ago
Automerger	6371cda677	Merge branch 'github/main'	1 year ago
Márton Braun	819dd494ad	Run Spotless to add trailing commas (and apply other rule updates) ... Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209	1 year ago
Angie Sasmita	cfbf782613	Merge pull request #542 from android/as/dynamic-color-option ... Add dynamic color option in settings for API >=32	1 year ago
Automerger	8dd9abd6ac	Merge branch 'github/main'	1 year ago
mlykotom	6b48b355cc	Merge branch 'main' into tm/fix-benchmarks-no-people ... Change-Id: I94ca19fad5527c11a2f0f28cc43a23ab22f419a7	1 year ago
Automerger	ebb070c73b	Merge branch 'github/main'	2 years ago
Mohsen Rzna	46c1d510d4	Android-CI workflow -> GMD refactor (#537) ... This PR is about updating the operating system to macOS-12 as the previous one was going to be deprecated, as well as updating the checkout to v3 to avoid the warnings in the panel; adding setup SDK action to accept the license which was missing from the beginning. I also added imports instead of adding them directly with the codes. As a reference, there was another PR with a similar topic, but it wasn't complete: #483	2 years ago
Angie Sasmita	6046f6e943	Add dynamic color option in settings for API >=32 ... Change-Id: Ib42c1cbd0208e98ef7610a1c8aca5d721aa464e6	2 years ago
Automerger	0aa17b5433	Merge branch 'github/main'	2 years ago
Don Turner	0365658935	Merge pull request #525 from hp902/patch/fix ... Coil reference url fixed	2 years ago
Ben Weiss	f316be1d69	Add Firebase dependencies ... This sets up the project for using Firebase Crashlytics and Performance Monitoring. Change-Id: I8d14cfd2e5c2ba1911f2c3175adc20d6714addb6	2 years ago
Takeshi Hagikura	4633609930	Introduce GMD + ATD (#479) ... Introduce Gradle Managed Device definitions to modules that have instrumented tests. At the moment, defining it as a convention plugin isn't possible due to the bug. That bug is now fixed and will be included in Android Studio Flamingo. Once Flamingo becomes stable, convert the GMD definitions as a convention plugin (#523) Change-Id: I0866369e3d0bbe148ca5ec1f92bad59239a347b8	2 years ago
Harshit Pandey	c96ff9e3c8	Coil refrence url fixed	2 years ago