613 Commits (adaptive-previews-device-classes)

Author	SHA1	Message	Date
Andrea Severi	af9306c2dc	Remove API 23+ connectivity check	5 months ago
Don Turner	6b621cc008	Fix spotless	5 months ago
Don Turner	e50a9c1b30	Scope ViewModels to navigation entries. ... Add `rememberViewModelStoreNavEntryDecorator` to the list of decorators for `NavEntry` instances. This enables support for `ViewModel` instances within the navigation component.	5 months ago
Don Turner	fb13fd73ca	Refactor Navigator goUp to clearSubStack ... Renamed the `goUp` method to `clearSubStack` to more accurately reflect that its function is to clear the sub-stack.	5 months ago
Don Turner	d5998c9c51	Refactor navigation routes to NavKeys ... This commit refactors the navigation implementation by renaming all `...Route` classes to `...NavKey`. This change provides more descriptive and consistent naming for navigation keys across the codebase. Key changes include: * Renamed `BookmarksRoute` to `BookmarksNavKey` * Renamed `ForYouRoute` to `ForYouNavKey` * Renamed `InterestsRoute` to `InterestsNavKey` * Renamed `TopicRoute` to `TopicNavKey` * Renamed `SearchRoute` to `SearchNavKey` * Updated all associated feature modules, tests, and UI components to use the new `NavKey` names. * Removed obsolete test utilities and mock providers related to the old navigation setup. * Deleted outdated dependency graph images and their corresponding `README.md` files from feature modules.	5 months ago
Don Turner	92c5b1ff34	More NavigationState refactoring. Fix compilation errors.	5 months ago
Don Turner	6b5069b670	Refactor NavigationState and make tests pass	5 months ago
Don Turner	24c2a13a13	WIP remove DI 2	5 months ago
Don Turner	09248a9885	WIP remove DI	5 months ago
Don Turner	c32f3ba480	Refactor navigation state management ... This commit refactors the navigation state management by renaming `NiaNavigatorState` to `NavigationState` to make it more generic. Specific changes include: - Renamed `NiaNavigatorState` to `NavigationState`. - Renamed `NiaNavigatorProvider` to `NavigationStateProvider`. - Updated all usages of the renamed classes, including `NiaNavigator`, `NiaBackStackViewModel`, and various tests. - Replaced the `getEntries()` extension function with `toEntries()`. - Added numerous TODOs to identify areas for future improvement, such as removing dependencies on `SavedStateHandle` for navigation state, simplifying event handling in ViewModels, and documenting the new navigation components.	5 months ago
Clara Fok	b521b4b46e	run spotless	5 months ago
Clara Fok	2395c5619d	Refactored NiaNavigator ... Made NiaNavigator a stateless class only responsibly for navigating and pop (modifying backStack). Navigation state now lives in a new class called NiaNavigatorState. The state of this class is saved and restored by ViewModel.	5 months ago
Clara Fok	0ca2107f36	Update feature ViewModels and tests	5 months ago
Clara Fok	c009f76d3b	Refactor Interests to ListDetailScene	5 months ago
Clara Fok	52afc2f1b7	Refactor app to navigation3	5 months ago
Clara Fok	befe747c2d	Add NiaBackStack and BackStack providers ... Bump agp versions and add navigation 3 dependency	5 months ago
Eric Schmidt	4be3bb9bb7	Update DevicePreviews.kt	5 months ago
Eric Schmidt	d233f6a773	Update core/ui/src/main/kotlin/com/google/samples/apps/nowinandroid/core/ui/DevicePreviews.kt ... Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>	5 months ago
Eric Schmidt	5916a4c923	feat: updates DevicePreviews.kt to use Devices constants	5 months ago
Don Turner	c5b604f72e	Merge pull request #1963 from SimonMarquis/mermaid-legend ... 🧜‍♀️ Mermaid Graphs legends	9 months ago
Simon Marquis	17162dab60	graphUpdate	9 months ago
Don Turner	f93da9c7a5	Merge pull request #1957 from mayokunyusuf/rtl-text-fix ... Fix punctuation and alignment for English text in RTL locales	9 months ago
Mayokun Yusuf	132bb0cbd7	RTL Spotless workflow fixed.	9 months ago
Mayokun Yusuf	8af63fc67b	RTL Spotless error fixed	9 months ago
Mayokun Yusuf	ae953da1f3	RTL Formatting	9 months ago
Simon Marquis	1c61be7b7b	Update color mapping ... | Type | Plugin ID | Color | |-------------|------------------------------------|------------------------| | Application | `nowinandroid.android.application` | `#CAFFBF` PastelGreen | | Feature | `nowinandroid.android.feature` | `#FFD6A5` PastelOrange | | Library | `nowinandroid.android.library` | `#9BF6FF` PastelBlue | | Test | `nowinandroid.android.test` | `#A0C4FF` PastelMauve | | JVM | `nowinandroid.jvm.library` | `#BDB2FF` PastelPurple | | Unknown | `?` | `#FFADAD` PastelRed |	9 months ago
Mayokun Yusuf	dd17e11538	Fix punctuation and alignment for English text in RTL locales by forcing LTR text direction and left alignment globally in typography"	9 months ago
Simon Marquis	c94e82849b	Merge remote-tracking branch 'origin/main' into graphs	10 months ago
Simon Marquis	e8dc43b58b	graphUpdate	10 months ago
Simon Marquis	e079e68815	Delete old graphs	10 months ago
Aurimas Liutikas	4d45004820	Upgrade to latest stable AGP 8.12.2 ... - Upgrades to a newer version of compose bom that pulls in newer versions of lint checks that work with AGP 8.12.2 - Bump the minSdk to 23 because compose now requires minSdk 23 - Update Navigation_fontScale2.png due to compose upgrade - Clean up BuildConfig set up since we already use Gradle 9.0.0 Test: ./gradlew build	10 months ago
Aurimas Liutikas	7ff1913855	Fixes host test tasks that were accidentally attemping to run ... Gradle 9.0.0 has the new enforcement that Test task runs that have sources but no tests run should fail. Without this change we get Execution failed for task ':core:analytics:testDemoDebugUnitTest'. > There are test sources present and no filters are applied, but the test task did not discover any tests to execute. This is likely due to a misconfiguration. Please check your test configuration. If this is not a misconfiguration, this error can be disabled by setting the 'failOnNoDiscoveredTests' property to false. We get this because before this change AndroidCompose was always setting isIncludeAndroidResources = true which generates a source to the test task and in the case of :core:analytics it is the only source. Instead of setting isIncludeAndroidResources in AndroidCompose move to setting it in relevant build.gradle.kts files (most already had it)	11 months ago
Aurimas Liutikas	abac757e9f	Add a comment for simplification	11 months ago
Aurimas Liutikas	149a345595	Move to a custom setup for BuildConfig.BACKEND_URL ... secrets gradle plugin is not Gradle project isolation compatible and is using deprecated AGP variant API. This change removes the usage by using a custom provider to set this value. Inspiration https://github.com/android/gradle-recipes/blob/agp-8.10/addCustomBuildConfigFields/build-logic/plugins/src/main/kotlin/CustomPlugin.kt https://github.com/android/nowinandroid/issues/1842 Test: ./gradlew core:network:assemble -> BuildConfig.java has correct value	11 months ago
hoangchungk53qx1	3c5026065d	Refactor: Replace list initialization with emptyList() for clarity	12 months ago
Alex Vanyo	689ef92e41	Merge pull request #1850 from ogapants/patch-1 ... Replace org.junit.Assert.assertEquals with kotlin.test.assertEquals for consistency	1 year ago
Simon Marquis	fe4ebce324	Replace deprecated `centerAlignedTopAppBarColors` with `topAppBarColors` ... from a recent material3 update: https://developer.android.com/jetpack/androidx/releases/compose-material3#1.4.0-alpha06	1 year ago
ogapants	ef4b2eaddd	Replace org.junit.Assert.assertEquals with kotlin.test.assertEquals for consistency	1 year ago
alexvanyo	af98b39223	🤖 Updates screenshots	1 year ago
alexvanyo	ed8745cef5	🤖 Updates screenshots	1 year ago
Don Turner	d35dc6cba8	Merge pull request #1799 from eyhgpt/patch-1 ... Update OfflineFirstNewsRepositoryTest.kt	1 year ago
Roberto Orgiu	dc7dd3fefd	Merge pull request #1702 from tiwiz/update-drag-and-drop ... Simplify Drag&Drop implementation	1 year ago
Don Turner	ef0d89e9fb	Update core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt	1 year ago
E Y H	fa532089e2	Update OfflineFirstNewsRepositoryTest.kt ... Remove the comments. A similar comment wasn't accpeted in my last PR.	1 year ago
EYH GPT	798b941b75	Update OfflineFirstNewsRepositoryTest.kt ... Improve the unit test to perform meaningful comparisons instead of merely comparing two empty lists.	1 year ago
Rob Orgiu	4885e92ba5	Reformat NewsResourceCard	1 year ago
Rob Orgiu	31c4f05872	Simplify Drag&Drop implementation	1 year ago
Rob Orgiu	8f75786c88	Merge remote-tracking branch 'refs/remotes/origin/main' into update-drag-and-drop ... # Conflicts: # gradle/libs.versions.toml	1 year ago
Don Turner	87c1f11dc3	Merge pull request #1786 from tobioyelekan/add-topicdao-test ... Add topicdao test	1 year ago
Don Turner	c6588b0e5c	Merge pull request #1798 from eyhgpt/patch-1 ... Update OfflineFirstTopicsRepositoryTest.kt	1 year ago