From f0960eb257e3f10aab4a682583b2a0c7da7d0fe3 Mon Sep 17 00:00:00 2001 From: necati Date: Sat, 30 Jul 2022 22:08:24 +0300 Subject: [PATCH] Put some modifiers in correct order to respect official API guidelines --- .../samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt | 4 ++-- .../apps/nowinandroid/feature/interests/InterestsScreen.kt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/feature-foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt b/feature-foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt index 8a97d2336..af0fbd83f 100644 --- a/feature-foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt +++ b/feature-foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt @@ -414,8 +414,8 @@ private fun SingleTopicButton( @Composable fun TopicIcon( - modifier: Modifier = Modifier, - imageUrl: String + imageUrl: String, + modifier: Modifier = Modifier ) { AsyncImage( // TODO b/228077205, show loading image visual instead of static placeholder diff --git a/feature-interests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsScreen.kt b/feature-interests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsScreen.kt index c0961919e..a437a4d95 100644 --- a/feature-interests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsScreen.kt +++ b/feature-interests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsScreen.kt @@ -49,9 +49,9 @@ import com.google.samples.apps.nowinandroid.core.ui.JankMetricDisposableEffect @OptIn(ExperimentalLifecycleComposeApi::class) @Composable fun InterestsRoute( - modifier: Modifier = Modifier, navigateToAuthor: (String) -> Unit, navigateToTopic: (String) -> Unit, + modifier: Modifier = Modifier, viewModel: InterestsViewModel = hiltViewModel() ) { val uiState by viewModel.uiState.collectAsStateWithLifecycle()