From 0daefa2db6b500f40a31bb8c882bb101b8ddc8c6 Mon Sep 17 00:00:00 2001 From: Pirate Cat Date: Tue, 7 Jan 2025 16:38:16 +1100 Subject: [PATCH 1/4] Update OfflineFirstTopicsRepositoryTest.kt Improve the unit test to do meaning comparisons instead of just comparing two empty lists. --- .../core/data/repository/OfflineFirstTopicsRepositoryTest.kt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt b/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt index d32f424d8..eb7ebbeec 100644 --- a/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt +++ b/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt @@ -67,6 +67,10 @@ class OfflineFirstTopicsRepositoryTest { @Test fun offlineFirstTopicsRepository_topics_stream_is_backed_by_topics_dao() = testScope.runTest { + // After sync, topicDao.getTopicEntities().first() and subject.getTopics().first() + // will return non-empty lists. + subject.syncWith(synchronizer) + assertEquals( topicDao.getTopicEntities() .first() From 7c8d7f554d4d98369fcd30a67a36a28f45d43161 Mon Sep 17 00:00:00 2001 From: Don Turner Date: Tue, 7 Jan 2025 12:42:57 +0000 Subject: [PATCH 2/4] Update core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt --- .../core/data/repository/OfflineFirstTopicsRepositoryTest.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt b/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt index eb7ebbeec..1ddf0d0d8 100644 --- a/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt +++ b/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt @@ -67,7 +67,6 @@ class OfflineFirstTopicsRepositoryTest { @Test fun offlineFirstTopicsRepository_topics_stream_is_backed_by_topics_dao() = testScope.runTest { - // After sync, topicDao.getTopicEntities().first() and subject.getTopics().first() // will return non-empty lists. subject.syncWith(synchronizer) From a49cc014c4f71355f4e1542790276465f7d1f753 Mon Sep 17 00:00:00 2001 From: Don Turner Date: Tue, 7 Jan 2025 12:43:02 +0000 Subject: [PATCH 3/4] Update core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt --- .../core/data/repository/OfflineFirstTopicsRepositoryTest.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt b/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt index 1ddf0d0d8..81bc28b16 100644 --- a/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt +++ b/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt @@ -67,7 +67,6 @@ class OfflineFirstTopicsRepositoryTest { @Test fun offlineFirstTopicsRepository_topics_stream_is_backed_by_topics_dao() = testScope.runTest { - // will return non-empty lists. subject.syncWith(synchronizer) assertEquals( From a101d6b4a1f32d7e5f6928e79b8a88b827c591fd Mon Sep 17 00:00:00 2001 From: Don Turner Date: Tue, 7 Jan 2025 12:48:49 +0000 Subject: [PATCH 4/4] Fix spotless --- .../core/data/repository/OfflineFirstTopicsRepositoryTest.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt b/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt index 81bc28b16..4050a6a39 100644 --- a/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt +++ b/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstTopicsRepositoryTest.kt @@ -68,7 +68,7 @@ class OfflineFirstTopicsRepositoryTest { fun offlineFirstTopicsRepository_topics_stream_is_backed_by_topics_dao() = testScope.runTest { subject.syncWith(synchronizer) - + assertEquals( topicDao.getTopicEntities() .first()