From 798b941b7537f430922bbebd30f9d563037eebec Mon Sep 17 00:00:00 2001 From: EYH GPT Date: Wed, 8 Jan 2025 11:02:02 +1100 Subject: [PATCH 1/3] Update OfflineFirstNewsRepositoryTest.kt Improve the unit test to perform meaningful comparisons instead of merely comparing two empty lists. --- .../core/data/repository/OfflineFirstNewsRepositoryTest.kt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt b/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt index 01111013f..ea0f07250 100644 --- a/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt +++ b/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt @@ -89,6 +89,10 @@ class OfflineFirstNewsRepositoryTest { @Test fun offlineFirstNewsRepository_news_resources_stream_is_backed_by_news_resource_dao() = testScope.runTest { + // After sync, newsResourceDao.getNewsResources().first() and + // subject.getNewsResources().first() will return non-empty lists. + subject.syncWith(synchronizer) + assertEquals( newsResourceDao.getNewsResources() .first() From fa532089e2f8a26f00469d9312e72e375fb338a0 Mon Sep 17 00:00:00 2001 From: E Y H Date: Wed, 8 Jan 2025 12:33:11 +1100 Subject: [PATCH 2/3] Update OfflineFirstNewsRepositoryTest.kt Remove the comments. A similar comment wasn't accpeted in my last PR. --- .../core/data/repository/OfflineFirstNewsRepositoryTest.kt | 2 -- 1 file changed, 2 deletions(-) diff --git a/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt b/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt index ea0f07250..e0ff97225 100644 --- a/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt +++ b/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt @@ -89,8 +89,6 @@ class OfflineFirstNewsRepositoryTest { @Test fun offlineFirstNewsRepository_news_resources_stream_is_backed_by_news_resource_dao() = testScope.runTest { - // After sync, newsResourceDao.getNewsResources().first() and - // subject.getNewsResources().first() will return non-empty lists. subject.syncWith(synchronizer) assertEquals( From ef0d89e9fbacb228855cf20e4901e6963f53964f Mon Sep 17 00:00:00 2001 From: Don Turner Date: Wed, 8 Jan 2025 14:09:38 +0000 Subject: [PATCH 3/3] Update core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt --- .../core/data/repository/OfflineFirstNewsRepositoryTest.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt b/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt index e0ff97225..7afcfb6df 100644 --- a/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt +++ b/core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt @@ -90,7 +90,6 @@ class OfflineFirstNewsRepositoryTest { fun offlineFirstNewsRepository_news_resources_stream_is_backed_by_news_resource_dao() = testScope.runTest { subject.syncWith(synchronizer) - assertEquals( newsResourceDao.getNewsResources() .first()