From e304cd3ee71cfeae5af4f570720f9aba1a726782 Mon Sep 17 00:00:00 2001 From: Simon Marquis Date: Thu, 12 May 2022 23:26:25 +0200 Subject: [PATCH 1/2] Reuse the same RoundedCornerShape for NewsResourceCardExpanded and NewsResourceHeaderImage Fixes #15 --- .../samples/apps/nowinandroid/core/ui/NewsResourceCard.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core-ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt b/core-ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt index 4242f2f33..270cdf998 100644 --- a/core-ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt +++ b/core-ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt @@ -141,7 +141,7 @@ fun NewsResourceHeaderImage( }, modifier = Modifier .fillMaxWidth() - .clip(RoundedCornerShape(topEnd = 24.dp, topStart = 24.dp)) + .clip(RoundedCornerShape(topEnd = 16.dp, topStart = 16.dp)) .height(180.dp), contentScale = ContentScale.Crop, model = headerImageUrl, From 3aec915be99c7d7c2aa2649cb2fbe7cb62bf026e Mon Sep 17 00:00:00 2001 From: Simon Marquis Date: Tue, 17 May 2022 19:48:49 +0200 Subject: [PATCH 2/2] Remove the clip modifier from NewsResourceHeaderImage --- .../google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/core-ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt b/core-ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt index 270cdf998..d31f988ce 100644 --- a/core-ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt +++ b/core-ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt @@ -141,7 +141,6 @@ fun NewsResourceHeaderImage( }, modifier = Modifier .fillMaxWidth() - .clip(RoundedCornerShape(topEnd = 16.dp, topStart = 16.dp)) .height(180.dp), contentScale = ContentScale.Crop, model = headerImageUrl,