From b924cfd6f27c5b0baca561e3ea513f5b0e101bca Mon Sep 17 00:00:00 2001 From: Simon Marquis Date: Wed, 16 Aug 2023 19:10:44 +0200 Subject: [PATCH] Restore `Unknown` type as empty `String` --- .../core/testing/data/NewsResourcesTestData.kt | 2 +- .../core/testing/data/UserNewsResourcesTestData.kt | 2 +- .../apps/nowinandroid/core/ui/NewsResourceCardTest.kt | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/NewsResourcesTestData.kt b/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/NewsResourcesTestData.kt index 1e31c320f..ef845dc58 100644 --- a/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/NewsResourcesTestData.kt +++ b/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/NewsResourcesTestData.kt @@ -65,7 +65,7 @@ val newsResourcesTestData: List = listOf( url = "https://developer.android.com/jetpack/androidx/versions/all-channel", headerImageUrl = "", publishDate = Instant.parse("2022-10-01T00:00:00.000Z"), - type = "Unknown", + type = "", topics = listOf(topicsTestData[2]), ), ) diff --git a/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/UserNewsResourcesTestData.kt b/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/UserNewsResourcesTestData.kt index ab6574f6a..97acad088 100644 --- a/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/UserNewsResourcesTestData.kt +++ b/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/UserNewsResourcesTestData.kt @@ -99,7 +99,7 @@ val userNewsResourcesTestData: List = UserData( url = "https://developer.android.com/jetpack/androidx/versions/all-channel", headerImageUrl = "", publishDate = Instant.parse("2022-10-01T00:00:00.000Z"), - type = "Unknown", + type = "", topics = listOf(topicsTestData[2]), ), userData = userData, diff --git a/core/ui/src/androidTest/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardTest.kt b/core/ui/src/androidTest/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardTest.kt index f40bf1f33..9f5f46099 100644 --- a/core/ui/src/androidTest/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardTest.kt +++ b/core/ui/src/androidTest/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardTest.kt @@ -61,13 +61,13 @@ class NewsResourceCardTest { } @Test - fun testMetaDataDisplay_withUnknownResource() { - val newsWithUnknownResourceType = userNewsResourcesTestData[3] + fun testMetaDataDisplay_withEmptyResourceType() { + val newsWithEmptyResourceType = userNewsResourcesTestData[3] var dateFormatted = "" composeTestRule.setContent { NewsResourceCardExpanded( - userNewsResource = newsWithUnknownResourceType, + userNewsResource = newsWithEmptyResourceType, isBookmarked = false, hasBeenViewed = false, onToggleBookmark = {}, @@ -75,11 +75,11 @@ class NewsResourceCardTest { onTopicClick = {}, ) - dateFormatted = dateFormatted(publishDate = newsWithUnknownResourceType.publishDate) + dateFormatted = dateFormatted(publishDate = newsWithEmptyResourceType.publishDate) } composeTestRule - .onNodeWithText(dateFormatted, substring = true) + .onNodeWithText(dateFormatted) .assertIsDisplayed() }