From 7f5e32d8992bc979878795a746b10321a3f91b72 Mon Sep 17 00:00:00 2001 From: necati Date: Sat, 30 Jul 2022 22:08:24 +0300 Subject: [PATCH 1/2] Put some modifiers in correct order to respect official API guidelines --- .../samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt | 4 ++-- .../apps/nowinandroid/feature/interests/InterestsScreen.kt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/feature-foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt b/feature-foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt index 8a97d2336..af0fbd83f 100644 --- a/feature-foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt +++ b/feature-foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt @@ -414,8 +414,8 @@ private fun SingleTopicButton( @Composable fun TopicIcon( - modifier: Modifier = Modifier, - imageUrl: String + imageUrl: String, + modifier: Modifier = Modifier ) { AsyncImage( // TODO b/228077205, show loading image visual instead of static placeholder diff --git a/feature-interests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsScreen.kt b/feature-interests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsScreen.kt index c0961919e..a437a4d95 100644 --- a/feature-interests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsScreen.kt +++ b/feature-interests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsScreen.kt @@ -49,9 +49,9 @@ import com.google.samples.apps.nowinandroid.core.ui.JankMetricDisposableEffect @OptIn(ExperimentalLifecycleComposeApi::class) @Composable fun InterestsRoute( - modifier: Modifier = Modifier, navigateToAuthor: (String) -> Unit, navigateToTopic: (String) -> Unit, + modifier: Modifier = Modifier, viewModel: InterestsViewModel = hiltViewModel() ) { val uiState by viewModel.uiState.collectAsStateWithLifecycle() From 6473f64d86fa5cee3c9e0de8963284cfd074a3bb Mon Sep 17 00:00:00 2001 From: wswon Date: Tue, 2 Aug 2022 21:41:21 +0900 Subject: [PATCH 2/2] Fix : class name Typo --- docs/ModularizationLearningJourney.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/ModularizationLearningJourney.md b/docs/ModularizationLearningJourney.md index 0a144ea2d..01e9b8750 100644 --- a/docs/ModularizationLearningJourney.md +++ b/docs/ModularizationLearningJourney.md @@ -183,7 +183,7 @@ Using the above modularization strategy, the Now in Android app has the followin Making network requests and handling responses from a remote data source. - RetrofitNiANetworkApi + RetrofitNiaNetworkApi @@ -209,7 +209,7 @@ Using the above modularization strategy, the Now in Android app has the followin Local database storage using Room. - NiADatabase
+ NiaDatabase
DatabaseMigrations
Dao classes