SoptlessApply

pull/2064/head
lihenggui 1 year ago
parent a8aaeee69f
commit 7512f3d347

@ -26,7 +26,7 @@ import org.koin.dsl.module
val jankStatsModule = module {
singleOf(::ProfileVerifierLogger)
factory { (activity : Activity) -> JankStats.createAndTrack(activity.window, providesOnFrameListener()) }
factory { (activity: Activity) -> JankStats.createAndTrack(activity.window, providesOnFrameListener()) }
}
fun providesOnFrameListener(): OnFrameListener = OnFrameListener { frameData ->
@ -35,4 +35,4 @@ fun providesOnFrameListener(): OnFrameListener = OnFrameListener { frameData ->
// We're currently logging this but would better report it to a backend.
Log.v("NiA Jank", frameData.toString())
}
}
}

@ -22,7 +22,6 @@ import com.google.samples.apps.nowinandroid.core.di.ApplicationScope
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.guava.await
import kotlinx.coroutines.launch
import org.koin.core.annotation.Single
/**
* Logs the app's Baseline Profile Compilation Status using [ProfileVerifier].

@ -167,8 +167,8 @@ class NiaAppState(
/**
* Stores information about navigation events to be used with JankStats
*/
//@Composable
//private fun NavigationTrackingSideEffect(navController: NavHostController) {
// @Composable
// private fun NavigationTrackingSideEffect(navController: NavHostController) {
// TrackDisposableJank(navController) { metricsHolder ->
// val listener = NavController.OnDestinationChangedListener { _, destination, _ ->
// metricsHolder.state?.putState("Navigation", destination.route.toString())
@ -180,4 +180,4 @@ class NiaAppState(
// navController.removeOnDestinationChangedListener(listener)
// }
// }
//}
// }

@ -54,7 +54,7 @@ import kotlin.uuid.Uuid
@Serializable internal object TopicPlaceholderRoute
// TODO: Remove @Keep when https://issuetracker.google.com/353898971 is fixed
//@Keep
// @Keep
@Serializable internal object DetailPaneNavHostRoute
fun NavGraphBuilder.interestsListDetailScreen() {

@ -28,7 +28,6 @@ import com.google.samples.apps.nowinandroid.core.data.test.repository.FakeTopics
import com.google.samples.apps.nowinandroid.core.data.test.repository.FakeUserDataRepository
import com.google.samples.apps.nowinandroid.core.data.util.NetworkMonitor
import com.google.samples.apps.nowinandroid.core.data.util.TimeZoneMonitor
import org.koin.core.qualifier.named
import org.koin.dsl.module
val testDataModule = module {

@ -16,10 +16,10 @@
package com.google.samples.apps.nowinandroid.core.data.di
import com.google.samples.apps.nowinandroid.core.data.util.NetworkMonitor
import com.google.samples.apps.nowinandroid.core.data.util.TimeZoneMonitor
import com.google.samples.apps.nowinandroid.core.data.util.ConnectivityManagerNetworkMonitor
import com.google.samples.apps.nowinandroid.core.data.util.NetworkMonitor
import com.google.samples.apps.nowinandroid.core.data.util.TimeZoneBroadcastMonitor
import com.google.samples.apps.nowinandroid.core.data.util.TimeZoneMonitor
import org.koin.core.module.dsl.singleOf
import org.koin.dsl.bind
import org.koin.dsl.module
@ -30,4 +30,4 @@ internal actual val networkMonitorModule = module {
internal actual val timeZoneMonitorModule = module {
singleOf(::TimeZoneBroadcastMonitor) bind TimeZoneMonitor::class
}
}

@ -26,7 +26,6 @@ import com.google.samples.apps.nowinandroid.core.database.dao.TopicFtsDao
import kotlinx.coroutines.runBlocking
import org.koin.core.annotation.ComponentScan
import org.koin.core.annotation.Module
import org.koin.core.qualifier.named
import org.koin.dsl.module
import org.koin.ksp.generated.module

@ -18,7 +18,6 @@ package com.google.samples.apps.nowinandroid.core.datastore.di
import com.google.samples.apps.nowinandroid.core.datastore.NiaPreferencesDataSource
import com.russhwolf.settings.Settings
import org.koin.core.qualifier.named
import org.koin.dsl.module
fun dataStoreModule() = module {

Loading…
Cancel
Save