From 91cdc39a536e6c0b4e297990bb99414473c5f353 Mon Sep 17 00:00:00 2001 From: Shrikant Badwaik Date: Tue, 18 Nov 2025 16:51:49 +0530 Subject: [PATCH] [Bug Fix]: Fixed text color updates on cards after light<>dark mode changes --- .../nowinandroid/core/ui/NewsResourceCard.kt | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/core/ui/src/main/kotlin/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt b/core/ui/src/main/kotlin/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt index 862aec6b2..7606d5ffe 100644 --- a/core/ui/src/main/kotlin/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt +++ b/core/ui/src/main/kotlin/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt @@ -46,6 +46,7 @@ import androidx.compose.material3.Text import androidx.compose.runtime.Composable import androidx.compose.runtime.CompositionLocalProvider import androidx.compose.runtime.getValue +import androidx.compose.runtime.key import androidx.compose.runtime.mutableStateOf import androidx.compose.runtime.remember import androidx.compose.runtime.setValue @@ -53,6 +54,7 @@ import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier import androidx.compose.ui.draganddrop.DragAndDropTransferData import androidx.compose.ui.graphics.Color +import androidx.compose.ui.graphics.toArgb import androidx.compose.ui.layout.ContentScale import androidx.compose.ui.platform.LocalInspectionMode import androidx.compose.ui.platform.testTag @@ -95,6 +97,31 @@ fun NewsResourceCardExpanded( onClick: () -> Unit, onTopicClick: (String) -> Unit, modifier: Modifier = Modifier, +) { + val onSurfaceColor = MaterialTheme.colorScheme.onSurface.toArgb() + + key(onSurfaceColor) { + NewsResourceCardContent( + userNewsResource = userNewsResource, + isBookmarked = isBookmarked, + hasBeenViewed = hasBeenViewed, + onToggleBookmark = onToggleBookmark, + onClick = onClick, + onTopicClick = onTopicClick, + modifier = modifier, + ) + } +} + +@Composable +private fun NewsResourceCardContent( + userNewsResource: UserNewsResource, + isBookmarked: Boolean, + hasBeenViewed: Boolean, + onToggleBookmark: () -> Unit, + onClick: () -> Unit, + onTopicClick: (String) -> Unit, + modifier: Modifier = Modifier, ) { val clickActionLabel = stringResource(R.string.core_ui_card_tap_action) val sharingLabel = stringResource(R.string.core_ui_feed_sharing)