From 67cdbe8c3dcb4679347cd615897880dd21eecec8 Mon Sep 17 00:00:00 2001 From: Saad Khan Date: Sun, 24 May 2026 16:44:51 +0500 Subject: [PATCH] Fix topic scrollbar item count for news loading and error states Account for TopicToolbar and TopicHeader when computing itemsAvailable for TopicUiState.Success. --- .../apps/nowinandroid/feature/topic/impl/TopicScreen.kt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/feature/topic/impl/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/topic/impl/TopicScreen.kt b/feature/topic/impl/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/topic/impl/TopicScreen.kt index d270535d1..7469c3a42 100644 --- a/feature/topic/impl/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/topic/impl/TopicScreen.kt +++ b/feature/topic/impl/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/topic/impl/TopicScreen.kt @@ -190,9 +190,9 @@ private fun topicItemsSize( TopicUiState.Error -> 2 // Toolbar and error message TopicUiState.Loading -> 1 // Loading bar is TopicUiState.Success -> when (newsUiState) { - NewsUiState.Error -> 0 // Nothing - NewsUiState.Loading -> 1 // Loading bar - is NewsUiState.Success -> 2 + newsUiState.news.size // Toolbar, header + NewsUiState.Error -> 3 // Toolbar, header, and error message + NewsUiState.Loading -> 3 // Toolbar, header, and loading indicator + is NewsUiState.Success -> 2 + newsUiState.news.size // Toolbar, header, and news items } }