From cd6ad7d575a82c6a88c9c8e0e13841743d3031e7 Mon Sep 17 00:00:00 2001
From: TJ Dahunsi <dahunsi@google.com>
Date: Thu, 25 May 2023 08:32:26 +0100
Subject: [PATCH 1/2] Ensure DAO exposes only reactive types

Change-Id: I8992ccf6525cd4c5ea9503d532b500e4d310b7fb
---
 .../data/repository/DefaultSearchContentsRepository.kt   | 9 ++++++++-
 .../nowinandroid/core/database/dao/NewsResourceDao.kt    | 4 ----
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/core/data/src/main/java/com/google/samples/apps/nowinandroid/core/data/repository/DefaultSearchContentsRepository.kt b/core/data/src/main/java/com/google/samples/apps/nowinandroid/core/data/repository/DefaultSearchContentsRepository.kt
index 40b170cbe..dc3caa143 100644
--- a/core/data/src/main/java/com/google/samples/apps/nowinandroid/core/data/repository/DefaultSearchContentsRepository.kt
+++ b/core/data/src/main/java/com/google/samples/apps/nowinandroid/core/data/repository/DefaultSearchContentsRepository.kt
@@ -20,6 +20,7 @@ import com.google.samples.apps.nowinandroid.core.database.dao.NewsResourceDao
 import com.google.samples.apps.nowinandroid.core.database.dao.NewsResourceFtsDao
 import com.google.samples.apps.nowinandroid.core.database.dao.TopicDao
 import com.google.samples.apps.nowinandroid.core.database.dao.TopicFtsDao
+import com.google.samples.apps.nowinandroid.core.database.model.PopulatedNewsResource
 import com.google.samples.apps.nowinandroid.core.database.model.asExternalModel
 import com.google.samples.apps.nowinandroid.core.database.model.asFtsEntity
 import com.google.samples.apps.nowinandroid.core.model.data.SearchResult
@@ -29,6 +30,7 @@ import kotlinx.coroutines.CoroutineDispatcher
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.combine
 import kotlinx.coroutines.flow.distinctUntilChanged
+import kotlinx.coroutines.flow.first
 import kotlinx.coroutines.flow.flatMapLatest
 import kotlinx.coroutines.flow.mapLatest
 import kotlinx.coroutines.withContext
@@ -45,7 +47,12 @@ class DefaultSearchContentsRepository @Inject constructor(
     override suspend fun populateFtsData() {
         withContext(ioDispatcher) {
             newsResourceFtsDao.insertAll(
-                newsResourceDao.getOneOffNewsResources().map { it.asFtsEntity() },
+                newsResourceDao.getNewsResources(
+                    useFilterTopicIds = false,
+                    useFilterNewsIds = false,
+                )
+                    .first()
+                    .map(PopulatedNewsResource::asFtsEntity),
             )
             topicFtsDao.insertAll(topicDao.getOneOffTopicEntities().map { it.asFtsEntity() })
         }
diff --git a/core/database/src/main/java/com/google/samples/apps/nowinandroid/core/database/dao/NewsResourceDao.kt b/core/database/src/main/java/com/google/samples/apps/nowinandroid/core/database/dao/NewsResourceDao.kt
index b5949c6d2..a05507a8b 100644
--- a/core/database/src/main/java/com/google/samples/apps/nowinandroid/core/database/dao/NewsResourceDao.kt
+++ b/core/database/src/main/java/com/google/samples/apps/nowinandroid/core/database/dao/NewsResourceDao.kt
@@ -65,10 +65,6 @@ interface NewsResourceDao {
         filterNewsIds: Set<String> = emptySet(),
     ): Flow<List<PopulatedNewsResource>>
 
-    @Transaction
-    @Query(value = "SELECT * FROM news_resources ORDER BY publish_date DESC")
-    suspend fun getOneOffNewsResources(): List<PopulatedNewsResource>
-
     /**
      * Inserts [entities] into the db if they don't exist, and ignores those that do
      */

From dcc36b0228cc0e99dda9983a661e2879bcd21e68 Mon Sep 17 00:00:00 2001
From: TJ Dahunsi <dahunsi@google.com>
Date: Thu, 25 May 2023 11:46:59 +0100
Subject: [PATCH 2/2] Fix tests

Change-Id: Ie6b62071d2023e3a7ffe1553ab606e3f6b386a5e
---
 .../nowinandroid/core/data/testdoubles/TestNewsResourceDao.kt   | 2 --
 1 file changed, 2 deletions(-)

diff --git a/core/data/src/test/java/com/google/samples/apps/nowinandroid/core/data/testdoubles/TestNewsResourceDao.kt b/core/data/src/test/java/com/google/samples/apps/nowinandroid/core/data/testdoubles/TestNewsResourceDao.kt
index 09af77213..d5d8932e7 100644
--- a/core/data/src/test/java/com/google/samples/apps/nowinandroid/core/data/testdoubles/TestNewsResourceDao.kt
+++ b/core/data/src/test/java/com/google/samples/apps/nowinandroid/core/data/testdoubles/TestNewsResourceDao.kt
@@ -67,8 +67,6 @@ class TestNewsResourceDao : NewsResourceDao {
                 result
             }
 
-    override suspend fun getOneOffNewsResources(): List<PopulatedNewsResource> = emptyList()
-
     override suspend fun insertOrIgnoreNewsResources(
         entities: List<NewsResourceEntity>,
     ): List<Long> {