From 58a42a6c85228291c2567d9349f95db44ed81d5f Mon Sep 17 00:00:00 2001 From: qamarelsafadi Date: Thu, 27 Jul 2023 22:04:26 +0300 Subject: [PATCH] feat: remove check if placeholder null and put a default placeholder if its not passed. --- .../core/designsystem/component/DynamicAsyncImage.kt | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/DynamicAsyncImage.kt b/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/DynamicAsyncImage.kt index ba5a890fe..94e65a780 100644 --- a/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/DynamicAsyncImage.kt +++ b/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/DynamicAsyncImage.kt @@ -26,9 +26,11 @@ import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier import androidx.compose.ui.graphics.ColorFilter import androidx.compose.ui.graphics.painter.Painter +import androidx.compose.ui.res.painterResource import androidx.compose.ui.unit.dp import coil.compose.AsyncImage import coil.compose.SubcomposeAsyncImage +import com.google.samples.apps.nowinandroid.core.designsystem.R import com.google.samples.apps.nowinandroid.core.designsystem.theme.LocalTintTheme /** @@ -44,12 +46,10 @@ fun DynamicAsyncImage( val iconTint = LocalTintTheme.current.iconTint SubcomposeAsyncImage( error = { - if (placeholder != null) { - Image( - painter = placeholder, - contentDescription = "placeholder image", - ) - } + Image( + painter = placeholder ?: painterResource(R.drawable.ic_placeholder_default), + contentDescription = "placeholder image", + ) }, model = imageUrl, contentDescription = contentDescription,