From c4689e2690218efa1f1102db0497e022d83dc19e Mon Sep 17 00:00:00 2001 From: Simon Marquis Date: Sat, 27 May 2023 10:40:43 +0100 Subject: [PATCH 1/8] Mention core-designsystem module in the modularization journey docs Closes #189 --- docs/ModularizationLearningJourney.md | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/docs/ModularizationLearningJourney.md b/docs/ModularizationLearningJourney.md index 81e35c436..f2f9b06bd 100644 --- a/docs/ModularizationLearningJourney.md +++ b/docs/ModularizationLearningJourney.md @@ -107,7 +107,7 @@ The Now in Android app contains the following types of modules: * `core:` modules - common library modules containing auxiliary code and specific dependencies that need to be shared between other modules in the app. These modules can depend on other core - modules, but they shouldn’t depend on feature nor app modules. + modules, but they shouldn't depend on feature nor app modules. * Miscellaneous modules - such as `sync`, `benchmark` and `test` modules, as well as `app-nia-catalog` - a catalog app for displaying our design system quickly. @@ -159,13 +159,21 @@ Using the above modularization strategy, the Now in Android app has the followin TopicsRepository
+ + core:designsystem + + Design system, tokens and icons. + + NiaTheme
+ NiaIcons + + core:ui - UI components, composables and resources, such as icons, used by different features. + UI components, composables and resources, used by different features. - NiaIcons
- NewsResourceCardExpanded + NewsResourceCardExpanded From b0ad7a1d12e50d08dba57e2f6e19953e935eccca Mon Sep 17 00:00:00 2001 From: Simon Marquis Date: Sat, 27 May 2023 10:41:54 +0100 Subject: [PATCH 2/8] fixup --- docs/ModularizationLearningJourney.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/ModularizationLearningJourney.md b/docs/ModularizationLearningJourney.md index f2f9b06bd..8409fbf4a 100644 --- a/docs/ModularizationLearningJourney.md +++ b/docs/ModularizationLearningJourney.md @@ -107,7 +107,7 @@ The Now in Android app contains the following types of modules: * `core:` modules - common library modules containing auxiliary code and specific dependencies that need to be shared between other modules in the app. These modules can depend on other core - modules, but they shouldn't depend on feature nor app modules. + modules, but they shouldn’t depend on feature nor app modules. * Miscellaneous modules - such as `sync`, `benchmark` and `test` modules, as well as `app-nia-catalog` - a catalog app for displaying our design system quickly. From 5637f3ece573662b8d7aab895826e81918182b0b Mon Sep 17 00:00:00 2001 From: Don Turner Date: Wed, 14 Jun 2023 22:41:33 +0100 Subject: [PATCH 3/8] Update docs/ModularizationLearningJourney.md --- docs/ModularizationLearningJourney.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/ModularizationLearningJourney.md b/docs/ModularizationLearningJourney.md index 8409fbf4a..46487d669 100644 --- a/docs/ModularizationLearningJourney.md +++ b/docs/ModularizationLearningJourney.md @@ -173,7 +173,7 @@ Using the above modularization strategy, the Now in Android app has the followin UI components, composables and resources, used by different features. - NewsResourceCardExpanded + NewsFeed NewsResourceCardExpanded From ed6bc1b37c6dc87c2609db5ce2a39e760b207788 Mon Sep 17 00:00:00 2001 From: Don Turner Date: Wed, 14 Jun 2023 22:41:42 +0100 Subject: [PATCH 4/8] Update docs/ModularizationLearningJourney.md --- docs/ModularizationLearningJourney.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/ModularizationLearningJourney.md b/docs/ModularizationLearningJourney.md index 46487d669..716b8c404 100644 --- a/docs/ModularizationLearningJourney.md +++ b/docs/ModularizationLearningJourney.md @@ -171,7 +171,7 @@ Using the above modularization strategy, the Now in Android app has the followin core:ui - UI components, composables and resources, used by different features. + Composite UI components and resources used by feature modules, such as the news feed. Unlike the `designsystem` module, it is dependent on the data layer since it renders models, like news resources. NewsFeed NewsResourceCardExpanded From 20d5442046a98572dbd238668e6067571009e60f Mon Sep 17 00:00:00 2001 From: Don Turner Date: Wed, 14 Jun 2023 22:41:51 +0100 Subject: [PATCH 5/8] Update docs/ModularizationLearningJourney.md --- docs/ModularizationLearningJourney.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/ModularizationLearningJourney.md b/docs/ModularizationLearningJourney.md index 716b8c404..94a3e90a7 100644 --- a/docs/ModularizationLearningJourney.md +++ b/docs/ModularizationLearningJourney.md @@ -165,7 +165,7 @@ Using the above modularization strategy, the Now in Android app has the followin Design system, tokens and icons. NiaTheme
- NiaIcons + NiaIcons NiaButton NiaTheme From 2d9b83dd033d5f6b392a43c0bcea229b29fd587f Mon Sep 17 00:00:00 2001 From: Don Turner Date: Wed, 14 Jun 2023 22:41:56 +0100 Subject: [PATCH 6/8] Update docs/ModularizationLearningJourney.md --- docs/ModularizationLearningJourney.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/ModularizationLearningJourney.md b/docs/ModularizationLearningJourney.md index 94a3e90a7..c272818ae 100644 --- a/docs/ModularizationLearningJourney.md +++ b/docs/ModularizationLearningJourney.md @@ -162,7 +162,7 @@ Using the above modularization strategy, the Now in Android app has the followin core:designsystem - Design system, tokens and icons. + Design system which includes Core UI components (many of which are customized Material 3 components), app theme and icons. The design system can be viewed by running the `app-nia-catalog` run configuration`. NiaTheme
NiaIcons NiaButton NiaTheme From dc0339036888b165b0cbfc77c859cde2c93a6325 Mon Sep 17 00:00:00 2001 From: Don Turner Date: Wed, 14 Jun 2023 22:42:29 +0100 Subject: [PATCH 7/8] Update docs/ModularizationLearningJourney.md --- docs/ModularizationLearningJourney.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/ModularizationLearningJourney.md b/docs/ModularizationLearningJourney.md index c272818ae..966ef4615 100644 --- a/docs/ModularizationLearningJourney.md +++ b/docs/ModularizationLearningJourney.md @@ -162,7 +162,7 @@ Using the above modularization strategy, the Now in Android app has the followin core:designsystem - Design system which includes Core UI components (many of which are customized Material 3 components), app theme and icons. The design system can be viewed by running the `app-nia-catalog` run configuration`. + Design system which includes Core UI components (many of which are customized Material 3 components), app theme and icons. The design system can be viewed by running the `app-nia-catalog` run configuration. NiaTheme
NiaIcons NiaButton NiaTheme From 8b526065f09e475460f2cb69b8ca7eeebe97764b Mon Sep 17 00:00:00 2001 From: Don Turner Date: Wed, 14 Jun 2023 22:42:55 +0100 Subject: [PATCH 8/8] Update docs/ModularizationLearningJourney.md --- docs/ModularizationLearningJourney.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/ModularizationLearningJourney.md b/docs/ModularizationLearningJourney.md index 966ef4615..da916912c 100644 --- a/docs/ModularizationLearningJourney.md +++ b/docs/ModularizationLearningJourney.md @@ -164,7 +164,7 @@ Using the above modularization strategy, the Now in Android app has the followin Design system which includes Core UI components (many of which are customized Material 3 components), app theme and icons. The design system can be viewed by running the `app-nia-catalog` run configuration. - NiaTheme
+ NiaIcons NiaButton NiaTheme