From 4a5cdcb0d208cd1651845c0ba263641cc947eeb6 Mon Sep 17 00:00:00 2001 From: kwakjoohyeong Date: Tue, 28 May 2024 17:16:48 +0900 Subject: [PATCH] Revert "refactor: tracking screen to lambda code" This reverts commit 9df53d50c0908483b8e3987a3a901bf3aeaf7254. --- .../apps/nowinandroid/interests/InterestsScreenTest.kt | 1 - .../nowinandroid/feature/interests/InterestsScreen.kt | 9 +-------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/feature/interests/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/interests/InterestsScreenTest.kt b/feature/interests/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/interests/InterestsScreenTest.kt index 702307ec4..a441f5a9d 100644 --- a/feature/interests/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/interests/InterestsScreenTest.kt +++ b/feature/interests/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/interests/InterestsScreenTest.kt @@ -114,7 +114,6 @@ class InterestsScreenTest { uiState = uiState, followTopic = { _, _ -> }, onTopicClick = {}, - trackScreenView = {}, ) } } diff --git a/feature/interests/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/interests/InterestsScreen.kt b/feature/interests/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/interests/InterestsScreen.kt index a16b04dad..468550878 100644 --- a/feature/interests/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/interests/InterestsScreen.kt +++ b/feature/interests/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/interests/InterestsScreen.kt @@ -52,9 +52,6 @@ fun InterestsRoute( }, highlightSelectedTopic = highlightSelectedTopic, modifier = modifier, - trackScreenView = { - TrackScreenViewEvent(screenName = "Interests") - }, ) } @@ -65,7 +62,6 @@ internal fun InterestsScreen( onTopicClick: (String) -> Unit, modifier: Modifier = Modifier, highlightSelectedTopic: Boolean = false, - trackScreenView: @Composable () -> Unit, ) { Column( modifier = modifier, @@ -91,7 +87,7 @@ internal fun InterestsScreen( is InterestsUiState.Empty -> InterestsEmptyScreen() } } - trackScreenView() + TrackScreenViewEvent(screenName = "Interests") } @Composable @@ -114,7 +110,6 @@ fun InterestsScreenPopulated( ), followTopic = { _, _ -> }, onTopicClick = {}, - trackScreenView = {}, ) } } @@ -129,7 +124,6 @@ fun InterestsScreenLoading() { uiState = InterestsUiState.Loading, followTopic = { _, _ -> }, onTopicClick = {}, - trackScreenView = {}, ) } } @@ -144,7 +138,6 @@ fun InterestsScreenEmpty() { uiState = InterestsUiState.Empty, followTopic = { _, _ -> }, onTopicClick = {}, - trackScreenView = {}, ) } }