Fix: Scope ViewModel to backStackEntry to ensure onCleared() is called

pull/2079/head
arpitdhoundiyal 5 months ago
parent 1253eb460c
commit 4531d7a7db

@ -16,6 +16,7 @@
package com.google.samples.apps.nowinandroid.feature.topic.impl
import android.util.Log
import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import com.google.samples.apps.nowinandroid.core.common.result.Result
@ -46,6 +47,7 @@ class TopicViewModel @AssistedInject constructor(
userNewsResourceRepository: UserNewsResourceRepository,
@Assisted val topicId: String,
) : ViewModel() {
val topicUiState: StateFlow<TopicUiState> = topicUiState(
topicId = topicId,
userDataRepository = userDataRepository,
@ -71,6 +73,7 @@ class TopicViewModel @AssistedInject constructor(
fun followTopicToggle(followed: Boolean) {
viewModelScope.launch {
userDataRepository.setTopicIdFollowed(topicId, followed)
}
}
@ -86,6 +89,7 @@ class TopicViewModel @AssistedInject constructor(
}
}
@AssistedFactory
interface Factory {
fun create(

@ -2,8 +2,8 @@
accompanist = "0.37.0"
androidDesugarJdkLibs = "2.1.4"
# AGP and tools should be updated together
androidGradlePlugin = "9.0.0"
androidTools = "32.0.0"
androidGradlePlugin = "9.0.1"
androidTools = "32.0.1"
androidxActivity = "1.9.3"
androidxAppCompat = "1.7.0"
androidxBrowser = "1.8.0"

Loading…
Cancel
Save