From 42878c5e8687bdd30814630ac01eeec0a60e1792 Mon Sep 17 00:00:00 2001 From: Ben Weiss Date: Mon, 6 Jun 2022 18:42:20 +0100 Subject: [PATCH] Move JankStats metric gathering further down This isn't the thing a developer should be focusing on when first opening the file. So moving it further down in the composable. --- .../samples/apps/nowinandroid/ui/NiaApp.kt | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaApp.kt b/app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaApp.kt index 20a2decb6..bedd20704 100644 --- a/app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaApp.kt +++ b/app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaApp.kt @@ -64,17 +64,6 @@ import com.google.samples.apps.nowinandroid.navigation.TopLevelDestination fun NiaApp(windowSizeClass: WindowSizeClass) { NiaTheme { val navController = rememberNavController() - JankMetricDisposableEffect(navController) { metricsHolder -> - val listener = NavController.OnDestinationChangedListener { _, destination, _ -> - metricsHolder.state?.addState("Navigation", destination.route.toString()) - } - - navController.addOnDestinationChangedListener(listener) - - onDispose { - navController.removeOnDestinationChangedListener(listener) - } - } val niaTopLevelNavigation = remember(navController) { NiaTopLevelNavigation(navController) @@ -124,6 +113,17 @@ fun NiaApp(windowSizeClass: WindowSizeClass) { } } } + JankMetricDisposableEffect(navController) { metricsHolder -> + val listener = NavController.OnDestinationChangedListener { _, destination, _ -> + metricsHolder.state?.addState("Navigation", destination.route.toString()) + } + + navController.addOnDestinationChangedListener(listener) + + onDispose { + navController.removeOnDestinationChangedListener(listener) + } + } } }