From 8a6572cffd867f03f6ccd287a202e97a7623f53a Mon Sep 17 00:00:00 2001 From: Don Turner Date: Mon, 13 May 2024 15:46:03 -0700 Subject: [PATCH 1/2] Made pull request instructions clearer --- .github/pull_request_template.md | 33 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 28ec373b7..f360c7f74 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,26 +1,25 @@ -_Thanks for submitting a pull request. Please include the following information._ +**DO NOT HIT SUBMIT WITHOUT READING THESE INSTRUCTIONS** -**What I have done and why** +## Instructions +Thanks for submitting a pull request. To accept your pull request we need you do a few things: + +**If this is your first pull request** -_Include a summary of what your pull request contains, and why you have made these changes._ +- [Sign the contributors license agreement](https://cla.developers.google.com/) -Fixes # +**Ensure tests pass and code is formatted correctly** -**How I'm testing it** +- Run local tests on the `DemoDebug` variant by running `./gradlew testDemoDebug` +- Fix code formatting: `./gradlew --init-script gradle/init.gradle.kts spotlessApply` -_Choose at least one:_ -- Unit tests -- UI tests -- Screenshot tests -- N/A _(provide justification)_ +**Add a description** -**Do tests pass?** -- [ ] Run local tests on `DemoDebug` variant: `./gradlew testDemoDebug` -- [ ] Check formatting: `./gradlew --init-script gradle/init.gradle.kts spotlessApply` +We need to know what you've done and why you've done it. Include a summary of what your pull request contains, and why you have made these changes. Include links to any relevant issues which it fixes. -**Is this your first pull request?** -- [ ] [Sign the CLA](https://cla.developers.google.com/) -- [ ] Run `./tools/setup.sh` -- [ ] Import the code formatting style as explained in [the setup script](/tools/setup.sh#L40). +[Here's an example](https://github.com/android/nowinandroid/pull/1257). +**NOW DELETE THIS LINE AND EVERYTHING ABOVE IT** + +**What I have done and why** +\ From 7c16da9961605234d94a1cfef84c9f5244fcb480 Mon Sep 17 00:00:00 2001 From: Don Turner Date: Mon, 13 May 2024 15:48:10 -0700 Subject: [PATCH 2/2] Update pull_request_template.md --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index f360c7f74..265ff2ba5 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,4 +1,4 @@ -**DO NOT HIT SUBMIT WITHOUT READING THESE INSTRUCTIONS** +**DO NOT CREATE A PULL REQUEST WITHOUT READING THESE INSTRUCTIONS** ## Instructions Thanks for submitting a pull request. To accept your pull request we need you do a few things: