Address comments from AI overlords

3 days ago · 315a56be47
parent dacf13ca7f
commit 315a56be47
37 changed files with 37 additions and 37 deletions
--- a/app-nia-catalog/src/main/AndroidManifest.xml
+++ b/app-nia-catalog/src/main/AndroidManifest.xml
@ -36,4 +36,4 @@
        </activity>
    </application>

-</manifest>
+</manifest>
--- a/app-nia-catalog/src/main/res/mipmap-anydpi-v26/ic_launcher.xml
+++ b/app-nia-catalog/src/main/res/mipmap-anydpi-v26/ic_launcher.xml
@ -18,4 +18,4 @@
    <background android:drawable="@drawable/ic_launcher_background"/>
    <foreground android:drawable="@drawable/ic_launcher_foreground"/>
    <monochrome android:drawable="@drawable/ic_launcher_foreground" />
-</adaptive-icon>
+</adaptive-icon>
--- a/app-nia-catalog/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml
+++ b/app-nia-catalog/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml
@ -18,4 +18,4 @@
    <background android:drawable="@drawable/ic_launcher_background"/>
    <foreground android:drawable="@drawable/ic_launcher_foreground"/>
    <monochrome android:drawable="@drawable/ic_launcher_foreground" />
-</adaptive-icon>
+</adaptive-icon>
--- a/app-nia-catalog/src/main/res/values/strings.xml
+++ b/app-nia-catalog/src/main/res/values/strings.xml
@ -16,4 +16,4 @@
 -->
 <resources>
    <string name="app_name">NiA Catalog</string>
-</resources>
+</resources>
--- a/app-nia-catalog/src/main/res/values/themes.xml
+++ b/app-nia-catalog/src/main/res/values/themes.xml
@ -16,4 +16,4 @@
 -->
 <resources>
    <style name="Theme.NiaCatalog" parent="android:Theme.Material.Light.NoActionBar" />
-</resources>
+</resources>
--- a/app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml
+++ b/app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml
@ -18,4 +18,4 @@
    <background android:drawable="@drawable/ic_launcher_background"/>
    <foreground android:drawable="@drawable/ic_launcher_foreground"/>
    <monochrome android:drawable="@drawable/ic_launcher_foreground" />
-</adaptive-icon>
+</adaptive-icon>
--- a/app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml
+++ b/app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml
@ -18,4 +18,4 @@
    <background android:drawable="@drawable/ic_launcher_background"/>
    <foreground android:drawable="@drawable/ic_launcher_foreground"/>
    <monochrome android:drawable="@drawable/ic_launcher_foreground" />
-</adaptive-icon>
+</adaptive-icon>
--- a/app/src/prod/AndroidManifest.xml
+++ b/app/src/prod/AndroidManifest.xml
@ -23,4 +23,4 @@
            android:name="firebase_analytics_collection_deactivated"
            android:value="false" />
    </application>
-</manifest>
+</manifest>
--- a/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/KotlinAndroid.kt
+++ b/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/KotlinAndroid.kt
@ -17,12 +17,10 @@
 package com.google.samples.apps.nowinandroid

 import com.android.build.api.dsl.CommonExtension
-import com.diffplug.gradle.spotless.SpotlessExtension
 import org.gradle.api.JavaVersion
 import org.gradle.api.Project
 import org.gradle.api.plugins.JavaPluginExtension
 import org.gradle.kotlin.dsl.assign
-import org.gradle.kotlin.dsl.apply
 import org.gradle.kotlin.dsl.configure
 import org.gradle.kotlin.dsl.dependencies
 import org.jetbrains.kotlin.gradle.dsl.JvmTarget
--- a/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Spotless.kt
+++ b/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Spotless.kt
@ -28,6 +28,7 @@ internal fun Project.configureSpotlessForAndroid() {
            target("src/**/*.xml")
            // Look for the first XML tag that isn't a comment (<!--) or the xml declaration (<?xml)
            licenseHeaderFile(rootProject.file("spotless/copyright.xml"), "(<[^!?])")
+            endWithNewline()
        }
    }
 }
@ -45,11 +46,13 @@ private fun Project.configureSpotlessCommon() {
                mapOf("android" to "true")
            )
            licenseHeaderFile(rootDir.resolve("spotless/copyright.kt"))
+            endWithNewline()
        }
        format("kts") {
            target("*.kts")
            // Look for the first line that doesn't have a block comment (assumed to be the license)
            licenseHeaderFile(rootDir.resolve("spotless/copyright.kts"), "(^(?![\\/ ]\\*).*$)")
+            endWithNewline()
        }
    }
 }
--- a/core/analytics/src/main/AndroidManifest.xml
+++ b/core/analytics/src/main/AndroidManifest.xml
@ -14,4 +14,4 @@
     See the License for the specific language governing permissions and
     limitations under the License.
 -->
-<manifest />
+<manifest />
--- a/core/common/build.gradle.kts
+++ b/core/common/build.gradle.kts
@ -22,4 +22,4 @@ dependencies {
    implementation(libs.kotlinx.coroutines.core)
    testImplementation(libs.kotlinx.coroutines.test)
    testImplementation(libs.turbine)
-}
+}
--- a/core/data/src/main/AndroidManifest.xml
+++ b/core/data/src/main/AndroidManifest.xml
@ -16,4 +16,4 @@
 -->
 <manifest xmlns:android="http://schemas.android.com/apk/res/android">
    <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
-</manifest>
+</manifest>
--- a/core/database/src/main/AndroidManifest.xml
+++ b/core/database/src/main/AndroidManifest.xml
@ -14,4 +14,4 @@
     See the License for the specific language governing permissions and
     limitations under the License.
 -->
-<manifest />
+<manifest />
--- a/core/datastore-test/src/main/AndroidManifest.xml
+++ b/core/datastore-test/src/main/AndroidManifest.xml
@ -14,4 +14,4 @@
     See the License for the specific language governing permissions and
     limitations under the License.
 -->
-<manifest />
+<manifest />
--- a/core/datastore/src/main/AndroidManifest.xml
+++ b/core/datastore/src/main/AndroidManifest.xml
@ -14,4 +14,4 @@
     See the License for the specific language governing permissions and
     limitations under the License.
 -->
-<manifest />
+<manifest />
--- a/core/designsystem/src/main/AndroidManifest.xml
+++ b/core/designsystem/src/main/AndroidManifest.xml
@ -14,4 +14,4 @@
     See the License for the specific language governing permissions and
     limitations under the License.
 -->
-<manifest />
+<manifest />
--- a/core/domain/build.gradle.kts
+++ b/core/domain/build.gradle.kts
@ -30,4 +30,4 @@ dependencies {
    implementation(libs.javax.inject)

    testImplementation(projects.core.testing)
-}
+}
--- a/core/domain/src/main/AndroidManifest.xml
+++ b/core/domain/src/main/AndroidManifest.xml
@ -14,4 +14,4 @@
     See the License for the specific language governing permissions and
     limitations under the License.
 -->
-<manifest />
+<manifest />
--- a/core/network/src/main/AndroidManifest.xml
+++ b/core/network/src/main/AndroidManifest.xml
@ -17,4 +17,4 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android">
    <uses-permission android:name="android.permission.INTERNET" />

-</manifest>
+</manifest>
--- a/core/notifications/src/main/res/drawable-anydpi-v24/core_notifications_ic_nia_notification.xml
+++ b/core/notifications/src/main/res/drawable-anydpi-v24/core_notifications_ic_nia_notification.xml
@ -28,4 +28,4 @@
          android:pathData="M17.6,11.48 L19.44,8.3a0.63,0.63 0,0 0,-1.09 -0.63l-1.88,3.24a11.43,11.43 0,0 0,-8.94 0L5.65,7.67a0.63,0.63 0,0 0,-1.09 0.63L6.4,11.48A10.81,10.81 0,0 0,1 20L23,20A10.81,10.81 0,0 0,17.6 11.48ZM7,17.25A1.25,1.25 0,1 1,8.25 16,1.25 1.25,0 0,1 7,17.25ZM17,17.25A1.25,1.25 0,1 1,18.25 16,1.25 1.25,0 0,1 17,17.25Z"
          android:fillColor="#FF000000"/>
  </group>
-</vector>
+</vector>
--- a/core/screenshot-testing/src/main/AndroidManifest.xml
+++ b/core/screenshot-testing/src/main/AndroidManifest.xml
@ -21,4 +21,4 @@
    Theme_Material_Light_NoActionBar is the base theme used by the production app.
    -->
    <application android:theme="@android:style/Theme.Material.NoActionBar" />
-</manifest>
+</manifest>
--- a/core/testing/src/main/AndroidManifest.xml
+++ b/core/testing/src/main/AndroidManifest.xml
@ -14,4 +14,4 @@
     See the License for the specific language governing permissions and
     limitations under the License.
 -->
-<manifest />
+<manifest />
--- a/core/ui/src/main/AndroidManifest.xml
+++ b/core/ui/src/main/AndroidManifest.xml
@ -14,4 +14,4 @@
     See the License for the specific language governing permissions and
     limitations under the License.
 -->
-<manifest />
+<manifest />
--- a/feature/bookmarks/api/build.gradle.kts
+++ b/feature/bookmarks/api/build.gradle.kts
@ -20,4 +20,4 @@ plugins {

 android {
    namespace = "com.google.samples.apps.nowinandroid.feature.bookmarks.api"
-}
+}
--- a/feature/bookmarks/impl/src/main/AndroidManifest.xml
+++ b/feature/bookmarks/impl/src/main/AndroidManifest.xml
@ -14,4 +14,4 @@
     See the License for the specific language governing permissions and
     limitations under the License.
 -->
-<manifest />
+<manifest />
--- a/feature/foryou/api/src/main/AndroidManifest.xml
+++ b/feature/foryou/api/src/main/AndroidManifest.xml
@ -14,4 +14,4 @@
     See the License for the specific language governing permissions and
     limitations under the License.
 -->
-<manifest />
+<manifest />
--- a/feature/foryou/api/src/main/res/values/strings.xml
+++ b/feature/foryou/api/src/main/res/values/strings.xml
@ -21,4 +21,4 @@
    <string name="feature_foryou_api_navigate_up">Navigate up</string>
    <string name="feature_foryou_api_onboarding_guidance_title">What are you interested in?</string>
    <string name="feature_foryou_api_onboarding_guidance_subtitle">Updates from topics you follow will appear here. Follow some things to get started.</string>
-</resources>
+</resources>
--- a/feature/foryou/impl/build.gradle.kts
+++ b/feature/foryou/impl/build.gradle.kts
@ -40,4 +40,4 @@ dependencies {

    androidTestImplementation(libs.bundles.androidx.compose.ui.test)
    androidTestImplementation(projects.core.testing)
-}
+}
--- a/feature/interests/api/build.gradle.kts
+++ b/feature/interests/api/build.gradle.kts
@ -20,4 +20,4 @@ plugins {

 android {
    namespace = "com.google.samples.apps.nowinandroid.feature.interests.api"
-}
+}
--- a/feature/interests/api/src/main/AndroidManifest.xml
+++ b/feature/interests/api/src/main/AndroidManifest.xml
@ -14,4 +14,4 @@
     See the License for the specific language governing permissions and
     limitations under the License.
 -->
-<manifest />
+<manifest />
--- a/feature/interests/api/src/main/res/drawable/feature_interests_api_ic_detail_placeholder.xml
+++ b/feature/interests/api/src/main/res/drawable/feature_interests_api_ic_detail_placeholder.xml
@ -52,4 +52,4 @@
        android:strokeColor="#8C4190"
        android:strokeLineCap="round"
        android:strokeWidth="2" />
-</vector>
+</vector>
--- a/feature/search/api/build.gradle.kts
+++ b/feature/search/api/build.gradle.kts
@ -25,4 +25,3 @@ android {
 dependencies {
    implementation(projects.core.domain)
 }
-
--- a/feature/search/impl/build.gradle.kts
+++ b/feature/search/impl/build.gradle.kts
@ -34,4 +34,4 @@ dependencies {

    androidTestImplementation(libs.bundles.androidx.compose.ui.test)
    androidTestImplementation(projects.core.testing)
-}
+}
--- a/feature/topic/api/build.gradle.kts
+++ b/feature/topic/api/build.gradle.kts
@ -22,4 +22,4 @@ plugins {

 android {
    namespace = "com.google.samples.apps.nowinandroid.feature.topic.api"
-}
+}
--- a/feature/topic/impl/build.gradle.kts
+++ b/feature/topic/impl/build.gradle.kts
@ -35,4 +35,4 @@ dependencies {

    androidTestImplementation(libs.bundles.androidx.compose.ui.test)
    androidTestImplementation(projects.core.testing)
-}
+}
--- a/ui-test-hilt-manifest/src/main/AndroidManifest.xml
+++ b/ui-test-hilt-manifest/src/main/AndroidManifest.xml
@ -27,4 +27,4 @@
            />
    </application>

-</manifest>
+</manifest>