From 27a05c416e5f4e8be48e3a727bd9949de2204910 Mon Sep 17 00:00:00 2001 From: Ben Weiss Date: Wed, 11 Dec 2024 13:45:45 +0100 Subject: [PATCH] Extract strict mode policy into function Change-Id: If170b2b05859ebfca7bc91ccc790be5b43a1b772 --- .../apps/nowinandroid/NiaApplication.kt | 22 ++++++++++++++----- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/app/src/main/kotlin/com/google/samples/apps/nowinandroid/NiaApplication.kt b/app/src/main/kotlin/com/google/samples/apps/nowinandroid/NiaApplication.kt index 507a8fe32..77f72e5fc 100644 --- a/app/src/main/kotlin/com/google/samples/apps/nowinandroid/NiaApplication.kt +++ b/app/src/main/kotlin/com/google/samples/apps/nowinandroid/NiaApplication.kt @@ -19,6 +19,7 @@ package com.google.samples.apps.nowinandroid import android.app.Application import android.content.pm.ApplicationInfo import android.os.StrictMode +import android.os.StrictMode.ThreadPolicy.Builder import coil.ImageLoader import coil.ImageLoaderFactory import com.google.samples.apps.nowinandroid.sync.initializers.Sync @@ -40,12 +41,7 @@ class NiaApplication : Application(), ImageLoaderFactory { override fun onCreate() { super.onCreate() - // Kill NiA if there are main thread policy violations and log the offending call. - if (isDebuggable()) { - StrictMode.setThreadPolicy( - StrictMode.ThreadPolicy.Builder().detectAll().penaltyLog().penaltyDeath().build(), - ) - } + setStrictModePolicy() // Initialize Sync; the system responsible for keeping data in the app up to date. Sync.initialize(context = this) @@ -60,4 +56,18 @@ class NiaApplication : Application(), ImageLoaderFactory { private fun isDebuggable(): Boolean { return 0 != applicationInfo.flags and ApplicationInfo.FLAG_DEBUGGABLE } + + /** + * Set a thread policy that detects all potential problems on the main thread, such as network + * and disk access. + * + * If a problem is found, the offending call will be logged and the application will be killed. + */ + private fun setStrictModePolicy() { + if (isDebuggable()) { + StrictMode.setThreadPolicy( + Builder().detectAll().penaltyLog().penaltyDeath().build(), + ) + } + } }