From 21bc291753c81e53eec4202e7afc30099a5ab533 Mon Sep 17 00:00:00 2001 From: TJ Dahunsi Date: Thu, 29 Jun 2023 16:46:35 +0100 Subject: [PATCH] Move analytics tracking of news deep link to an extension method Change-Id: Id3d1a30d86634b9176067696db5ecfd4d02854a5 --- .../feature/foryou/ForYouViewModel.kt | 25 +++++++++++-------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/feature/foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouViewModel.kt b/feature/foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouViewModel.kt index 49196a999..9427cd74c 100644 --- a/feature/foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouViewModel.kt +++ b/feature/foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouViewModel.kt @@ -131,17 +131,7 @@ class ForYouViewModel @Inject constructor( if (newsResourceId == deepLinkedNewsResource.value?.id) { savedStateHandle[LINKED_NEWS_RESOURCE_ID] = null } - analyticsHelper.logEvent( - AnalyticsEvent( - type = "news_deep_link_opened", - extras = listOf( - Param( - key = LINKED_NEWS_RESOURCE_ID, - value = newsResourceId, - ), - ), - ), - ) + analyticsHelper.logNewsDeepLinkOpen(newsResourceId = newsResourceId) viewModelScope.launch { userDataRepository.setNewsResourceViewed( newsResourceId = newsResourceId, @@ -156,3 +146,16 @@ class ForYouViewModel @Inject constructor( } } } + +private fun AnalyticsHelper.logNewsDeepLinkOpen(newsResourceId: String) = + logEvent( + AnalyticsEvent( + type = "news_deep_link_opened", + extras = listOf( + Param( + key = LINKED_NEWS_RESOURCE_ID, + value = newsResourceId, + ), + ), + ), + )