Revert AGP's APIs change workarounds with `.apply{}` to reduce visual changes as requested

pull/1959/head
Simon Marquis 9 months ago
parent 06fe6698f3
commit 1e7095d76a
No known key found for this signature in database

@ -31,7 +31,9 @@ internal fun Project.configureAndroidCompose(
commonExtension: CommonExtension,
) {
commonExtension.apply {
buildFeatures.compose = true
buildFeatures.apply {
compose = true
}
dependencies {
val bom = libs.findLibrary("androidx-compose-bom").get()

@ -35,20 +35,22 @@ internal fun configureGradleManagedDevices(
val ciDevices = listOf(pixel4, pixelC)
commonExtension.testOptions.managedDevices {
allDevices {
allDevices.forEach { deviceConfig ->
maybeCreate(deviceConfig.taskName, ManagedVirtualDevice::class.java).apply {
device = deviceConfig.device
apiLevel = deviceConfig.apiLevel
systemImageSource = deviceConfig.systemImageSource
commonExtension.testOptions.apply {
managedDevices {
allDevices {
allDevices.forEach { deviceConfig ->
maybeCreate(deviceConfig.taskName, ManagedVirtualDevice::class.java).apply {
device = deviceConfig.device
apiLevel = deviceConfig.apiLevel
systemImageSource = deviceConfig.systemImageSource
}
}
}
}
groups {
maybeCreate("ci").apply {
ciDevices.forEach { deviceConfig ->
targetDevices.add(localDevices[deviceConfig.taskName])
groups {
maybeCreate("ci").apply {
ciDevices.forEach { deviceConfig ->
targetDevices.add(localDevices[deviceConfig.taskName])
}
}
}
}

@ -37,13 +37,17 @@ internal fun Project.configureKotlinAndroid(
commonExtension.apply {
compileSdk = 35
defaultConfig.minSdk = 23
defaultConfig.apply {
minSdk = 23
}
// Up to Java 11 APIs are available through desugaring
// https://developer.android.com/studio/write/java11-minimal-support-table
compileOptions.sourceCompatibility = JavaVersion.VERSION_11
compileOptions.targetCompatibility = JavaVersion.VERSION_11
compileOptions.isCoreLibraryDesugaringEnabled = true
compileOptions.apply {
// Up to Java 11 APIs are available through desugaring
// https://developer.android.com/studio/write/java11-minimal-support-table
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
isCoreLibraryDesugaringEnabled = true
}
}
configureKotlin<KotlinAndroidProjectExtension>()

@ -28,13 +28,15 @@ fun configureFlavors(
flavorDimensions += flavorDimension.name
}
NiaFlavor.values().forEach { niaFlavor ->
productFlavors.register(niaFlavor.name) {
dimension = niaFlavor.dimension.name
flavorConfigurationBlock(this, niaFlavor)
if (this@apply is ApplicationExtension && this is ApplicationProductFlavor) {
if (niaFlavor.applicationIdSuffix != null) {
applicationIdSuffix = niaFlavor.applicationIdSuffix
productFlavors.apply {
NiaFlavor.values().forEach { niaFlavor ->
register(niaFlavor.name) {
dimension = niaFlavor.dimension.name
flavorConfigurationBlock(this, niaFlavor)
if (this@apply is ApplicationExtension && this is ApplicationProductFlavor) {
if (niaFlavor.applicationIdSuffix != null) {
applicationIdSuffix = niaFlavor.applicationIdSuffix
}
}
}
}

Loading…
Cancel
Save