From 15bc8f7da4ce1cd8f1f25de05f9263ab51a6227f Mon Sep 17 00:00:00 2001
From: Don Turner <donturner@google.com>
Date: Mon, 11 Mar 2024 21:56:16 +0000
Subject: [PATCH] Addressing feedback

Change-Id: I9c825c142799cdbb99890d49ded067427cf9fee8
---
 generateModuleGraphs.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/generateModuleGraphs.sh b/generateModuleGraphs.sh
index f69339502..fc4b190c8 100755
--- a/generateModuleGraphs.sh
+++ b/generateModuleGraphs.sh
@@ -56,7 +56,7 @@ check_and_create_readme() {
     local file_name="$2"
 
     local readme_path="${module_path:1}" # Remove leading colon
-    readme_path=$(echo "$readme_path" | sed 's/:/\//g') # Replace colons with slashes using sed
+    readme_path=${readme_path//:/\/} # Replace colons with slashes using sed
     readme_path="${readme_path}/README.md" #Append the filename
 
     # Check if README.md exists and create it if not
@@ -82,7 +82,9 @@ echo "$module_paths" | while read -r module_path; do
 
         # Generate the .gv file in a temporary location
         # </dev/null is used to stop ./gradlew from consuming input which prematurely ends the while loop
-        ./gradlew generateModulesGraphvizText -Pmodules.graph.output.gv="/tmp/${file_name}.gv" -Pmodules.graph.of.module="${module_path}" </dev/null
+        ./gradlew generateModulesGraphvizText \
+          -Pmodules.graph.output.gv="/tmp/${file_name}.gv" \
+          -Pmodules.graph.of.module="${module_path}" </dev/null
 
         # Convert to SVG using dot
         dot -Tsvg "/tmp/${file_name}.gv" > "docs/images/graphs/${file_name}.svg"