From 072364e7f16725db6e887957915ebf845e3447ba Mon Sep 17 00:00:00 2001 From: Keisuke Takagi Date: Sat, 18 Feb 2023 00:41:33 +0900 Subject: [PATCH] remove newsResourceTitle --- .../samples/apps/nowinandroid/core/ui/AnalyticsExtensions.kt | 2 +- .../com/google/samples/apps/nowinandroid/core/ui/NewsFeed.kt | 1 - .../samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/AnalyticsExtensions.kt b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/AnalyticsExtensions.kt index 38bce838a..bebaa4711 100644 --- a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/AnalyticsExtensions.kt +++ b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/AnalyticsExtensions.kt @@ -39,7 +39,7 @@ fun AnalyticsHelper.logScreenView(screenName: String) { ) } -fun AnalyticsHelper.logNewsResourceOpened(newsResourceId: String, newsResourceTitle: String) { +fun AnalyticsHelper.logNewsResourceOpened(newsResourceId: String) { logEvent( event = AnalyticsEvent( type = "news_resource_opened", diff --git a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsFeed.kt b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsFeed.kt index 3b0015bab..b085d27b7 100644 --- a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsFeed.kt +++ b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsFeed.kt @@ -67,7 +67,6 @@ fun LazyGridScope.newsFeed( onClick = { analyticsHelper.logNewsResourceOpened( newsResourceId = userNewsResource.id, - newsResourceTitle = userNewsResource.title, ) launchCustomChromeTab(context, resourceUrl, backgroundColor) }, diff --git a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt index 0f6861fbc..8429dbdda 100644 --- a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt +++ b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt @@ -56,7 +56,6 @@ fun LazyListScope.userNewsResourceCardItems( onClick = { analyticsHelper.logNewsResourceOpened( newsResourceId = userNewsResource.id, - newsResourceTitle = userNewsResource.title, ) when (onItemClick) { null -> launchCustomChromeTab(context, resourceUrl, backgroundColor)