refactor: use pluck instead of foreach and extra variable

3 years ago · e4ad83d2f4
parent f19513235b
commit e4ad83d2f4
1 changed files with 3 additions and 8 deletions
--- a/app/Http/Controllers/UserController.php
+++ b/app/Http/Controllers/UserController.php
@ -75,14 +75,9 @@ class UserController extends Controller {
            $user->tokens()->delete();
        }

-
-        $roles =  $user->roles()->get();
-        $_roles = [];
-        foreach ($roles as $role) {
-            $_roles[] = $role->slug;
-        }
-
-        $plainTextToken = $user->createToken('hydra-api-token', $_roles)->plainTextToken;
+        $roles =  $user->roles->pluck('slug')->all();
+        
+        $plainTextToken = $user->createToken('hydra-api-token', $roles)->plainTextToken;
        return response(['error' => 0, 'id' => $user->id, 'token' => $plainTextToken], 200);
    }