From fc74642ff835da9905a2587c944af2639a20e828 Mon Sep 17 00:00:00 2001
From: pizihao <2335715300@qq.com>
Date: Wed, 3 May 2023 10:26:17 +0800
Subject: [PATCH] fix : Adjust unit tests against simplified code(#1187) (#812)

---
 .../handler/NettyClientPoolHandlerTest.java   | 72 ++++++++++++++++++-
 .../rpc/server/NettyServerConnectionTest.java |  4 +-
 2 files changed, 72 insertions(+), 4 deletions(-)

diff --git a/hippo4j-rpc/src/test/java/cn/hippo4j/rpc/handler/NettyClientPoolHandlerTest.java b/hippo4j-rpc/src/test/java/cn/hippo4j/rpc/handler/NettyClientPoolHandlerTest.java
index e1806508..b5b25677 100644
--- a/hippo4j-rpc/src/test/java/cn/hippo4j/rpc/handler/NettyClientPoolHandlerTest.java
+++ b/hippo4j-rpc/src/test/java/cn/hippo4j/rpc/handler/NettyClientPoolHandlerTest.java
@@ -17,10 +17,28 @@
 
 package cn.hippo4j.rpc.handler;
 
+import cn.hippo4j.common.toolkit.ThreadUtil;
+import cn.hippo4j.common.web.exception.IllegalException;
+import cn.hippo4j.rpc.client.*;
+import cn.hippo4j.rpc.discovery.ClassRegistry;
+import cn.hippo4j.rpc.discovery.DefaultInstance;
+import cn.hippo4j.rpc.discovery.Instance;
+import cn.hippo4j.rpc.discovery.ServerPort;
+import cn.hippo4j.rpc.model.DefaultRequest;
+import cn.hippo4j.rpc.model.Request;
+import cn.hippo4j.rpc.model.Response;
+import cn.hippo4j.rpc.server.NettyServerConnection;
+import cn.hippo4j.rpc.server.RPCServer;
+import cn.hippo4j.rpc.server.ServerConnection;
 import io.netty.channel.ChannelHandler;
 import org.junit.Assert;
 import org.junit.Test;
 
+import java.io.IOException;
+import java.net.InetSocketAddress;
+import java.util.ArrayList;
+import java.util.List;
+
 public class NettyClientPoolHandlerTest {
 
     @Test
@@ -54,7 +72,7 @@ public class NettyClientPoolHandlerTest {
     public void addLast() {
         NettyClientPoolHandler handler = new NettyClientPoolHandler();
         Assert.assertTrue(handler.isEmpty());
-        handler.addLast(new TestHandler());
+        handler.addLast(null, new TestHandler());
         Assert.assertFalse(handler.isEmpty());
     }
 
@@ -62,7 +80,7 @@ public class NettyClientPoolHandlerTest {
     public void addFirst() {
         NettyClientPoolHandler handler = new NettyClientPoolHandler();
         Assert.assertTrue(handler.isEmpty());
-        handler.addFirst(new TestHandler());
+        handler.addFirst(null, new TestHandler());
         Assert.assertFalse(handler.isEmpty());
     }
 
@@ -81,4 +99,54 @@ public class NettyClientPoolHandlerTest {
         handler.addFirst("Test", new TestHandler());
         Assert.assertFalse(handler.isEmpty());
     }
+
+    @Test(expected = IllegalException.class)
+    public void testGetHandlerEntityFalse() {
+        TestFalseHandler handler = new TestFalseHandler();
+        long order = 0;
+        String name = "Test";
+        NettyClientPoolHandler poolHandler = new NettyClientPoolHandler();
+        poolHandler.getHandlerEntity(order, handler, name);
+    }
+
+    @Test
+    public void connectionTest() throws IOException {
+        ServerPort port = new ServerPort() {
+
+            final int a = RandomPort.getSafeRandomPort();
+
+            @Override
+            public int getPort() {
+                return a;
+            }
+        };
+        Class<CallManager> cls = CallManager.class;
+        String className = cls.getName();
+        ClassRegistry.put(className, cls);
+        // The mode connection was denied when the server was started on the specified port
+        Instance instance = new DefaultInstance();
+        NettyServerTakeHandler handler = new NettyServerTakeHandler(instance);
+        ServerConnection connection = new NettyServerConnection(handler);
+        RPCServer rpcServer = new RPCServer(connection, port);
+        rpcServer.bind();
+        while (!rpcServer.isActive()) {
+            ThreadUtil.sleep(100L);
+        }
+        InetSocketAddress address = InetSocketAddress.createUnresolved("localhost", port.getPort());
+        List<ChannelHandler> handlers = new ArrayList<>();
+        handlers.add(new NettyClientTakeHandler());
+        NettyClientPoolHandler channelPoolHandler = new NettyClientPoolHandler(handlers);
+        channelPoolHandler.addLast("test", new TestHandler());
+        ClientConnection clientConnection = new NettyClientConnection(address, channelPoolHandler);
+        RPCClient rpcClient = new RPCClient(clientConnection);
+        Request request = new DefaultRequest("127.0.0.18888", className, "call", null, null);
+        for (int i = 0; i < 50; i++) {
+            Response response = rpcClient.connection(request);
+            boolean active = rpcClient.isActive();
+            Assert.assertTrue(active);
+            Assert.assertEquals(response.getObj(), 1);
+        }
+        rpcClient.close();
+        rpcServer.close();
+    }
 }
\ No newline at end of file
diff --git a/hippo4j-rpc/src/test/java/cn/hippo4j/rpc/server/NettyServerConnectionTest.java b/hippo4j-rpc/src/test/java/cn/hippo4j/rpc/server/NettyServerConnectionTest.java
index 1a55a2ae..250429a8 100644
--- a/hippo4j-rpc/src/test/java/cn/hippo4j/rpc/server/NettyServerConnectionTest.java
+++ b/hippo4j-rpc/src/test/java/cn/hippo4j/rpc/server/NettyServerConnectionTest.java
@@ -27,7 +27,7 @@ public class NettyServerConnectionTest {
     public void addLast() {
         NettyServerConnection connection = new NettyServerConnection();
         Assert.assertTrue(connection.isEmpty());
-        connection.addLast(new TestHandler());
+        connection.addLast(null, new TestHandler());
         Assert.assertFalse(connection.isEmpty());
     }
 
@@ -35,7 +35,7 @@ public class NettyServerConnectionTest {
     public void addFirst() {
         NettyServerConnection connection = new NettyServerConnection();
         Assert.assertTrue(connection.isEmpty());
-        connection.addFirst(new TestHandler());
+        connection.addFirst(null, new TestHandler());
         Assert.assertFalse(connection.isEmpty());
     }