From ecb081b186a1a72160bde17bba8729b221957217 Mon Sep 17 00:00:00 2001 From: DDDreame Date: Wed, 17 May 2023 23:01:26 +0800 Subject: [PATCH] optimize: fix StyleCheck errors for hippo4j-threadpool-coore --- checkstyle/hippo4j_checkstyle_suppression.xml | 1 + .../cn/hippo4j/core/extension/annotation/Realization.java | 3 +++ .../main/java/cn/hippo4j/core/extension/reducer/None.java | 4 ++++ .../main/java/cn/hippo4j/core/extension/reducer/Reducer.java | 5 +++++ .../java/cn/hippo4j/core/extension/reducer/Reducers.java | 3 +++ .../core/extension/support/ExtensionAutoConfiguration.java | 3 +++ .../cn/hippo4j/core/extension/support/ExtensionRegistry.java | 2 +- .../hippo4j/core/extension/support/IExtensionRegistry.java | 3 +++ .../java/cn/hippo4j/core/extension/support/ReduceType.java | 3 +++ .../hippo4j/core/handler/DynamicThreadPoolBannerHandler.java | 2 +- 10 files changed, 27 insertions(+), 2 deletions(-) diff --git a/checkstyle/hippo4j_checkstyle_suppression.xml b/checkstyle/hippo4j_checkstyle_suppression.xml index 6d6baded..1a328a45 100644 --- a/checkstyle/hippo4j_checkstyle_suppression.xml +++ b/checkstyle/hippo4j_checkstyle_suppression.xml @@ -32,4 +32,5 @@ + diff --git a/threadpool/core/src/main/java/cn/hippo4j/core/extension/annotation/Realization.java b/threadpool/core/src/main/java/cn/hippo4j/core/extension/annotation/Realization.java index b67a58ca..90c35e60 100644 --- a/threadpool/core/src/main/java/cn/hippo4j/core/extension/annotation/Realization.java +++ b/threadpool/core/src/main/java/cn/hippo4j/core/extension/annotation/Realization.java @@ -25,6 +25,9 @@ import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; import java.lang.annotation.Target; +/** + * realization + */ @Inherited @Retention(RetentionPolicy.RUNTIME) @Target({ElementType.TYPE}) diff --git a/threadpool/core/src/main/java/cn/hippo4j/core/extension/reducer/None.java b/threadpool/core/src/main/java/cn/hippo4j/core/extension/reducer/None.java index db2c1fcc..9c4ea642 100644 --- a/threadpool/core/src/main/java/cn/hippo4j/core/extension/reducer/None.java +++ b/threadpool/core/src/main/java/cn/hippo4j/core/extension/reducer/None.java @@ -22,6 +22,10 @@ import cn.hippo4j.core.extension.support.ReduceType; import java.util.List; import java.util.stream.Collectors; +/** + * None extends + * @param + */ public class None extends Reducer> { @Override diff --git a/threadpool/core/src/main/java/cn/hippo4j/core/extension/reducer/Reducer.java b/threadpool/core/src/main/java/cn/hippo4j/core/extension/reducer/Reducer.java index 1fc2c2d3..111cb195 100644 --- a/threadpool/core/src/main/java/cn/hippo4j/core/extension/reducer/Reducer.java +++ b/threadpool/core/src/main/java/cn/hippo4j/core/extension/reducer/Reducer.java @@ -26,6 +26,11 @@ import lombok.Setter; import java.util.List; +/** + * reducer + * @param + * @param + */ public abstract class Reducer { @Getter diff --git a/threadpool/core/src/main/java/cn/hippo4j/core/extension/reducer/Reducers.java b/threadpool/core/src/main/java/cn/hippo4j/core/extension/reducer/Reducers.java index f2937205..83be76ec 100644 --- a/threadpool/core/src/main/java/cn/hippo4j/core/extension/reducer/Reducers.java +++ b/threadpool/core/src/main/java/cn/hippo4j/core/extension/reducer/Reducers.java @@ -23,6 +23,9 @@ import java.util.List; import java.util.Objects; import java.util.function.Predicate; +/** + * reducers + */ @SuppressWarnings("all") public class Reducers { diff --git a/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/ExtensionAutoConfiguration.java b/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/ExtensionAutoConfiguration.java index 67975b85..ea924ace 100644 --- a/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/ExtensionAutoConfiguration.java +++ b/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/ExtensionAutoConfiguration.java @@ -21,6 +21,9 @@ import cn.hippo4j.core.extension.config.ExtensionRegisterBootstrap; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; +/** + * extension auto configuration + */ @Configuration public class ExtensionAutoConfiguration { diff --git a/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/ExtensionRegistry.java b/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/ExtensionRegistry.java index 33178c5a..c2406bde 100644 --- a/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/ExtensionRegistry.java +++ b/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/ExtensionRegistry.java @@ -34,7 +34,7 @@ import java.util.concurrent.ConcurrentHashMap; * Extension registry */ @Slf4j -public class ExtensionRegistry implements IExtensionRegistry { +public final class ExtensionRegistry implements IExtensionRegistry { private final Map, List> registry = new ConcurrentHashMap<>(); diff --git a/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/IExtensionRegistry.java b/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/IExtensionRegistry.java index 9f3b5ae9..44a1e479 100644 --- a/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/IExtensionRegistry.java +++ b/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/IExtensionRegistry.java @@ -21,6 +21,9 @@ import cn.hippo4j.core.extension.IExtension; import java.util.List; +/** + * extension registry interface + */ public interface IExtensionRegistry { void register(IExtension realization); diff --git a/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/ReduceType.java b/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/ReduceType.java index f2ab125e..48bd65a7 100644 --- a/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/ReduceType.java +++ b/threadpool/core/src/main/java/cn/hippo4j/core/extension/support/ReduceType.java @@ -17,6 +17,9 @@ package cn.hippo4j.core.extension.support; +/** + * reduce type + */ public enum ReduceType { NONE, diff --git a/threadpool/core/src/main/java/cn/hippo4j/core/handler/DynamicThreadPoolBannerHandler.java b/threadpool/core/src/main/java/cn/hippo4j/core/handler/DynamicThreadPoolBannerHandler.java index 521a3e47..9ae456d1 100644 --- a/threadpool/core/src/main/java/cn/hippo4j/core/handler/DynamicThreadPoolBannerHandler.java +++ b/threadpool/core/src/main/java/cn/hippo4j/core/handler/DynamicThreadPoolBannerHandler.java @@ -70,7 +70,7 @@ public class DynamicThreadPoolBannerHandler implements InitializingBean { while (padding.length() < STRAP_LINE_SIZE - (bannerVersion.length() + DYNAMIC_THREAD_POOL.length())) { padding.append(" "); } - System.out.println(AnsiOutput.toString(banner, AnsiColor.GREEN, DYNAMIC_THREAD_POOL, AnsiColor.DEFAULT, + log.info(AnsiOutput.toString(banner, AnsiColor.GREEN, DYNAMIC_THREAD_POOL, AnsiColor.DEFAULT, padding.toString(), AnsiStyle.FAINT, bannerVersion, "\n\n", HIPPO4J_GITHUB, "\n", HIPPO4J_SITE, "\n")); }