The UUID string representation is as described by this BNF: + *
+ * + * @return A string representation of this {@code UUID} */ public static String toString(UUID uuid, boolean isSimple) { long mostSigBits = uuid.getMostSignificantBits(); diff --git a/hippo4j-common/src/main/java/cn/hippo4j/common/toolkit/Joiner.java b/hippo4j-common/src/main/java/cn/hippo4j/common/toolkit/Joiner.java index 05eefe1f..de798647 100644 --- a/hippo4j-common/src/main/java/cn/hippo4j/common/toolkit/Joiner.java +++ b/hippo4j-common/src/main/java/cn/hippo4j/common/toolkit/Joiner.java @@ -23,7 +23,8 @@ import java.util.Iterator; import java.util.Objects; /** - * reference google guava + * reference google guava+ * {@code + * UUID ="-" "-" + * "-" + * "-" + * + * time_low = 4* + * time_mid = 2* + * time_high_and_version = 2* + * variant_and_sequence = 2* + * node = 6* + * hexOctet = + * hexDigit = + * "0" | "1" | "2" | "3" | "4" | "5" | "6" | "7" | "8" | "9" + * | "a" | "b" | "c" | "d" | "e" | "f" + * | "A" | "B" | "C" | "D" | "E" | "F" + * }
* this method has been deprecated, use isEmpty() instead. + * * @param str * @return */ @@ -302,7 +307,8 @@ public class StringUtil { * StringUtils.split("abc def", " ") = ["abc", "def"] * StringUtils.split("ab:cd:ef", ":") = ["ab", "cd", "ef"] * - * @param str the String to parse, may be null + * + * @param str the String to parse, may be null * @param separatorChars the characters used as the delimiters, * @return an array of parsed Strings */ diff --git a/hippo4j-common/src/main/java/cn/hippo4j/common/toolkit/http/HttpUtil.java b/hippo4j-common/src/main/java/cn/hippo4j/common/toolkit/http/HttpUtil.java index a992c521..1aaae2b9 100644 --- a/hippo4j-common/src/main/java/cn/hippo4j/common/toolkit/http/HttpUtil.java +++ b/hippo4j-common/src/main/java/cn/hippo4j/common/toolkit/http/HttpUtil.java @@ -319,7 +319,7 @@ public class HttpUtil { } connection.connect(); JdkHttpClientResponse response = new JdkHttpClientResponse(connection); - if (HttpResponseCode.SC_OK != response.getStatusCode()) { + if (!HttpResponseCode.isOk(response.getStatusCode())) { String msg = String.format("HttpPost response code error. [code] %s [url] %s [body] %s", response.getStatusCode(), connection.getURL(), response.getBodyString()); throw new ServiceException(msg); } diff --git a/hippo4j-config/src/test/java/cn/hippo4j/config/toolkit/MapUtilTest.java b/hippo4j-common/src/test/java/cn/hippo4j/common/toolkit/MapUtilTest.java similarity index 85% rename from hippo4j-config/src/test/java/cn/hippo4j/config/toolkit/MapUtilTest.java rename to hippo4j-common/src/test/java/cn/hippo4j/common/toolkit/MapUtilTest.java index 440b84dd..b0c00d04 100644 --- a/hippo4j-config/src/test/java/cn/hippo4j/config/toolkit/MapUtilTest.java +++ b/hippo4j-common/src/test/java/cn/hippo4j/common/toolkit/MapUtilTest.java @@ -15,10 +15,8 @@ * limitations under the License. */ -package cn.hippo4j.config.toolkit; +package cn.hippo4j.common.toolkit; -import cn.hippo4j.common.toolkit.Assert; -import cn.hippo4j.common.toolkit.CollectionUtil; import org.junit.Test; import java.util.HashMap; @@ -66,9 +64,9 @@ public class MapUtilTest { @Test public void computeIfAbsentNotExistKeyTest() { - Map