Merge pull request #365 from shining-stars-lk/develop

Optimized netty functions

hippo4j-config/src/main/java/cn/hippo4j/config/netty/MonitorNettyServer.java

@@ -68,8 +68,8 @@ public class MonitorNettyServer {
                 serverBootstrap.group(bossGroup, workGroup)
                         .channel(NioServerSocketChannel.class)
                         .handler(new LoggingHandler(LogLevel.INFO))
-                        // childHandler的任务由workGroup来执行
-                        // 如果是handler，则由bossGroup来执行
+                        // BossGroup the Thread group is responsible for connection events
+                        // WorkGroup the thread group is responsible for read and write events
                         .childHandler(new ChannelInitializer<SocketChannel>() {
 
                             @Override

hippo4j-spring-boot/hippo4j-spring-boot-starter/src/main/java/cn/hippo4j/springboot/starter/monitor/send/netty/NettyConnectSender.java

@@ -43,7 +43,6 @@ import org.springframework.stereotype.Component;
  */
 @Slf4j
 @AllArgsConstructor
-@Component
 public class NettyConnectSender implements MessageSender {
 
     private ServerNettyAgent serverNettyAgent;
@@ -59,7 +58,7 @@ public class NettyConnectSender implements MessageSender {
                     .handler(new ChannelInitializer<SocketChannel>() {
 
                         @Override
-                        protected void initChannel(SocketChannel ch) throws Exception {
+                        protected void initChannel(SocketChannel ch) {
                             ChannelPipeline pipeline = ch.pipeline();
                             pipeline.addLast(new ObjectEncoder());
                             pipeline.addLast(new ObjectDecoder(Integer.MAX_VALUE,
@@ -71,8 +70,6 @@ public class NettyConnectSender implements MessageSender {
             bootstrap.connect(serverNettyAgent.getNettyServerAddress(), serverNettyAgent.getNettyServerPort()).sync();
         } catch (Exception e) {
             log.error("netty send error ", e);
-        } /*
-           * finally { eventLoopGroup.shutdownGracefully(); }
-           */
+        }
     }
 }

pom.xml

@@ -50,7 +50,7 @@
         <rocketmq.version>2.2.2</rocketmq.version>
         <tomcat-embed-core.version>9.0.55</tomcat-embed-core.version>
         <spring-cloud-starter-stream-rocketmq.version>2.2.6.RELEASE</spring-cloud-starter-stream-rocketmq.version>
-        <netty.version>4.1.42.Final</netty.version>
+        <netty.version>4.1.56.Final</netty.version>
         <spring-cloud-starter-netflix-hystrix.version>2.2.9.RELEASE</spring-cloud-starter-netflix-hystrix.version>
 
         <!-- Maven & Build -->