From 8ccf6ba22c663de14cfad0f6999e62e35380dc89 Mon Sep 17 00:00:00 2001 From: Annibale Ippolito <101899632+annippolito@users.noreply.github.com> Date: Fri, 26 May 2023 09:07:02 +0200 Subject: [PATCH] test: Add test case for LogMessage #1331 (#1343) * test: Add test case for LogMessage #1331 * change method signatures in LogMessage tests #1331 --------- Co-authored-by: annippolito --- .../design/AbstractSubjectCenterTest.java | 23 ++++- .../toolkit/logtracing/LogMessageTest.java | 93 +++++++++++++++++++ 2 files changed, 113 insertions(+), 3 deletions(-) create mode 100644 infra/common/src/test/java/cn/hippo4j/common/toolkit/logtracing/LogMessageTest.java diff --git a/infra/common/src/test/java/cn/hippo4j/common/extension/design/AbstractSubjectCenterTest.java b/infra/common/src/test/java/cn/hippo4j/common/extension/design/AbstractSubjectCenterTest.java index 44c31294..74bf2eac 100644 --- a/infra/common/src/test/java/cn/hippo4j/common/extension/design/AbstractSubjectCenterTest.java +++ b/infra/common/src/test/java/cn/hippo4j/common/extension/design/AbstractSubjectCenterTest.java @@ -1,3 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + package cn.hippo4j.common.extension.design; import lombok.Getter; @@ -13,8 +30,7 @@ import java.util.concurrent.atomic.AtomicInteger; public class AbstractSubjectCenterTest { - - private Map> OBSERVERS_MAP ; + private Map> OBSERVERS_MAP; private SubjectNotifyListener subjectNotifyListener; @@ -130,13 +146,14 @@ public class AbstractSubjectCenterTest { @Getter private static final class NotifyMessage { + private final AtomicInteger count = new AtomicInteger(0); } /** * Subject Response Listener */ - private static final class SubjectNotifyListener implements Observer{ + private static final class SubjectNotifyListener implements Observer { @Override public void accept(ObserverMessage observerMessage) { diff --git a/infra/common/src/test/java/cn/hippo4j/common/toolkit/logtracing/LogMessageTest.java b/infra/common/src/test/java/cn/hippo4j/common/toolkit/logtracing/LogMessageTest.java new file mode 100644 index 00000000..3d486bcf --- /dev/null +++ b/infra/common/src/test/java/cn/hippo4j/common/toolkit/logtracing/LogMessageTest.java @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package cn.hippo4j.common.toolkit.logtracing; + +import org.apache.logging.log4j.util.Strings; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNotSame; +import static org.junit.jupiter.api.Assertions.assertTrue; + +class LogMessageTest { + + private final static String MESSAGE = "message"; + private final static String THROWABLE_MESSAGE = "throwable message"; + + private LogMessage logMessage; + + @BeforeEach + public void init() { + logMessage = LogMessage.getInstance(); + } + + @Test + void testGetInstanceShouldReturnANewLogMessageInstance() { + final LogMessage newInstance = LogMessage.getInstance(); + assertNotNull(newInstance); + assertNotSame(logMessage, newInstance); + } + + @Test + void testToStringShouldHaveAnEmptyMessage() { + assertEquals(Strings.EMPTY, logMessage.toString()); + } + + @Test + void testSetMsgShouldSetAnewMessageInLogMessage() { + logMessage.setMsg(MESSAGE); + assertEquals(MESSAGE, logMessage.toString()); + } + + @Test + void testMsgShouldContainsMessageAndThrowableMessage() { + final String message = logMessage.msg(MESSAGE, new Throwable(THROWABLE_MESSAGE)); + assertNotNull(message); + assertTrue(message.contains(MESSAGE)); + assertTrue(message.contains(THROWABLE_MESSAGE)); + } + + @Test + void testKvShouldPutKeyAndValue() { + logMessage.kv("key", "value"); + assertEquals("key=value", logMessage.toString()); + } + + @Test + void testKvShouldPutAllKeyAndValuePairs() { + logMessage.kv("key1", "value1"); + logMessage.kv("key2", "value2"); + assertEquals("key1=value1||key2=value2", logMessage.toString()); + } + + @Test + void testToStringShouldPrintMessageAndAllKeyAndValuePairs() { + logMessage.setMsg(MESSAGE); + logMessage.kv("key1", "value1"); + logMessage.kv("key2", "value2"); + assertEquals("messagekey1=value1||key2=value2", logMessage.toString()); + } + + @Test + void testKv2StringShouldPrintMessageAndAllKeyAndValuePairs() { + String result = logMessage.kv2String("key", "value"); + assertEquals("key=value", result); + } +} \ No newline at end of file