From 5a124e85a99a1caa5c4dc9db96404c778591d08d Mon Sep 17 00:00:00 2001
From: Xin Chen <37373516+DDreame@users.noreply.github.com>
Date: Wed, 17 May 2023 20:36:16 +0800
Subject: [PATCH] optimize: fix StyleCheck errors for hippo4j-agent-bootstrap
 (#1292)

* optimize: fix StyleCheck errors for hippo4j-agent-bootstrap

* optimize: fix StyleCheck errors for hippo4j-agent-bootstrap

* optimize: fix StyleCheck errors for hippo4j-agent-bootstrap
---
 .../hippo4j/agent/bootstrap/Hippo4jAgent.java   | 17 ++++++++++++-----
 checkstyle/hippo4j_checkstyle_suppression.xml   |  2 ++
 2 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/agents/threadpool/hippo4j-agent-bootstrap/src/main/java/cn/hippo4j/agent/bootstrap/Hippo4jAgent.java b/agents/threadpool/hippo4j-agent-bootstrap/src/main/java/cn/hippo4j/agent/bootstrap/Hippo4jAgent.java
index afae5cc0..64f6ce9c 100644
--- a/agents/threadpool/hippo4j-agent-bootstrap/src/main/java/cn/hippo4j/agent/bootstrap/Hippo4jAgent.java
+++ b/agents/threadpool/hippo4j-agent-bootstrap/src/main/java/cn/hippo4j/agent/bootstrap/Hippo4jAgent.java
@@ -18,7 +18,6 @@
 package cn.hippo4j.agent.bootstrap;
 
 import cn.hippo4j.agent.core.boot.AgentPackageNotFoundException;
-import cn.hippo4j.agent.core.boot.DefaultNamedThreadFactory;
 import cn.hippo4j.agent.core.boot.ServiceManager;
 import cn.hippo4j.agent.core.conf.Config;
 import cn.hippo4j.agent.core.conf.SnifferConfigInitializer;
@@ -49,15 +48,14 @@ import java.security.ProtectionDomain;
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
-import java.util.concurrent.ArrayBlockingQueue;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.ThreadPoolExecutor;
-import java.util.concurrent.TimeUnit;
 
 import static net.bytebuddy.matcher.ElementMatchers.nameContains;
 import static net.bytebuddy.matcher.ElementMatchers.nameStartsWith;
 import static net.bytebuddy.matcher.ElementMatchers.not;
 
+/**
+ * Hippo4j Agent
+ */
 public class Hippo4jAgent {
 
     private static ILog LOGGER = LogManager.getLogger(Hippo4jAgent.class);
@@ -151,6 +149,9 @@ public class Hippo4jAgent {
                 .addShutdownHook(new Thread(ServiceManager.INSTANCE::shutdown, "hippo4j service shutdown thread"));
     }
 
+    /**
+     * transformer
+     */
     private static class Transformer implements AgentBuilder.Transformer {
 
         private PluginFinder pluginFinder;
@@ -193,6 +194,9 @@ public class Hippo4jAgent {
         return nameStartsWith("cn.hippo4j").and(not(nameStartsWith("cn.hippo4j.agent.toolkit.")));
     }
 
+    /**
+     * listener
+     */
     private static class Listener implements AgentBuilder.Listener {
 
         @Override
@@ -235,6 +239,9 @@ public class Hippo4jAgent {
         }
     }
 
+    /**
+     * redefinition listener
+     */
     private static class RedefinitionListener implements AgentBuilder.RedefinitionStrategy.Listener {
 
         @Override
diff --git a/checkstyle/hippo4j_checkstyle_suppression.xml b/checkstyle/hippo4j_checkstyle_suppression.xml
index 39de4153..6d6baded 100644
--- a/checkstyle/hippo4j_checkstyle_suppression.xml
+++ b/checkstyle/hippo4j_checkstyle_suppression.xml
@@ -30,4 +30,6 @@
     <suppress checks="MagicNumber" files="DashboardServiceImpl.java"/>
     <suppress checks="MagicNumber" files="DefaultThreadPoolCheckAlarmHandler.java"/>
     <suppress checks="TypeName" files="SpringBootConfig.java"/>
+    <suppress checks="ReturnCount" files="Hippo4jAgent.java"/>
+    <suppress checks="StaticVariableName" files="Hippo4jAgent.java"/>
 </suppressions>