From 2ca2c392a5738d735c6468e75ff0454d56f04707 Mon Sep 17 00:00:00 2001 From: DDDreame Date: Tue, 16 May 2023 02:21:06 +0800 Subject: [PATCH] fix checkType errors about module hippo4j-threadpool-rpc. --- .../java/cn/hippo4j/rpc/client/NettyClientConnection.java | 4 +++- .../src/main/java/cn/hippo4j/rpc/coder/NettyEncoder.java | 5 +++-- .../main/java/cn/hippo4j/rpc/handler/HandlerManager.java | 4 ++++ .../src/main/java/cn/hippo4j/rpc/model/DefaultRequest.java | 6 ++++-- .../src/main/java/cn/hippo4j/rpc/model/DefaultResponse.java | 6 ++++-- .../java/cn/hippo4j/rpc/server/NettyServerConnection.java | 3 ++- 6 files changed, 20 insertions(+), 8 deletions(-) diff --git a/threadpool/rpc/src/main/java/cn/hippo4j/rpc/client/NettyClientConnection.java b/threadpool/rpc/src/main/java/cn/hippo4j/rpc/client/NettyClientConnection.java index e6337999..b98228c7 100644 --- a/threadpool/rpc/src/main/java/cn/hippo4j/rpc/client/NettyClientConnection.java +++ b/threadpool/rpc/src/main/java/cn/hippo4j/rpc/client/NettyClientConnection.java @@ -49,6 +49,8 @@ public class NettyClientConnection implements ClientConnection { * Obtain the connection timeout period. The default value is 30s */ long timeout = 30000L; + final int nanosPerMilliSecond = 1000000; + EventLoopGroup worker = new NioEventLoopGroup(); NettyConnectPool connectionPool; ChannelFuture future; @@ -74,7 +76,7 @@ public class NettyClientConnection implements ClientConnection { } // Wait for execution to complete ResultHolder.putThread(key, Thread.currentThread()); - LockSupport.parkNanos(timeout() * 1000000); + LockSupport.parkNanos(timeout() * nanosPerMilliSecond); response = ResultHolder.get(key); if (response == null) { throw new TimeOutException("Timeout waiting for server-side response"); diff --git a/threadpool/rpc/src/main/java/cn/hippo4j/rpc/coder/NettyEncoder.java b/threadpool/rpc/src/main/java/cn/hippo4j/rpc/coder/NettyEncoder.java index 7cbfaff7..3197b3a7 100644 --- a/threadpool/rpc/src/main/java/cn/hippo4j/rpc/coder/NettyEncoder.java +++ b/threadpool/rpc/src/main/java/cn/hippo4j/rpc/coder/NettyEncoder.java @@ -34,7 +34,8 @@ import java.io.Serializable; */ public class NettyEncoder extends MessageToByteEncoder { - private static final byte[] BYTE = new byte[4]; + private static final int BYTE_LENGTH = 4; + private static final byte[] BYTE = new byte[BYTE_LENGTH]; @Override protected void encode(ChannelHandlerContext ctx, Serializable msg, ByteBuf out) throws Exception { @@ -49,6 +50,6 @@ public class NettyEncoder extends MessageToByteEncoder { throw new CoderException("The encoding is abnormal, which may be caused by the transfer object being unable to be serialized"); } int endIndex = out.writerIndex(); - out.setInt(startIndex, endIndex - startIndex - 4); + out.setInt(startIndex, endIndex - startIndex - BYTE_LENGTH); } } diff --git a/threadpool/rpc/src/main/java/cn/hippo4j/rpc/handler/HandlerManager.java b/threadpool/rpc/src/main/java/cn/hippo4j/rpc/handler/HandlerManager.java index 18460ac3..fbc72bc4 100644 --- a/threadpool/rpc/src/main/java/cn/hippo4j/rpc/handler/HandlerManager.java +++ b/threadpool/rpc/src/main/java/cn/hippo4j/rpc/handler/HandlerManager.java @@ -73,6 +73,10 @@ public interface HandlerManager { return new HandlerEntity<>(order, handler, name); } + /** + * handler entity + * @param + */ @Getter @AllArgsConstructor class HandlerEntity implements Comparable> { diff --git a/threadpool/rpc/src/main/java/cn/hippo4j/rpc/model/DefaultRequest.java b/threadpool/rpc/src/main/java/cn/hippo4j/rpc/model/DefaultRequest.java index 4dc30bb8..a49ad075 100644 --- a/threadpool/rpc/src/main/java/cn/hippo4j/rpc/model/DefaultRequest.java +++ b/threadpool/rpc/src/main/java/cn/hippo4j/rpc/model/DefaultRequest.java @@ -71,10 +71,12 @@ public final class DefaultRequest implements Request { @Override public boolean equals(Object o) { - if (this == o) + if (this == o) { return true; - if (o == null || getClass() != o.getClass()) + } + if (o == null || getClass() != o.getClass()) { return false; + } DefaultRequest that = (DefaultRequest) o; return Objects.equals(key, that.key) && Objects.equals(className, that.className) diff --git a/threadpool/rpc/src/main/java/cn/hippo4j/rpc/model/DefaultResponse.java b/threadpool/rpc/src/main/java/cn/hippo4j/rpc/model/DefaultResponse.java index 0fc68f44..1f4d46ae 100644 --- a/threadpool/rpc/src/main/java/cn/hippo4j/rpc/model/DefaultResponse.java +++ b/threadpool/rpc/src/main/java/cn/hippo4j/rpc/model/DefaultResponse.java @@ -84,10 +84,12 @@ public class DefaultResponse implements Response { @Override public boolean equals(Object o) { - if (this == o) + if (this == o) { return true; - if (o == null || getClass() != o.getClass()) + } + if (o == null || getClass() != o.getClass()) { return false; + } DefaultResponse that = (DefaultResponse) o; return Objects.equals(key, that.key) && Objects.equals(cls, that.cls); } diff --git a/threadpool/rpc/src/main/java/cn/hippo4j/rpc/server/NettyServerConnection.java b/threadpool/rpc/src/main/java/cn/hippo4j/rpc/server/NettyServerConnection.java index a6adc0d1..65a8c2b6 100644 --- a/threadpool/rpc/src/main/java/cn/hippo4j/rpc/server/NettyServerConnection.java +++ b/threadpool/rpc/src/main/java/cn/hippo4j/rpc/server/NettyServerConnection.java @@ -56,6 +56,7 @@ public class NettyServerConnection extends AbstractNettyHandlerManager implement Class socketChannelCls = NioServerSocketChannel.class; ChannelFuture future; Channel channel; + private final int maxPortNum = 65535; public NettyServerConnection(EventLoopGroup leader, EventLoopGroup worker, List handlers) { super(handlers); @@ -80,7 +81,7 @@ public class NettyServerConnection extends AbstractNettyHandlerManager implement @Override public void bind(ServerPort port) { int serverPort = port.getPort(); - if (serverPort < 0 || serverPort > 65535) { + if (serverPort < 0 || serverPort > maxPortNum) { throw new ConnectionException("The port number " + serverPort + " is outside 0~65535, which is not a legal port number"); } ServerBootstrap server = new ServerBootstrap();